Give each Kitty I= transmission an image of its own #102

Merged

natsukium merged 1 commit from fix/image-numbers into main 2026-10-12 01:32:03 +09:00

Conversation 0 Commits 1 Files changed 8 +257 -60

natsukium commented 2026-10-12 00:53:07 +09:00

Owner

Copy link

felis took a Kitty graphics I= image number as the image id. A second transmission with the same number replaced the first, the reply never named the id, and d=n/d=N were refused.

This follows kitty (graphics.c handle_add_command, img_by_client_number, get_free_client_id, handle_delete_command; kitty_tests/graphics.py test_load_images):

• Every I= transmission stores a new image under the lowest free id and answers i=<id>,I=<number>.
• a=p, a=f, a=a, a=c and d=f/F by I= act on the newest image with that number, ENOENT if none; a put's reply adds the resolved i=.
• d=n drops the newest such image's placements; d=N also frees it once unplaced.
• d=i/d=I match i= alone.
• Re-sending a numbered image by its i= keeps its number.

felis took a Kitty graphics `I=` image number as the image id. A second transmission with the same number replaced the first, the reply never named the id, and `d=n`/`d=N` were refused. This follows kitty (`graphics.c` `handle_add_command`, `img_by_client_number`, `get_free_client_id`, `handle_delete_command`; `kitty_tests/graphics.py` `test_load_images`): - Every `I=` transmission stores a new image under the lowest free id and answers `i=<id>,I=<number>`. - `a=p`, `a=f`, `a=a`, `a=c` and `d=f`/`F` by `I=` act on the newest image with that number, `ENOENT` if none; a put's reply adds the resolved `i=`. - `d=n` drops the newest such image's placements; `d=N` also frees it once unplaced. - `d=i`/`d=I` match `i=` alone. - Re-sending a numbered image by its `i=` keeps its number.

natsukium added 1 commit 2026-10-12 00:53:07 +09:00

grid, daemon: give each Kitty I= transmission an image of its own ... 49e7ce9ea2

felis took I= as the image id, so a second transmission with the same
number replaced the first, the reply never told the producer which id
it got, and d=n/d=N were refused as unknown. kitty stores every I=
transmission as a new image under the lowest free id, answers
i=<id>,I=<number>, resolves any other command's I= to the newest image
with that number, and deletes by number with d=n/d=N; felis now does
the same. d=i/d=I match i= alone, as kitty's id filter does.

Assisted-by: Claude Code

natsukium force-pushed fix/image-numbers from 49e7ce9ea2 to 3a6a091765 2026-10-12 00:58:11 +09:00 Compare

natsukium force-pushed fix/image-numbers from 3a6a091765 to 59b0a33fe6 2026-10-12 01:14:44 +09:00 Compare

natsukium merged commit b3e11651a5 into main 2026-10-12 01:32:03 +09:00

natsukium deleted branch fix/image-numbers 2026-10-12 01:32:03 +09:00

natsukium referenced this pull request from a commit 2026-10-12 01:32:04 +09:00

Merge pull request 'Give each Kitty I= transmission an image of its own' (#102) from fix/image-numbers into main

natsukium referenced this pull request 2026-10-12 01:32:09 +09:00

graphics: smaller Kitty graphics differences from kitty to decide on #84

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

Area/ci

CI workflows (.forgejo/workflows/)

  

Area/cli

felis-cli crate, the felis front-door binary

  

Area/client

felis-client crate, the winit GUI frontend

  

Area/client-core

felis-client-core crate, shadow screen, config, connect_or_spawn_daemon

  

Area/daemon

felis-daemon crate, session pool, IPC server

  

Area/deps

Dependency bumps

  

Area/docs

Documentation tree when no narrower area fits

  

Area/grid

felis-grid crate, cells, scrollback, image store

  

Area/manual

User-facing docs: tutorials, how-to, user-facing reference pages

  

Area/nix

Nix flake, home-manager module, package definitions

  

Area/protocol

felis-protocol crate, felis.proto, frame layout, version constants

  

Area/pty

felis-pty crate, PTY backends

  

Area/render

felis-render-wgpu crate, GPU pipeline, atlas

  

Area/shaping

felis-shaping crate, swash shaper, font fallback

  

Area/skills

Agent skills (skills/felis, .agents/skills/)

  

Area/transport

felis-transport crate, framing, socket/pipe, SSH carrier

  

Area/vt

felis-vt crate, VT parser, dispatch

  

Compat/Breaking

Breaking change that won't be backward compatible

  

Kind/Bug

Something is not working

  

Kind/Documentation

Documentation changes

  

Kind/Enhancement

Improve existing functionality

  

Kind/Feature

New functionality

  

Kind/Performance

Throughput, latency, or memory cost

  

Kind/Security

This is security issue

  

Kind/Testing

Issue or pull request related to testing

  

perf-regression-accepted

Passes the instruction-count bench gate for an intended cost; state why in a PR comment

  

Reviewed

Confirmed

Issue has been confirmed

  

Reviewed

Duplicate

This issue or pull request already exists

  

Reviewed

Invalid

Invalid issue

  

Reviewed

Won't Fix

This issue won't be fixed

  

Status

Blocked

Something is blocking this issue or pull request

  

Status

Need More Info

Feedback is required to reproduce issue or to continue work

  

Status

Upstream

Waiting on a change in an upstream project

No labels

Area/ci

Area/cli

Area/client

Area/client-core

Area/daemon

Area/deps

Area/docs

Area/grid

Area/manual

Area/nix

Area/protocol

Area/pty

Area/render

Area/shaping

Area/skills

Area/transport

Area/vt

Compat/Breaking

Kind/Bug

Kind/Documentation

Kind/Enhancement

Kind/Feature

Kind/Performance

Kind/Security

Kind/Testing

perf-regression-accepted

Reviewed

Confirmed

Reviewed

Duplicate

Reviewed

Invalid

Reviewed

Won't Fix

Status

Blocked

Status

Need More Info

Status

Upstream

Milestone

Clear milestone

No items

No milestone

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

felis-terminal/felis!102

No description provided.