felis-terminal/felis
Watch
1
Code Issues 6 Pull requests 2 Releases 8 Packages Activity Actions 11

shaping: build swash without overflow checks in dev #228

Closed
natsukium wants to merge 1 commit from shaping/swash-dev-overflow into main
pull from: shaping/swash-dev-overflow
merge into: felis-terminal:main
Conversation 0 Commits 1 Files changed 2 +17 -1
natsukium commented 2026-10-22 08:02:53 +09:00
Owner
Copy link

A debug client panicked in swash 0.2.10 (still the latest release) when it shaped a non-flag regional-indicator pair such as 🇦🇦. A GSUB multiple substitution in Noto Color Emoji maps a glyph to an empty sequence, and swash computes seqlen - 1; its extend only adds count to usize fields, so the release-build wrap is the intended decrement.

  • Cargo.toml: overflow-checks = false for swash in the dev profile (test and mutants inherit it), so dev and test builds match what ships.
  • felis-shaping: a test that shapes U+1F1E6 U+1F1E6 against the pinned test fonts; it panicked before this change.

Closes #22

A debug client panicked in swash 0.2.10 (still the latest release) when it shaped a non-flag regional-indicator pair such as 🇦🇦. A GSUB multiple substitution in Noto Color Emoji maps a glyph to an empty sequence, and swash computes `seqlen - 1`; its `extend` only adds `count` to `usize` fields, so the release-build wrap is the intended decrement. - `Cargo.toml`: `overflow-checks = false` for swash in the dev profile (test and mutants inherit it), so dev and test builds match what ships. - `felis-shaping`: a test that shapes U+1F1E6 U+1F1E6 against the pinned test fonts; it panicked before this change. Closes #22
shaping: build swash without overflow checks in dev
Some checks failed
fuzz / cargo fuzz nightly long-run (pull_request) Has been skipped
Details
darwin / detect relevant changes (pull_request) Successful in 9s
Details
darwin / darwin docs-only no-op (pull_request) Has been skipped
Details
windows / detect relevant changes (pull_request) Successful in 24s
Details
windows / windows docs-only no-op (pull_request) Has been skipped
Details
bench / instruction-count regression gate (pull_request) Successful in 1m18s
Details
darwin / build felis (aarch64-darwin) (pull_request) Successful in 2m40s
Details
fuzz / cargo fuzz smoke (per target) (pull_request) Successful in 2m2s
Details
windows / cargo nextest (Windows) (pull_request) Successful in 3m40s
Details
windows / frontend smoke (Windows) (pull_request) Successful in 1m2s
Details
pr / nix flake check (pull_request) Successful in 2m7s
Details
pr / cargo build / clippy / test / deny (pull_request) Failing after 2m31s
Details
pr / wire schema is compatible with the base (pull_request) Successful in 3s
Details
pr / frontend smoke (x86_64-linux) (pull_request) Successful in 45s
Details
windows / cargo clippy (Windows cross) (pull_request) Successful in 17s
Details
3785e846d9
 
swash 0.2.10, still the latest release, computes `seqlen - 1` when a
GSUB multiple substitution maps a glyph to an empty sequence. Noto Color
Emoji has such a rule, so a debug client panicked on a non-flag
regional-indicator pair such as U+1F1E6 U+1F1E6. Release builds wrap the
value into the intended decrement, so turning overflow checks off for
swash alone makes dev and test builds match what ships.

Closes #22

Assisted-by: Claude Code
natsukium closed this pull request 2026-10-22 11:00:10 +09:00
Some checks failed
fuzz / cargo fuzz nightly long-run (pull_request) Has been skipped
Details
darwin / detect relevant changes (pull_request) Successful in 9s
Required
Details
darwin / darwin docs-only no-op (pull_request) Has been skipped
Required
Details
windows / detect relevant changes (pull_request) Successful in 24s
Required
Details
windows / windows docs-only no-op (pull_request) Has been skipped
Required
Details
bench / instruction-count regression gate (pull_request) Successful in 1m18s
Details
darwin / build felis (aarch64-darwin) (pull_request) Successful in 2m40s
Required
Details
fuzz / cargo fuzz smoke (per target) (pull_request) Successful in 2m2s
Details
windows / cargo nextest (Windows) (pull_request) Successful in 3m40s
Required
Details
windows / frontend smoke (Windows) (pull_request) Successful in 1m2s
Required
Details
pr / nix flake check (pull_request) Successful in 2m7s
Required
Details
pr / cargo build / clippy / test / deny (pull_request) Failing after 2m31s
Required
Details
pr / wire schema is compatible with the base (pull_request) Successful in 3s
Required
Details
pr / frontend smoke (x86_64-linux) (pull_request) Successful in 45s
Required
Details
windows / cargo clippy (Windows cross) (pull_request) Successful in 17s
Required
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Area/ci
CI workflows (.forgejo/workflows/)

  
Area/cli
felis-cli crate, the felis front-door binary

  
Area/client
felis-client crate, the winit GUI frontend

  
Area/client-core
felis-client-core crate, shadow screen, config, connect_or_spawn_daemon

  
Area/daemon
felis-daemon crate, session pool, IPC server

  
Area/deps
Dependency bumps

  
Area/docs
Documentation tree when no narrower area fits

  
Area/grid
felis-grid crate, cells, scrollback, image store

  
Area/manual
User-facing docs: tutorials, how-to, user-facing reference pages

  
Area/nix
Nix flake, home-manager module, package definitions

  
Area/protocol
felis-protocol crate, felis.proto, frame layout, version constants

  
Area/pty
felis-pty crate, PTY backends

  
Area/render
felis-render-wgpu crate, GPU pipeline, atlas

  
Area/shaping
felis-shaping crate, swash shaper, font fallback

  
Area/skills
Agent skills (skills/felis, .agents/skills/)

  
Area/transport
felis-transport crate, framing, socket/pipe, SSH carrier

  
Area/vt
felis-vt crate, VT parser, dispatch

  
Compat/Breaking
Breaking change that won't be backward compatible

  
Kind/Bug
Something is not working

  
Kind/Documentation
Documentation changes

  
Kind/Enhancement
Improve existing functionality

  
Kind/Feature
New functionality

  
Kind/Performance
Throughput, latency, or memory cost

  
Kind/Security
This is security issue

  
Kind/Testing
Issue or pull request related to testing

  
perf-regression-accepted
Passes the instruction-count bench gate for an intended cost; state why in a PR comment

  
Reviewed
Confirmed
 Issue has been confirmed

  
Reviewed
Duplicate
 This issue or pull request already exists

  
Reviewed
Invalid
 Invalid issue

  
Reviewed
Won't Fix
 This issue won't be fixed

  
Status
Blocked
 Something is blocking this issue or pull request

  
Status
Need More Info
 Feedback is required to reproduce issue or to continue work

  
Status
Upstream
 Waiting on a change in an upstream project

No labels
Area/ci
Area/cli
Area/client
Area/client-core
Area/daemon
Area/deps
Area/docs
Area/grid
Area/manual
Area/nix
Area/protocol
Area/pty
Area/render
Area/shaping
Area/skills
Area/transport
Area/vt
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Performance
Kind/Security
Kind/Testing
perf-regression-accepted
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Blocked
Status
Need More Info
Status
Upstream
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
felis-terminal/felis!228
No description provided.