graphics: placeholder tiles stretch the image instead of fitting it with its aspect ratio #83

New issue

Closed

opened 2026-10-09 21:51:17 +09:00 by natsukium · 0 comments

natsukium commented

2026-10-09 21:51:17 +09:00

Owner

placeholder_tile_quad (crates/felis-render-wgpu/src/lib.rs) cuts the image into c×r slices and stretches each slice onto its cell. When the virtual placement's cell box has a different aspect ratio from the image, the image is distorted.

kitty: grman_put_cell_image scales the image uniformly to fit the c×r box and centers it, as the spec says: the image is fit "with its aspect ratio preserved".

Repro: a 200×100 image placed with a=p,U=1,i=1,c=10,r=10 and its placeholder cells printed. kitty draws it at 2:1 inside the box; felis stretches it to the box's full height.

Related: #42 covers the same question for direct placements with only c= or r=.

`placeholder_tile_quad` (`crates/felis-render-wgpu/src/lib.rs`) cuts the image into `c`×`r` slices and stretches each slice onto its cell. When the virtual placement's cell box has a different aspect ratio from the image, the image is distorted. **kitty:** `grman_put_cell_image` scales the image uniformly to fit the `c`×`r` box and centers it, as the spec says: the image is fit "with its aspect ratio preserved". **Repro:** a 200×100 image placed with `a=p,U=1,i=1,c=10,r=10` and its placeholder cells printed. kitty draws it at 2:1 inside the box; felis stretches it to the box's full height. Related: #42 covers the same question for direct placements with only `c=` or `r=`.

natsukium referenced this issue from a pull request that will close it,

2026-10-10 13:50:38 +09:00

Fit placeholder images with their aspect ratio #94

natsukium referenced this issue from a commit

2026-10-10 13:50:38 +09:00

render: fit placeholder images with their aspect ratio

natsukium referenced this issue from a commit

2026-10-11 00:42:51 +09:00

render: fit placeholder images with their aspect ratio

natsukium referenced this issue from a commit

2026-10-11 01:41:58 +09:00

render: fit placeholder images with their aspect ratio