Answer Kitty graphics commands the way kitty does #95

Merged

natsukium merged 1 commit from fix/graphics-replies into main 2026-10-11 23:26:20 +09:00

Conversation 0 Commits 1 Files changed 11 +332 -192

natsukium commented 2026-10-11 07:11:33 +09:00

Owner

Copy link

Part of #84 (replies and error codes).

felis now answers exactly the Kitty graphics commands kitty answers: only a command with a non-zero i= or I=, never a delete, and never a malformed escape. An explicit i=0/I=0 means no id, as in kitty's parser. Error codes match kitty's (EBADF for unreadable file/shm sources, EBADPNG for bad PNG, EINVAL for bad base64/zlib, ENODATA for short raw data).

Part of #84 (replies and error codes). felis now answers exactly the Kitty graphics commands kitty answers: only a command with a non-zero `i=` or `I=`, never a delete, and never a malformed escape. An explicit `i=0`/`I=0` means no id, as in kitty's parser. Error codes match kitty's (`EBADF` for unreadable file/shm sources, `EBADPNG` for bad PNG, `EINVAL` for bad base64/zlib, `ENODATA` for short raw data).

natsukium added 1 commit 2026-10-11 07:11:33 +09:00

vt, daemon: answer Kitty graphics commands the way kitty does ... e981c73912

Producers are written against kitty, so a reply kitty never sends
reaches whatever reads the PTY next. felis answered id-less commands
with an id-less OK or error, answered a malformed escape with EINVAL,
and answered failed deletes; each of those lands in the shell as text
when the producer does not read it, which is the common case for an
anonymous transmit (yazi's direct preview) or a bare cleanup delete.

kitty's finish_command_response answers only a command with a
non-zero i= or I=, and its delete path never answers. Its parser
defaults i= and I= to 0, so an explicit zero is the same as no id:
a=t,i=0 is an anonymous transmit rather than an EINVAL.

The error codes now match kitty's too, so a producer that branches on
them sees what it expects: an unreadable t=f/t=t/t=s source is EBADF
(was EIO), PNG data that does not decode is EBADPNG (was EBADF), bad
base64 or zlib data is EINVAL (was EBADF), and raw data shorter than
s x v is ENODATA (was EINVAL).

Assisted-by: Claude Code

natsukium force-pushed fix/graphics-replies from e981c73912 to ba020c0ebf 2026-10-11 07:17:42 +09:00 Compare

natsukium force-pushed fix/graphics-replies from ba020c0ebf to c3a54da4cf 2026-10-11 07:17:51 +09:00 Compare

natsukium force-pushed fix/graphics-replies from c3a54da4cf to bf1eab1364 2026-10-11 07:17:58 +09:00 Compare

natsukium force-pushed fix/graphics-replies from bf1eab1364 to 844f60d5ba 2026-10-11 07:28:02 +09:00 Compare

natsukium force-pushed fix/graphics-replies from 844f60d5ba to debfc3bff1 2026-10-11 07:32:45 +09:00 Compare

natsukium force-pushed fix/graphics-replies from debfc3bff1 to 3db1356cc6 2026-10-11 13:45:54 +09:00 Compare

natsukium merged commit b242d71105 into main 2026-10-11 23:26:20 +09:00

natsukium deleted branch fix/graphics-replies 2026-10-11 23:26:20 +09:00

natsukium referenced this pull request from a commit 2026-10-11 23:26:21 +09:00

Merge pull request 'Answer Kitty graphics commands the way kitty does' (#95) from fix/graphics-replies into main

natsukium referenced this pull request 2026-10-12 01:32:09 +09:00

graphics: smaller Kitty graphics differences from kitty to decide on #84

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

Area/ci

CI workflows (.forgejo/workflows/)

  

Area/cli

felis-cli crate, the felis front-door binary

  

Area/client

felis-client crate, the winit GUI frontend

  

Area/client-core

felis-client-core crate, shadow screen, config, connect_or_spawn_daemon

  

Area/daemon

felis-daemon crate, session pool, IPC server

  

Area/deps

Dependency bumps

  

Area/docs

Documentation tree when no narrower area fits

  

Area/grid

felis-grid crate, cells, scrollback, image store

  

Area/manual

User-facing docs: tutorials, how-to, user-facing reference pages

  

Area/nix

Nix flake, home-manager module, package definitions

  

Area/protocol

felis-protocol crate, felis.proto, frame layout, version constants

  

Area/pty

felis-pty crate, PTY backends

  

Area/render

felis-render-wgpu crate, GPU pipeline, atlas

  

Area/shaping

felis-shaping crate, swash shaper, font fallback

  

Area/skills

Agent skills (skills/felis, .agents/skills/)

  

Area/transport

felis-transport crate, framing, socket/pipe, SSH carrier

  

Area/vt

felis-vt crate, VT parser, dispatch

  

Compat/Breaking

Breaking change that won't be backward compatible

  

Kind/Bug

Something is not working

  

Kind/Documentation

Documentation changes

  

Kind/Enhancement

Improve existing functionality

  

Kind/Feature

New functionality

  

Kind/Performance

Throughput, latency, or memory cost

  

Kind/Security

This is security issue

  

Kind/Testing

Issue or pull request related to testing

  

perf-regression-accepted

Passes the instruction-count bench gate for an intended cost; state why in a PR comment

  

Reviewed

Confirmed

Issue has been confirmed

  

Reviewed

Duplicate

This issue or pull request already exists

  

Reviewed

Invalid

Invalid issue

  

Reviewed

Won't Fix

This issue won't be fixed

  

Status

Blocked

Something is blocking this issue or pull request

  

Status

Need More Info

Feedback is required to reproduce issue or to continue work

  

Status

Upstream

Waiting on a change in an upstream project

No labels

Area/ci

Area/cli

Area/client

Area/client-core

Area/daemon

Area/deps

Area/docs

Area/grid

Area/manual

Area/nix

Area/protocol

Area/pty

Area/render

Area/shaping

Area/skills

Area/transport

Area/vt

Compat/Breaking

Kind/Bug

Kind/Documentation

Kind/Enhancement

Kind/Feature

Kind/Performance

Kind/Security

Kind/Testing

perf-regression-accepted

Reviewed

Confirmed

Reviewed

Duplicate

Reviewed

Invalid

Reviewed

Won't Fix

Status

Blocked

Status

Need More Info

Status

Upstream

Milestone

Clear milestone

No items

No milestone

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

felis-terminal/felis!95

No description provided.