cli: pin the frozen argv grammar as one table #206

Merged

natsukium merged 1 commit from test/argv-matrix-185 into main 2026-09-07 23:11:11 +09:00

Conversation 0 Commits 1 Files changed 1 +168

natsukium commented 2026-09-07 22:48:24 +09:00

Owner

Copy link

Fixes #185.

The argv grammar the CLI surface has already frozen was pinned only by scattered individual assertions, or not asserted at all: a refactor that loosened one rule could land unnoticed. This adds one table-driven test per rule in crates/felis-cli/src/tests.rs, each stating the argv line and its outcome class, including the exit code a usage error owes its caller.

Rules covered: a program for sessions spawn only after --; the removed profiling and framing flags staying unknown arguments; a framing outside the verb's class; --raw without a payload; no frontend pass-through outside frontend.

Doc cascade: none — the change is test-only and documents no new behavior; the visible surface is already covered by docs/reference/cli.md and the help snapshots from #187.

Verified: just check green (fmt, clippy, nextest, deny, proto-compat); reviewed by pi luna + pi sol; docs proofread by Gemini gemini-3.8-flash-high

Deferred

• Folding the pre-existing scattered assertions (the_removed_trace_perf_flag_is_an_unknown_argument, the_retired_json_flag_is_an_unknown_argument, each_verb_accepts_only_its_own_classs_format, felis_ssh_is_not_a_verb) into the new table — the plan makes deletion optional, and those tests assert extra structure (the frontend pass-through payload, per-verb exhaustiveness of the point/stream classification) that the outcome-class table does not carry, so removing them would lose coverage.
• Extending the matrix to felis-client and felis-daemon serve argv — the accepted triage plan re-scoped this issue to the felis-cli parser matrix only; the public help surface of those binaries is covered by the help snapshot from #187.

Fixes #185. The argv grammar the CLI surface has already frozen was pinned only by scattered individual assertions, or not asserted at all: a refactor that loosened one rule could land unnoticed. This adds one table-driven test per rule in `crates/felis-cli/src/tests.rs`, each stating the argv line and its outcome class, including the exit code a usage error owes its caller. Rules covered: a program for `sessions spawn` only after `--`; the removed profiling and framing flags staying unknown arguments; a framing outside the verb's class; `--raw` without a payload; no frontend pass-through outside `frontend`. Doc cascade: none — the change is test-only and documents no new behavior; the visible surface is already covered by `docs/reference/cli.md` and the help snapshots from #187. Verified: just check green (fmt, clippy, nextest, deny, proto-compat); reviewed by pi luna + pi sol; docs proofread by Gemini gemini-3.8-flash-high ## Deferred - Folding the pre-existing scattered assertions (`the_removed_trace_perf_flag_is_an_unknown_argument`, `the_retired_json_flag_is_an_unknown_argument`, `each_verb_accepts_only_its_own_classs_format`, `felis_ssh_is_not_a_verb`) into the new table — the plan makes deletion optional, and those tests assert extra structure (the frontend pass-through payload, per-verb exhaustiveness of the point/stream classification) that the outcome-class table does not carry, so removing them would lose coverage. - Extending the matrix to `felis-client` and `felis-daemon serve` argv — the accepted triage plan re-scoped this issue to the felis-cli parser matrix only; the public help surface of those binaries is covered by the help snapshot from #187.

natsukium added 1 commit 2026-09-07 22:48:25 +09:00

cli: pin the frozen argv grammar as one table ... 8d45ea6f8c

The grammar decisions the surface has already frozen — a program for
`sessions spawn` only after `--`, the removed profiling and framing
flags staying unknown, a framing outside the verb's class, `--raw`
without a payload, no pass-through outside `frontend` — were spread
across individual assertions or not asserted at all, so a refactor that
loosened one could land unnoticed. One table per rule states the argv
line and the outcome class, including the exit code a usage error owes
its caller.

Refs #185

natsukium merged commit cf28886191 into main 2026-09-07 23:11:11 +09:00

natsukium deleted branch test/argv-matrix-185 2026-09-07 23:11:11 +09:00

natsukium referenced this pull request 2026-09-08 01:39:59 +09:00

[v0.1/CLI Args Review] CLI 引数のリリース前設計レビュー #55

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

priority/P0

Must be resolved before the v0.1.0 tag

  

priority/P1

Must be settled before the first public contract freezes

  

priority/P2

Explicitly deferred until after v0.1.0

  

release/v0.1.0

Work tracked for the first tagged release

  

status/blocked

Cannot start now: waits on an upstream release, another issue, or a recorded revisit trigger

  

status/planned

Triaged with a source-grounded plan and a passed pi review; ready to implement

  

type/bug

Shipped behavior that contradicts the docs or the code's own intent; needs a product code change

  

type/design

An open scope or trade-off question; needs a recorded decision in the owning explanation doc before code

  

type/test-gap

Documented or reviewed behavior that no test pins; usually split from a review finding, needs no product code change

  

type/tracker

Parent issue that tracks child work

No labels

priority/P0

priority/P1

priority/P2

release/v0.1.0

status/blocked

status/planned

type/bug

type/design

type/test-gap

type/tracker

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

natsukium/felis!206

No description provided.