natsukium/felis
Watch
1
Code Issues 27 Pull requests 1 Projects Releases Packages Wiki Activity Actions

workspace: single-source the crate version #223

Merged
natsukium merged 1 commit from chore/workspace-version-31 into main 2026-09-08 03:22:49 +09:00
Conversation 0 Commits 1 Files changed 19 +72 -42
natsukium commented 2026-09-08 02:45:12 +09:00
Owner
Copy link

Refs #31.

Preparation for the v0.1.0 release commit: with the version declared once under [workspace.package] and inherited by every member, cutting a release edits one line instead of twelve, and a missed member becomes impossible rather than merely detected.

  • Cargo.toml gains version = "0.1.0"; the eleven felis-* crates and the tests member take version.workspace = true.
  • nix/package.nix and scripts/make-macos-app.sh read [workspace.package] version instead of crates/felis-cli/Cargo.toml's [package] version, which no longer holds a string.
  • scripts/release/verify.sh compares the tag against the workspace version and asserts every crate inherits it; its self-test gains the crate-pins-its-own-version case.
  • docs/reference/workspace.md ("Versioning", "Release gate") and scripts/README.md state the new source of truth.

Verified: nix build .#felis (reports felis 0.1.0), nix eval --raw .#felis.version = 0.1.0, nix build .#checks.x86_64-linux.home-manager-module, and just check.

Refs #31. Preparation for the v0.1.0 release commit: with the version declared once under `[workspace.package]` and inherited by every member, cutting a release edits one line instead of twelve, and a missed member becomes impossible rather than merely detected. - `Cargo.toml` gains `version = "0.1.0"`; the eleven `felis-*` crates and the `tests` member take `version.workspace = true`. - `nix/package.nix` and `scripts/make-macos-app.sh` read `[workspace.package] version` instead of `crates/felis-cli/Cargo.toml`'s `[package] version`, which no longer holds a string. - `scripts/release/verify.sh` compares the tag against the workspace version and asserts every crate inherits it; its self-test gains the crate-pins-its-own-version case. - `docs/reference/workspace.md` ("Versioning", "Release gate") and `scripts/README.md` state the new source of truth. Verified: `nix build .#felis` (reports `felis 0.1.0`), `nix eval --raw .#felis.version` = `0.1.0`, `nix build .#checks.x86_64-linux.home-manager-module`, and `just check`.
workspace: single-source the crate version
All checks were successful
bench / Criterion full-suite snapshot (pull_request) Has been skipped
Details
fuzz / cargo fuzz nightly long-run (pull_request) Has been skipped
Details
fuzz / cargo fuzz smoke (per target) (pull_request) Successful in 1m11s
Details
pr / nix flake check (pull_request) Successful in 1m2s
Details
bench / Criterion regression gate (pull_request) Successful in 2m3s
Details
darwin / detect relevant changes (pull_request) Successful in 3s
Details
darwin / darwin docs-only no-op (pull_request) Has been skipped
Details
pr / cargo build / clippy / test / deny (pull_request) Successful in 1m47s
Details
pr / wire schema is compatible with the base (pull_request) Successful in 8s
Details
darwin / build felis (aarch64-darwin) (pull_request) Successful in 2m20s
Details
pr / frontend smoke (x86_64-linux) (pull_request) Successful in 54s
Details
pr / publish felis (x86_64-linux) (pull_request) Has been skipped
Details
windows / detect relevant changes (pull_request) Successful in 3s
Details
windows / windows docs-only no-op (pull_request) Has been skipped
Details
windows / cargo clippy (Windows cross) (pull_request) Successful in 15s
Details
windows / cargo nextest (Windows) (pull_request) Successful in 4m34s
Details
windows / frontend smoke (Windows) (pull_request) Successful in 1m46s
Details
windows / package felis (x86_64-pc-windows-msvc) (pull_request) Has been skipped
Details
2db46cc9f9
 
Every member declared its own `version = "0.1.0"`, so cutting a release
meant editing twelve manifests in lockstep and trusting that no member
was missed; the release gate compensated by comparing all of them
against the tag. Declaring the number once under `[workspace.package]`
and inheriting it makes the drift impossible instead of detected, and
turns a version bump into one line.

The two consumers that read a version out of a manifest by hand
(`nix/package.nix`, `scripts/make-macos-app.sh`) now read the workspace
field. `scripts/release/verify.sh` keeps its guard, aimed at what can
still drift: a member pinning a version of its own would silently
outrank the inherited one.

Refs #31
natsukium deleted branch chore/workspace-version-31 2026-09-08 03:22:50 +09:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
priority/P0
Must be resolved before the v0.1.0 tag

  
priority/P1
Must be settled before the first public contract freezes

  
priority/P2
Explicitly deferred until after v0.1.0

  
release/v0.1.0
Work tracked for the first tagged release

  
status/blocked
Cannot start now: waits on an upstream release, another issue, or a recorded revisit trigger

  
status/planned
Triaged with a source-grounded plan and a passed pi review; ready to implement

  
type/bug
Shipped behavior that contradicts the docs or the code's own intent; needs a product code change

  
type/design
An open scope or trade-off question; needs a recorded decision in the owning explanation doc before code

  
type/test-gap
Documented or reviewed behavior that no test pins; usually split from a review finding, needs no product code change

  
type/tracker
Parent issue that tracks child work

No labels
priority/P0
priority/P1
priority/P2
release/v0.1.0
status/blocked
status/planned
type/bug
type/design
type/test-gap
type/tracker
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
natsukium/felis!223
No description provided.