natsukium/felis
Watch
1
Code Issues 27 Pull requests 1 Projects Releases Packages Wiki Activity Actions

[v0.1/P1] Rename font.size to font.size_px #28

New issue
Closed
opened 2026-09-03 16:18:07 +09:00 by natsukium · 0 comments
natsukium commented 2026-09-03 16:18:07 +09:00
Owner
Copy link

Parent: #12 (P1.7). Supersedes the unit-naming part of #7.

Why

The configured font size is measured in logical pixels, while an unqualified terminal font size is commonly read as points. The pixel model is coherent; only the public key is ambiguous.

Scope

  • Rename font.size to font.size_px without a compatibility alias before the first release.
  • Keep internal variables explicit about logical versus physical pixels.
  • Update defaults, validation, live reload, keybinding zoom, and effective-config output.
  • Regenerate the JSON Schema.

Acceptance criteria

  • No user-facing config or diagnostic calls the value points or leaves the unit implicit.
  • The logical-pixel clamp and scaling behavior remain unchanged.
  • The old key is rejected or diagnosed according to the unknown-key contract, not silently accepted as an alias.
  • Config tests, schema, reference/manual examples, Home Manager module, and changelog are updated.
Parent: #12 (P1.7). Supersedes the unit-naming part of #7. ## Why The configured font size is measured in logical pixels, while an unqualified terminal font size is commonly read as points. The pixel model is coherent; only the public key is ambiguous. ## Scope - Rename `font.size` to `font.size_px` without a compatibility alias before the first release. - Keep internal variables explicit about logical versus physical pixels. - Update defaults, validation, live reload, keybinding zoom, and effective-config output. - Regenerate the JSON Schema. ## Acceptance criteria - [ ] No user-facing config or diagnostic calls the value points or leaves the unit implicit. - [ ] The logical-pixel clamp and scaling behavior remain unchanged. - [ ] The old key is rejected or diagnosed according to the unknown-key contract, not silently accepted as an alias. - [ ] Config tests, schema, reference/manual examples, Home Manager module, and changelog are updated.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
ci/darwin-smoke
No results found.
Labels
Clear labels   
priority/P0
Must be resolved before the v0.1.0 tag

  
priority/P1
Must be settled before the first public contract freezes

  
priority/P2
Explicitly deferred until after v0.1.0

  
release/v0.1.0
Work tracked for the first tagged release

  
status/blocked
Cannot start now: waits on an upstream release, another issue, or a recorded revisit trigger

  
status/planned
Triaged with a source-grounded plan and a passed pi review; ready to implement

  
type/bug
Shipped behavior that contradicts the docs or the code's own intent; needs a product code change

  
type/design
An open scope or trade-off question; needs a recorded decision in the owning explanation doc before code

  
type/test-gap
Documented or reviewed behavior that no test pins; usually split from a review finding, needs no product code change

  
type/tracker
Parent issue that tracks child work

No labels
priority/P0
priority/P1
priority/P2
release/v0.1.0
status/blocked
status/planned
type/bug
type/design
type/test-gap
type/tracker
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
natsukium/felis#28
No description provided.