chore: prune narrating comments from the batch-3 merges #76

Merged

natsukium merged 1 commit from chore/prune-comments-batch3 into main 2026-09-04 18:22:34 +09:00

Conversation 0 Commits 1 Files changed 26 +13 -82

natsukium commented 2026-09-04 17:56:50 +09:00

Owner

Copy link

A one-shot comment-pruning sweep over the Rust sources merged by #63, #68,
#70, #71 and #75. Those merges comment freely; the surplus buries the
comments that carry real information.

Removed: doc comments that only restate their test's or function's name,
narration of the following line, decorative section banners, and inline
notes duplicating a doc comment already on the item. Kept: why-nots,
// SAFETY:, spec/REQ/docs citations, cross-process and wire invariants,
and the public rustdoc of felis-protocol (the cross-language reference
surface).

No code changed. Every line in the diff is a comment or a blank line
one left behind — 82 deletions, 13 insertions (trims), across 26 files.

Gates, from the worktree:

• just fmt-check — clean
• cargo clippy --all-targets -- -D warnings — clean
• cargo nextest run --workspace — 3158 tests run: 3158 passed, 15 skipped
• cargo test --doc --workspace — 9 targets, all ok

Files touched:

• crates/felis-cli/src/cli_bridge.rs
• crates/felis-cli/src/cli_daemon.rs
• crates/felis-cli/src/cli_doctor.rs
• crates/felis-cli/src/cli_output.rs
• crates/felis-cli/src/cli_sessions.rs
• crates/felis-cli/src/conn.rs
• crates/felis-cli/tests/cli_bridge.rs
• crates/felis-cli/tests/cli_sessions.rs
• crates/felis-client/src/app_methods.rs
• crates/felis-client/src/event_handler.rs
• crates/felis-client/src/main.rs
• crates/felis-client/src/tests.rs
• crates/felis-daemon/src/pool.rs
• crates/felis-daemon/src/serve/session_task.rs
• crates/felis-daemon/src/serve/streaming.rs
• crates/felis-daemon/src/serve/tests.rs
• crates/felis-grid/src/images/tests.rs
• crates/felis-protocol/src/caps.rs
• crates/felis-protocol/src/codec.rs
• crates/felis-protocol/src/convert.rs
• crates/felis-protocol/src/convert/conn.rs
• crates/felis-protocol/src/frame.rs
• crates/felis-protocol/src/messages.rs
• crates/felis-protocol/src/preface.rs
• crates/felis-protocol/tests/proptest_frame.rs
• fuzz/fuzz_targets/ipc_frame.rs

A one-shot comment-pruning sweep over the Rust sources merged by #63, #68, #70, #71 and #75. Those merges comment freely; the surplus buries the comments that carry real information. Removed: doc comments that only restate their test's or function's name, narration of the following line, decorative section banners, and inline notes duplicating a doc comment already on the item. Kept: why-nots, `// SAFETY:`, spec/REQ/docs citations, cross-process and wire invariants, and the public rustdoc of `felis-protocol` (the cross-language reference surface). **No code changed.** Every line in the diff is a comment or a blank line one left behind — 82 deletions, 13 insertions (trims), across 26 files. Gates, from the worktree: - `just fmt-check` — clean - `cargo clippy --all-targets -- -D warnings` — clean - `cargo nextest run --workspace` — 3158 tests run: 3158 passed, 15 skipped - `cargo test --doc --workspace` — 9 targets, all ok Files touched: - `crates/felis-cli/src/cli_bridge.rs` - `crates/felis-cli/src/cli_daemon.rs` - `crates/felis-cli/src/cli_doctor.rs` - `crates/felis-cli/src/cli_output.rs` - `crates/felis-cli/src/cli_sessions.rs` - `crates/felis-cli/src/conn.rs` - `crates/felis-cli/tests/cli_bridge.rs` - `crates/felis-cli/tests/cli_sessions.rs` - `crates/felis-client/src/app_methods.rs` - `crates/felis-client/src/event_handler.rs` - `crates/felis-client/src/main.rs` - `crates/felis-client/src/tests.rs` - `crates/felis-daemon/src/pool.rs` - `crates/felis-daemon/src/serve/session_task.rs` - `crates/felis-daemon/src/serve/streaming.rs` - `crates/felis-daemon/src/serve/tests.rs` - `crates/felis-grid/src/images/tests.rs` - `crates/felis-protocol/src/caps.rs` - `crates/felis-protocol/src/codec.rs` - `crates/felis-protocol/src/convert.rs` - `crates/felis-protocol/src/convert/conn.rs` - `crates/felis-protocol/src/frame.rs` - `crates/felis-protocol/src/messages.rs` - `crates/felis-protocol/src/preface.rs` - `crates/felis-protocol/tests/proptest_frame.rs` - `fuzz/fuzz_targets/ipc_frame.rs`

natsukium added 1 commit 2026-09-04 17:56:50 +09:00

chore: prune narrating comments from the batch-3 merges ... 276baa4112

PRs #63, #68, #70, #71 and #75 were written by agents that comment
freely, and the surplus buries the comments that carry real
information. The house rule is that a comment records a why-not or an
invariant the code cannot show; narration of the next line, a doc
comment restating its item's name, and decorative section banners are
noise that goes stale on its own.

Comments only: every changed line is a comment or the blank line one
left behind, so no behavior, test name, or signature moves.

natsukium force-pushed chore/prune-comments-batch3 from 276baa4112 to 15cb05a7f9 2026-09-04 18:02:45 +09:00 Compare

natsukium referenced this pull request 2026-09-04 18:21:40 +09:00

CI: end-to-end connector tests time out when the runner host is saturated #78

natsukium merged commit f6f4973fce into main 2026-09-04 18:22:34 +09:00

natsukium deleted branch chore/prune-comments-batch3 2026-09-04 18:22:34 +09:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

priority/P0

Must be resolved before the v0.1.0 tag

  

priority/P1

Must be settled before the first public contract freezes

  

priority/P2

Explicitly deferred until after v0.1.0

  

release/v0.1.0

Work tracked for the first tagged release

  

status/blocked

Cannot start now: waits on an upstream release, another issue, or a recorded revisit trigger

  

status/planned

Triaged with a source-grounded plan and a passed pi review; ready to implement

  

type/bug

Shipped behavior that contradicts the docs or the code's own intent; needs a product code change

  

type/design

An open scope or trade-off question; needs a recorded decision in the owning explanation doc before code

  

type/test-gap

Documented or reviewed behavior that no test pins; usually split from a review finding, needs no product code change

  

type/tracker

Parent issue that tracks child work

No labels

priority/P0

priority/P1

priority/P2

release/v0.1.0

status/blocked

status/planned

type/bug

type/design

type/test-gap

type/tracker

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

natsukium/felis!76

No description provided.