Read Kitty file ranges and placeholder runs as kitty does #101

Merged

natsukium merged 3 commits from fix/file-offsets into main 2026-10-12 01:14:04 +09:00

Conversation 0 Commits 3 Files changed 6 +211 -102

natsukium commented 2026-10-12 00:43:25 +09:00

Owner

Copy link

Two places where felis read Kitty graphics input differently from kitty:

• t=f and t=t ignored S= and O= and read the whole file. kitty maps the named range for t=f, t=t and t=s alike and refuses a range past the end with EINVAL. The three methods now share one range check and one reader, and a refused temp file is still deleted.
• A Unicode-placeholder cell with the default foreground borrowed the image id of the cell before it. kitty's screen_render_line_graphics reads the default color as id 0, which names no image. A cell that leaves out the id's high-byte diacritic now takes it from its run, and a run only continues while the cell's diacritics agree with it.

A third commit applies the formatting #94 merged without, since the flake check could not reach its remote builder.

Two places where felis read Kitty graphics input differently from kitty: - `t=f` and `t=t` ignored `S=` and `O=` and read the whole file. kitty maps the named range for `t=f`, `t=t` and `t=s` alike and refuses a range past the end with `EINVAL`. The three methods now share one range check and one reader, and a refused temp file is still deleted. - A Unicode-placeholder cell with the default foreground borrowed the image id of the cell before it. kitty's `screen_render_line_graphics` reads the default color as id 0, which names no image. A cell that leaves out the id's high-byte diacritic now takes it from its run, and a run only continues while the cell's diacritics agree with it. A third commit applies the formatting #94 merged without, since the flake check could not reach its remote builder.

natsukium added 3 commits 2026-10-12 00:43:25 +09:00

render: format the placeholder tile test ... cb024865c3

The test landed unformatted while the flake check's treefmt build could
not reach its remote builder, so the check never ran on it.

Assisted-by: Claude Code

grid: resolve Kitty placeholder runs by kitty's rules ... 3131382fdf

A default-foreground placeholder cell used to borrow the image id of
the cell before it, so text drawn after an image in the default color
could extend the image. kitty's screen_render_line_graphics reads the
default color as id 0, which names no image. The same function lets a
cell take the id's high byte from its run when it omits the third
diacritic, and only continues a run whose diacritics agree with it;
felis now follows both.

Assisted-by: Claude Code

daemon: read the S=/O= range of Kitty file transmissions ... 93964bff27

t=f and t=t ignored S= and O= and read the whole file, so a producer
naming one image inside a larger file got the wrong bytes. kitty maps
the same range for t=f, t=t and t=s, and refuses one past the end with
EINVAL; the three methods now share one range check and reader. A
refused temp file is still deleted, since the producer handed it over.

Assisted-by: Claude Code

natsukium force-pushed fix/file-offsets from 93964bff27 to 623a5a03aa 2026-10-12 00:48:22 +09:00 Compare

natsukium force-pushed fix/file-offsets from 623a5a03aa to f67085e61a 2026-10-12 00:52:29 +09:00 Compare

natsukium merged commit a146044348 into main 2026-10-12 01:14:04 +09:00

natsukium deleted branch fix/file-offsets 2026-10-12 01:14:04 +09:00

natsukium referenced this pull request from a commit 2026-10-12 01:14:05 +09:00

Merge pull request 'Read Kitty file ranges and placeholder runs as kitty does' (#101) from fix/file-offsets into main

natsukium referenced this pull request 2026-10-12 01:32:09 +09:00

graphics: smaller Kitty graphics differences from kitty to decide on #84

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

Area/ci

CI workflows (.forgejo/workflows/)

  

Area/cli

felis-cli crate, the felis front-door binary

  

Area/client

felis-client crate, the winit GUI frontend

  

Area/client-core

felis-client-core crate, shadow screen, config, connect_or_spawn_daemon

  

Area/daemon

felis-daemon crate, session pool, IPC server

  

Area/deps

Dependency bumps

  

Area/docs

Documentation tree when no narrower area fits

  

Area/grid

felis-grid crate, cells, scrollback, image store

  

Area/manual

User-facing docs: tutorials, how-to, user-facing reference pages

  

Area/nix

Nix flake, home-manager module, package definitions

  

Area/protocol

felis-protocol crate, felis.proto, frame layout, version constants

  

Area/pty

felis-pty crate, PTY backends

  

Area/render

felis-render-wgpu crate, GPU pipeline, atlas

  

Area/shaping

felis-shaping crate, swash shaper, font fallback

  

Area/skills

Agent skills (skills/felis, .agents/skills/)

  

Area/transport

felis-transport crate, framing, socket/pipe, SSH carrier

  

Area/vt

felis-vt crate, VT parser, dispatch

  

Compat/Breaking

Breaking change that won't be backward compatible

  

Kind/Bug

Something is not working

  

Kind/Documentation

Documentation changes

  

Kind/Enhancement

Improve existing functionality

  

Kind/Feature

New functionality

  

Kind/Performance

Throughput, latency, or memory cost

  

Kind/Security

This is security issue

  

Kind/Testing

Issue or pull request related to testing

  

perf-regression-accepted

Passes the instruction-count bench gate for an intended cost; state why in a PR comment

  

Reviewed

Confirmed

Issue has been confirmed

  

Reviewed

Duplicate

This issue or pull request already exists

  

Reviewed

Invalid

Invalid issue

  

Reviewed

Won't Fix

This issue won't be fixed

  

Status

Blocked

Something is blocking this issue or pull request

  

Status

Need More Info

Feedback is required to reproduce issue or to continue work

  

Status

Upstream

Waiting on a change in an upstream project

No labels

Area/ci

Area/cli

Area/client

Area/client-core

Area/daemon

Area/deps

Area/docs

Area/grid

Area/manual

Area/nix

Area/protocol

Area/pty

Area/render

Area/shaping

Area/skills

Area/transport

Area/vt

Compat/Breaking

Kind/Bug

Kind/Documentation

Kind/Enhancement

Kind/Feature

Kind/Performance

Kind/Security

Kind/Testing

perf-regression-accepted

Reviewed

Confirmed

Reviewed

Duplicate

Reviewed

Invalid

Reviewed

Won't Fix

Status

Blocked

Status

Need More Info

Status

Upstream

Milestone

Clear milestone

No items

No milestone

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

felis-terminal/felis!101

No description provided.