Fit placeholder images with their aspect ratio #94

Merged

natsukium merged 1 commit from fix/placeholder-aspect into main 2026-10-12 00:11:33 +09:00

Conversation 0 Commits 1 Files changed 4 +154 -24

natsukium commented 2026-10-10 13:50:38 +09:00

Owner

Copy link

An image shown through Unicode-placeholder cells was stretched to fill the placement's c= by r= box: each cell got an equal slice of the image. kitty's grman_put_cell_image fits the image into the box with its aspect ratio kept, centers it, and gives each cell its share of that fitted rectangle, so margin cells show nothing.

• placeholder_tile_quad cuts each quad from the fitted rectangle in pixel space; both cell edges come from the cell index, so neighbors share one boundary.
• A property checks that a box's tiles stay inside their cells, cover exactly the fitted image, and sample it at one uniform scale.

Reproduced side by side with kitty: a 200×100 image in a 10×10 box now draws at 2:1, centered, as kitty draws it.

Closes #83

An image shown through Unicode-placeholder cells was stretched to fill the placement's `c=` by `r=` box: each cell got an equal slice of the image. kitty's `grman_put_cell_image` fits the image into the box with its aspect ratio kept, centers it, and gives each cell its share of that fitted rectangle, so margin cells show nothing. - `placeholder_tile_quad` cuts each quad from the fitted rectangle in pixel space; both cell edges come from the cell index, so neighbors share one boundary. - A property checks that a box's tiles stay inside their cells, cover exactly the fitted image, and sample it at one uniform scale. Reproduced side by side with kitty: a 200×100 image in a 10×10 box now draws at 2:1, centered, as kitty draws it. Closes #83

natsukium added 1 commit 2026-10-10 13:50:38 +09:00

render: fit placeholder images with their aspect ratio ... c5d9c97455

placeholder_tile_quad cut the image into c x r equal slices and
stretched each slice onto its cell, so an image whose shape differed
from the placement's cell box came out distorted. kitty's
grman_put_cell_image scales the image uniformly to fit the whole box,
centers it, and gives each cell its share of that fitted rectangle,
which leaves margin cells empty; the spec describes the same fit.

Each quad is now cut from the fitted rectangle in pixel space, with both
cell edges derived from the cell index so adjacent tiles share one
float boundary.

Closes #83

Assisted-by: Claude Code

natsukium force-pushed fix/placeholder-aspect from c5d9c97455 to 9f90d3eac2 2026-10-11 00:42:51 +09:00 Compare

natsukium force-pushed fix/placeholder-aspect from 9f90d3eac2 to a76b077d43 2026-10-11 01:41:58 +09:00 Compare

natsukium force-pushed fix/placeholder-aspect from a76b077d43 to 563d1c73e2 2026-10-11 23:26:34 +09:00 Compare

natsukium merged commit c300160da4 into main 2026-10-12 00:11:33 +09:00

natsukium deleted branch fix/placeholder-aspect 2026-10-12 00:11:34 +09:00

natsukium referenced this pull request from a commit 2026-10-12 00:11:34 +09:00

Merge pull request 'Fit placeholder images with their aspect ratio' (#94) from fix/placeholder-aspect into main

natsukium referenced this pull request 2026-10-12 00:43:25 +09:00

Read Kitty file ranges and placeholder runs as kitty does #101

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

Area/ci

CI workflows (.forgejo/workflows/)

  

Area/cli

felis-cli crate, the felis front-door binary

  

Area/client

felis-client crate, the winit GUI frontend

  

Area/client-core

felis-client-core crate, shadow screen, config, connect_or_spawn_daemon

  

Area/daemon

felis-daemon crate, session pool, IPC server

  

Area/deps

Dependency bumps

  

Area/docs

Documentation tree when no narrower area fits

  

Area/grid

felis-grid crate, cells, scrollback, image store

  

Area/manual

User-facing docs: tutorials, how-to, user-facing reference pages

  

Area/nix

Nix flake, home-manager module, package definitions

  

Area/protocol

felis-protocol crate, felis.proto, frame layout, version constants

  

Area/pty

felis-pty crate, PTY backends

  

Area/render

felis-render-wgpu crate, GPU pipeline, atlas

  

Area/shaping

felis-shaping crate, swash shaper, font fallback

  

Area/skills

Agent skills (skills/felis, .agents/skills/)

  

Area/transport

felis-transport crate, framing, socket/pipe, SSH carrier

  

Area/vt

felis-vt crate, VT parser, dispatch

  

Compat/Breaking

Breaking change that won't be backward compatible

  

Kind/Bug

Something is not working

  

Kind/Documentation

Documentation changes

  

Kind/Enhancement

Improve existing functionality

  

Kind/Feature

New functionality

  

Kind/Performance

Throughput, latency, or memory cost

  

Kind/Security

This is security issue

  

Kind/Testing

Issue or pull request related to testing

  

perf-regression-accepted

Passes the instruction-count bench gate for an intended cost; state why in a PR comment

  

Reviewed

Confirmed

Issue has been confirmed

  

Reviewed

Duplicate

This issue or pull request already exists

  

Reviewed

Invalid

Invalid issue

  

Reviewed

Won't Fix

This issue won't be fixed

  

Status

Blocked

Something is blocking this issue or pull request

  

Status

Need More Info

Feedback is required to reproduce issue or to continue work

  

Status

Upstream

Waiting on a change in an upstream project

No labels

Area/ci

Area/cli

Area/client

Area/client-core

Area/daemon

Area/deps

Area/docs

Area/grid

Area/manual

Area/nix

Area/protocol

Area/pty

Area/render

Area/shaping

Area/skills

Area/transport

Area/vt

Compat/Breaking

Kind/Bug

Kind/Documentation

Kind/Enhancement

Kind/Feature

Kind/Performance

Kind/Security

Kind/Testing

perf-regression-accepted

Reviewed

Confirmed

Reviewed

Duplicate

Reviewed

Invalid

Reviewed

Won't Fix

Status

Blocked

Status

Need More Info

Status

Upstream

Milestone

Clear milestone

No items

No milestone

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

felis-terminal/felis!94

No description provided.