render: start felis-render-core with the renderer-neutral types #171

Merged

natsukium merged 2 commits from render/core-crate into main 2026-10-18 19:46:57 +09:00

Conversation 0 Commits 2 Files changed 29 +252 -163

natsukium commented 2026-10-18 18:44:18 +09:00

Owner

Copy link

Second of four PRs extracting the wgpu-free half of felis-render-wgpu into a new felis-render-core crate. Pure moves, no behavior change; the #170 golden fixtures pass untouched.

• New crate felis-render-core (deps: protocol, grid, shaping): palette, box_drawing, atlas (+ proptest_atlas) moved by git mv; SelectionRange, ImageData, ImageSource at its root; the overlay structs in overlay. Callers in felis-render-wgpu and felis-client import from core directly, no re-export shims.
• deny.toml: wgpu allowed only under felis-render-wgpu, winit only under felis-client (wrappers). Core can't take felis-render-wgpu as a normal dependency without a cycle, so this keeps core's production graph off both. Chosen over a cargo tree test because such a test reaches above its crate root and would ship in the package once crates are published. Verified: passes on the graph; fails on a direct and on a cfg(windows) violation.
• Docs: workspace.md crate map, diagram, extraction sets, reuse paths, enforcement sentence; overview.md crate-boundary record; CONTRIBUTING scope row; bench/fuzz path filters.

Next: phase 3 moves GlyphIndex (shape memo, rasterization, shelf atlas) into core; phase 4 moves the cell painter behind a per-row display list.

Verified: just check green locally (one known-flaky crossterm_test.py race, passed on rerun); sol review PASS, its one non-blocking finding fixed in the last commit.

Second of four PRs extracting the wgpu-free half of `felis-render-wgpu` into a new `felis-render-core` crate. Pure moves, no behavior change; the #170 golden fixtures pass untouched. - New crate `felis-render-core` (deps: protocol, grid, shaping): `palette`, `box_drawing`, `atlas` (+ `proptest_atlas`) moved by `git mv`; `SelectionRange`, `ImageData`, `ImageSource` at its root; the overlay structs in `overlay`. Callers in `felis-render-wgpu` and `felis-client` import from core directly, no re-export shims. - `deny.toml`: `wgpu` allowed only under `felis-render-wgpu`, `winit` only under `felis-client` (`wrappers`). Core can't take `felis-render-wgpu` as a normal dependency without a cycle, so this keeps core's production graph off both. Chosen over a `cargo tree` test because such a test reaches above its crate root and would ship in the package once crates are published. Verified: passes on the graph; fails on a direct and on a `cfg(windows)` violation. - Docs: workspace.md crate map, diagram, extraction sets, reuse paths, enforcement sentence; overview.md crate-boundary record; CONTRIBUTING scope row; bench/fuzz path filters. Next: phase 3 moves `GlyphIndex` (shape memo, rasterization, shelf atlas) into core; phase 4 moves the cell painter behind a per-row display list. Verified: `just check` green locally (one known-flaky `crossterm_test.py` race, passed on rerun); sol review PASS, its one non-blocking finding fixed in the last commit.

natsukium added 3 commits 2026-10-18 18:44:18 +09:00

render, docs, skills: pin the cell instance bytes and paint cost ... a06fc10600

The renderer-neutral half of felis-render-wgpu (painter, glyph index,
palette) is about to move into its own crate, and glyph sources will
switch from normalized uv to atlas pixels. Neither change may alter
what reaches the GPU, and the painter's unit tests assert fields
against a mock atlas, so they cannot show that.

RowCache::paint_frame is now the one path from a screen and its frame
state to the uploaded instances; the renderer and a byte-level golden
test both go through it, the test over a real GlyphIndex at the
production atlas sides. The paint_frame bench records the full,
one-row and cursor-move costs the move is measured against.

Assisted-by: Claude Code

render, client, docs, skills, ci: start felis-render-core with the renderer-neutral types ... 9b1b1ffda2

Half of felis-render-wgpu never names a wgpu type, yet a client that does
not use wgpu has to re-derive it, and the browser client's hand port of the
box-drawing rasterizer already lags the native one. A crate without wgpu
or winit is the seam a CPU backend and other clients can reuse instead.
The palette, box drawing, shelf atlas, selection, overlay and image-source
types move first, unchanged; the pinned instance bytes stay identical.

The no-wgpu/no-winit rule is a deny.toml wrappers entry rather than a
cargo-tree test inside the crate: such a test reaches above its own crate
root and would ship in the package once the crate is published.

Assisted-by: Claude Code

docs: describe what felis-render-core holds today ... 203dbea197

The crate-boundary record claimed the core already spares a CPU
backend from re-deriving how a cell looks, but the cell painter is
still in felis-render-wgpu; name the pieces the core holds instead.

Assisted-by: Claude Code

natsukium referenced this pull request 2026-10-18 19:00:56 +09:00

render: move the glyph index into felis-render-core #172

natsukium referenced this pull request 2026-10-18 19:27:59 +09:00

render: move the cell painter into felis-render-core behind a display list #173

natsukium merged commit ff32a7ac9c into main 2026-10-18 19:46:57 +09:00

natsukium deleted branch render/core-crate 2026-10-18 19:46:57 +09:00

natsukium referenced this pull request from a commit 2026-10-18 19:46:58 +09:00

Merge pull request 'render: start felis-render-core with the renderer-neutral types' (#171) from render/core-crate into main

natsukium referenced this pull request 2026-10-18 20:28:40 +09:00

release: publish the library crates to crates.io with versions decoupled from the app #160

natsukium referenced this pull request 2026-10-18 21:13:39 +09:00

ci: enforce the crate map with cargo-deny and a closure-ban script #174

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

Area/ci

CI workflows (.forgejo/workflows/)

  

Area/cli

felis-cli crate, the felis front-door binary

  

Area/client

felis-client crate, the winit GUI frontend

  

Area/client-core

felis-client-core crate, shadow screen, config, connect_or_spawn_daemon

  

Area/daemon

felis-daemon crate, session pool, IPC server

  

Area/deps

Dependency bumps

  

Area/docs

Documentation tree when no narrower area fits

  

Area/grid

felis-grid crate, cells, scrollback, image store

  

Area/manual

User-facing docs: tutorials, how-to, user-facing reference pages

  

Area/nix

Nix flake, home-manager module, package definitions

  

Area/protocol

felis-protocol crate, felis.proto, frame layout, version constants

  

Area/pty

felis-pty crate, PTY backends

  

Area/render

felis-render-wgpu crate, GPU pipeline, atlas

  

Area/shaping

felis-shaping crate, swash shaper, font fallback

  

Area/skills

Agent skills (skills/felis, .agents/skills/)

  

Area/transport

felis-transport crate, framing, socket/pipe, SSH carrier

  

Area/vt

felis-vt crate, VT parser, dispatch

  

Compat/Breaking

Breaking change that won't be backward compatible

  

Kind/Bug

Something is not working

  

Kind/Documentation

Documentation changes

  

Kind/Enhancement

Improve existing functionality

  

Kind/Feature

New functionality

  

Kind/Performance

Throughput, latency, or memory cost

  

Kind/Security

This is security issue

  

Kind/Testing

Issue or pull request related to testing

  

perf-regression-accepted

Passes the instruction-count bench gate for an intended cost; state why in a PR comment

  

Reviewed

Confirmed

Issue has been confirmed

  

Reviewed

Duplicate

This issue or pull request already exists

  

Reviewed

Invalid

Invalid issue

  

Reviewed

Won't Fix

This issue won't be fixed

  

Status

Blocked

Something is blocking this issue or pull request

  

Status

Need More Info

Feedback is required to reproduce issue or to continue work

  

Status

Upstream

Waiting on a change in an upstream project

No labels

Area/ci

Area/cli

Area/client

Area/client-core

Area/daemon

Area/deps

Area/docs

Area/grid

Area/manual

Area/nix

Area/protocol

Area/pty

Area/render

Area/shaping

Area/skills

Area/transport

Area/vt

Compat/Breaking

Kind/Bug

Kind/Documentation

Kind/Enhancement

Kind/Feature

Kind/Performance

Kind/Security

Kind/Testing

perf-regression-accepted

Reviewed

Confirmed

Reviewed

Duplicate

Reviewed

Invalid

Reviewed

Won't Fix

Status

Blocked

Status

Need More Info

Status

Upstream

Milestone

Clear milestone

No items

No milestone

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

felis-terminal/felis!171

No description provided.