render: move the glyph index into felis-render-core #172

Merged

natsukium merged 1 commit from render/core-glyph-index into main 2026-10-18 20:08:08 +09:00

Conversation 0 Commits 1 Files changed 18 +616 -565

natsukium commented 2026-10-18 19:00:56 +09:00

Owner

Copy link

Depends on #171 (its two commits come first here; review the last one).

Third of four PRs extracting the wgpu-free half of felis-render-wgpu into felis-render-core. No behavior change; the #170 golden fixtures pass untouched.

• GlyphIndex (shape memo, rasterization, slot table, shelf atlas, recycle), GridWalker, ShapeFrame, GlyphSlot, AtlasView and the helpers they call (sizing_key_from, font_style_of, cluster_block_cols, GLYPH_ATLAS_SIDE) move to core; glyphs.rs follows as an 86% rename. A CPU backend keeps glyphs in a RAM atlas and drains the same PendingUploads the wgpu backend uploads, so the whole index belongs in core.
• GlyphCache (textures, bind group, upload path) stays in wgpu as glyph_cache.rs, wrapping core's index.
• GlyphSlot keeps normalized uv for now: the painter still writes slot coordinates straight into FgInstance; the switch to atlas pixels lands with the encoder in phase 4.
• Cross-crate API made pub (overlay-cluster priming, GridWalker::walk, cluster_base_char, cluster_block_cols); ShapeFrame test constructors behind a core testing feature.
• atlas and shape_memo benches move to core; unchanged within noise.

Verified: just check green locally; sol review PASS.

Depends on #171 (its two commits come first here; review the last one). Third of four PRs extracting the wgpu-free half of `felis-render-wgpu` into `felis-render-core`. No behavior change; the #170 golden fixtures pass untouched. - `GlyphIndex` (shape memo, rasterization, slot table, shelf atlas, recycle), `GridWalker`, `ShapeFrame`, `GlyphSlot`, `AtlasView` and the helpers they call (`sizing_key_from`, `font_style_of`, `cluster_block_cols`, `GLYPH_ATLAS_SIDE`) move to core; `glyphs.rs` follows as an 86% rename. A CPU backend keeps glyphs in a RAM atlas and drains the same `PendingUpload`s the wgpu backend uploads, so the whole index belongs in core. - `GlyphCache` (textures, bind group, upload path) stays in wgpu as `glyph_cache.rs`, wrapping core's index. - `GlyphSlot` keeps normalized uv for now: the painter still writes slot coordinates straight into `FgInstance`; the switch to atlas pixels lands with the encoder in phase 4. - Cross-crate API made `pub` (overlay-cluster priming, `GridWalker::walk`, `cluster_base_char`, `cluster_block_cols`); `ShapeFrame` test constructors behind a core `testing` feature. - `atlas` and `shape_memo` benches move to core; unchanged within noise. Verified: `just check` green locally; sol review PASS.

natsukium added 3 commits 2026-10-18 19:00:56 +09:00

render, client, docs, skills, ci: start felis-render-core with the renderer-neutral types ... 9b1b1ffda2

Half of felis-render-wgpu never names a wgpu type, yet a client that does
not use wgpu has to re-derive it, and the browser client's hand port of the
box-drawing rasterizer already lags the native one. A crate without wgpu
or winit is the seam a CPU backend and other clients can reuse instead.
The palette, box drawing, shelf atlas, selection, overlay and image-source
types move first, unchanged; the pinned instance bytes stay identical.

The no-wgpu/no-winit rule is a deny.toml wrappers entry rather than a
cargo-tree test inside the crate: such a test reaches above its own crate
root and would ship in the package once the crate is published.

Assisted-by: Claude Code

docs: describe what felis-render-core holds today ... 203dbea197

The crate-boundary record claimed the core already spares a CPU
backend from re-deriving how a cell looks, but the cell painter is
still in felis-render-wgpu; name the pieces the core holds instead.

Assisted-by: Claude Code

render, shaping, docs: move the glyph index into felis-render-core ... 6a1a169253

A backend without wgpu still needs the whole glyph index: shaping memo,
rasterization, slot table, shelf packing and recycling. A CPU backend
keeps its glyphs in an atlas image in RAM and drains the same pending
uploads into it that the wgpu backend writes into a texture, so the index
moves to the core whole and the only per-backend part is that drain loop.
GlyphCache stays in felis-render-wgpu as the texture and bind-group
wrapper around it; the module takes a new name so the moved file keeps
its history.

Glyph slots keep normalized uv for now: the painter still writes slot
coordinates straight into the fg instances, so switching to atlas pixels
waits for an encoder that divides by the atlas side.

Assisted-by: Claude Code

natsukium referenced this pull request 2026-10-18 19:27:59 +09:00

render: move the cell painter into felis-render-core behind a display list #173

natsukium force-pushed render/core-glyph-index from 6a1a169253 to 8f16927b85 2026-10-18 19:49:15 +09:00 Compare

natsukium merged commit 222424aece into main 2026-10-18 20:08:08 +09:00

natsukium deleted branch render/core-glyph-index 2026-10-18 20:08:08 +09:00

natsukium referenced this pull request from a commit 2026-10-18 20:08:08 +09:00

Merge pull request 'render: move the glyph index into felis-render-core' (#172) from render/core-glyph-index into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

Area/ci

CI workflows (.forgejo/workflows/)

  

Area/cli

felis-cli crate, the felis front-door binary

  

Area/client

felis-client crate, the winit GUI frontend

  

Area/client-core

felis-client-core crate, shadow screen, config, connect_or_spawn_daemon

  

Area/daemon

felis-daemon crate, session pool, IPC server

  

Area/deps

Dependency bumps

  

Area/docs

Documentation tree when no narrower area fits

  

Area/grid

felis-grid crate, cells, scrollback, image store

  

Area/manual

User-facing docs: tutorials, how-to, user-facing reference pages

  

Area/nix

Nix flake, home-manager module, package definitions

  

Area/protocol

felis-protocol crate, felis.proto, frame layout, version constants

  

Area/pty

felis-pty crate, PTY backends

  

Area/render

felis-render-wgpu crate, GPU pipeline, atlas

  

Area/shaping

felis-shaping crate, swash shaper, font fallback

  

Area/skills

Agent skills (skills/felis, .agents/skills/)

  

Area/transport

felis-transport crate, framing, socket/pipe, SSH carrier

  

Area/vt

felis-vt crate, VT parser, dispatch

  

Compat/Breaking

Breaking change that won't be backward compatible

  

Kind/Bug

Something is not working

  

Kind/Documentation

Documentation changes

  

Kind/Enhancement

Improve existing functionality

  

Kind/Feature

New functionality

  

Kind/Performance

Throughput, latency, or memory cost

  

Kind/Security

This is security issue

  

Kind/Testing

Issue or pull request related to testing

  

perf-regression-accepted

Passes the instruction-count bench gate for an intended cost; state why in a PR comment

  

Reviewed

Confirmed

Issue has been confirmed

  

Reviewed

Duplicate

This issue or pull request already exists

  

Reviewed

Invalid

Invalid issue

  

Reviewed

Won't Fix

This issue won't be fixed

  

Status

Blocked

Something is blocking this issue or pull request

  

Status

Need More Info

Feedback is required to reproduce issue or to continue work

  

Status

Upstream

Waiting on a change in an upstream project

No labels

Area/ci

Area/cli

Area/client

Area/client-core

Area/daemon

Area/deps

Area/docs

Area/grid

Area/manual

Area/nix

Area/protocol

Area/pty

Area/render

Area/shaping

Area/skills

Area/transport

Area/vt

Compat/Breaking

Kind/Bug

Kind/Documentation

Kind/Enhancement

Kind/Feature

Kind/Performance

Kind/Security

Kind/Testing

perf-regression-accepted

Reviewed

Confirmed

Reviewed

Duplicate

Reviewed

Invalid

Reviewed

Won't Fix

Status

Blocked

Status

Need More Info

Status

Upstream

Milestone

Clear milestone

No items

No milestone

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

felis-terminal/felis!172

No description provided.