graphics: a partial x/y/w/h source rectangle is ignored #43

New issue

Closed

opened 2026-10-07 09:34:27 +09:00 by natsukium · 0 comments

natsukium commented

2026-10-07 09:34:27 +09:00

Owner

felis applies a placement's source rectangle (x, y, w, h) only when all four keys are given (source_rect in crates/felis-daemon/src/graphics.rs). Otherwise the whole image is drawn. A producer that sends, say, only x=40 to skip the left 40 px of a 100 px wide image gets the full image.

kitty: handle_put_command (kitty/graphics.c) defaults each key on its own: x/y default to 0, and an absent or zero w/h means the image size. The resulting width and height are then clipped to what remains of the image past x/y. In the example above kitty draws the right 60 px.

Repro: transmit a 100×50 image and place it with a=p,i=1,x=40. kitty shows the right 60 px; felis shows all 100 px.

Decide: whether to follow kitty's per-key defaults. It changes the SourceRect the daemon stores and sends, and with it the natural extent and the cursor move, which already resolve from the clipped rectangle (felis_grid::images::clip_source).

felis applies a placement's source rectangle (`x`, `y`, `w`, `h`) only when all four keys are given (`source_rect` in `crates/felis-daemon/src/graphics.rs`). Otherwise the whole image is drawn. A producer that sends, say, only `x=40` to skip the left 40 px of a 100 px wide image gets the full image. **kitty:** `handle_put_command` (`kitty/graphics.c`) defaults each key on its own: `x`/`y` default to 0, and an absent or zero `w`/`h` means the image size. The resulting width and height are then clipped to what remains of the image past `x`/`y`. In the example above kitty draws the right 60 px. **Repro:** transmit a 100×50 image and place it with `a=p,i=1,x=40`. kitty shows the right 60 px; felis shows all 100 px. **Decide:** whether to follow kitty's per-key defaults. It changes the `SourceRect` the daemon stores and sends, and with it the natural extent and the cursor move, which already resolve from the clipped rectangle (`felis_grid::images::clip_source`).

natsukium referenced this issue

2026-10-07 09:34:33 +09:00

Keep a natural-size Kitty image at its pixel size when the cell size changes #41

natsukium added the

Area/daemon

Area/grid

Kind/Bug

labels

2026-10-12 15:18:46 +09:00

natsukium referenced this issue from a pull request that will close it,

2026-10-12 16:36:00 +09:00

Default each Kitty source-rectangle key on its own #123