Default each Kitty source-rectangle key on its own #123

Merged

natsukium merged 1 commit from fix/partial-source into main

2026-10-12 18:06:39 +09:00

natsukium commented

2026-10-12 16:36:00 +09:00

Owner

A placement's x/y/w/h took effect only when all four were given. kitty's handle_put_command defaults each key on its own (x/y to 0, an absent or zero w/h to the image size) and clips to the image; the daemon now resolves the rectangle the same way, so a=p,i=1,x=40 on a 100 px image draws the right 60 px.

Closes #43

A placement's `x`/`y`/`w`/`h` took effect only when all four were given. kitty's `handle_put_command` defaults each key on its own (`x`/`y` to 0, an absent or zero `w`/`h` to the image size) and clips to the image; the daemon now resolves the rectangle the same way, so `a=p,i=1,x=40` on a 100 px image draws the right 60 px. Closes #43

natsukium added 1 commit

2026-10-12 16:36:00 +09:00

daemon: default each Kitty source-rectangle key on its own

darwin / detect relevant changes (pull_request) Successful in 8s

Details

darwin / darwin docs-only no-op (pull_request) Has been skipped

Details

darwin / build felis (aarch64-darwin) (pull_request) Successful in 1m9s

Details

windows / detect relevant changes (pull_request) Successful in 20s

Details

windows / windows docs-only no-op (pull_request) Has been skipped

Details

windows / cargo nextest (Windows) (pull_request) Successful in 6m13s

Details

windows / frontend smoke (Windows) (pull_request) Successful in 1m14s

Details

bench / instruction-count regression gate (pull_request) Successful in 44s

Details

pr / nix flake check (pull_request) Successful in 38s

Details

pr / cargo build / clippy / test / deny (pull_request) Successful in 2m22s

Details

pr / wire schema is compatible with the base (pull_request) Successful in 2s

Details

pr / frontend smoke (x86_64-linux) (pull_request) Successful in 29s

Details

windows / cargo clippy (Windows cross) (pull_request) Successful in 15s

Details

d79c95f5a9

A placement's x/y/w/h took effect only when all four were given, so a
producer that sent x=40 alone to skip the left of an image got the
whole image. kitty's handle_put_command defaults each key separately:
x and y to 0, an absent or zero w or h to the image's size, and then
clips to what is left past x and y. The daemon now resolves the
rectangle the same way against the image it places, so the stored and
announced rectangle, the natural extent and the cursor move all follow
from the cropped region; clip_source already did the clipping.

Closes #43

Assisted-by: Claude Code

natsukium scheduled this pull request to auto merge when all checks succeed

2026-10-12 16:45:14 +09:00

natsukium merged commit b677f12132 into main

2026-10-12 18:06:39 +09:00

natsukium deleted branch fix/partial-source

2026-10-12 18:06:39 +09:00

natsukium referenced this pull request from a commit

2026-10-12 18:06:40 +09:00

Merge pull request 'Default each Kitty source-rectangle key on its own' (#123) from fix/partial-source into main