Cap each screen's Kitty placement table #113

Merged

natsukium merged 1 commit from fix/placement-cap into main 2026-10-12 16:22:03 +09:00

Conversation 0 Commits 1 Files changed 13 +888 -116

natsukium commented 2026-10-12 15:09:47 +09:00

Owner

Copy link

Closes #88.

A placement costs no pixel bytes, so the image store's byte cap never bounded the placement table: repeated puts grew the daemon and every attached client's mirror for the life of the session. Each screen now keeps at most 16384 placements, direct and Unicode-placeholder together; a put past that evicts the oldest, announced like a delete, and an id-less image left without placements is deleted with it.

The table is now keyed by (image_id, placement_id) with a per-image index and a shared sequence number, so a flood at the cap stays sublinear on the daemon. The sequence numbers survive an in-place upgrade dump, so restore evicts the same placement.

Closes #88. A placement costs no pixel bytes, so the image store's byte cap never bounded the placement table: repeated puts grew the daemon and every attached client's mirror for the life of the session. Each screen now keeps at most 16384 placements, direct and Unicode-placeholder together; a put past that evicts the oldest, announced like a delete, and an id-less image left without placements is deleted with it. The table is now keyed by `(image_id, placement_id)` with a per-image index and a shared sequence number, so a flood at the cap stays sublinear on the daemon. The sequence numbers survive an in-place upgrade dump, so restore evicts the same placement.

natsukium added 1 commit 2026-10-12 15:09:47 +09:00

grid, daemon: cap each screen's Kitty placement table ... d7010b45a8

A placement costs no pixel bytes, so the image store's byte cap never
bounded the placement table: repeating `a=p,i=1` with a fresh `p=`, or
with none, added an entry per put to the daemon and to every attached
client's mirror, for as long as the session lived. kitty sets no limit,
but its table dies with the window and nothing mirrors it.

Each screen now keeps at most 16384 placements, direct and placeholder
together, and a put past that evicts the oldest, announced like a
delete; an id-less image left without placements goes with it. Evicting
rather than refusing keeps a long-running program able to show new
images, as the byte cap does.

At that size the table's linear scans (every put's upsert, every
anonymous id's collision check) would make a flood quadratic, so the
table is now keyed by `(image_id, placement_id)` and ordered by a
sequence number both kinds share, which is also what finds the oldest
placement of either kind.

Closes #88.

Assisted-by: Claude Code

natsukium merged commit 251f18947c into main 2026-10-12 16:22:03 +09:00

natsukium referenced this pull request from a commit 2026-10-12 16:22:04 +09:00

Merge pull request 'Cap each screen's Kitty placement table' (#113) from fix/placement-cap into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

Area/ci

CI workflows (.forgejo/workflows/)

  

Area/cli

felis-cli crate, the felis front-door binary

  

Area/client

felis-client crate, the winit GUI frontend

  

Area/client-core

felis-client-core crate, shadow screen, config, connect_or_spawn_daemon

  

Area/daemon

felis-daemon crate, session pool, IPC server

  

Area/deps

Dependency bumps

  

Area/docs

Documentation tree when no narrower area fits

  

Area/grid

felis-grid crate, cells, scrollback, image store

  

Area/manual

User-facing docs: tutorials, how-to, user-facing reference pages

  

Area/nix

Nix flake, home-manager module, package definitions

  

Area/protocol

felis-protocol crate, felis.proto, frame layout, version constants

  

Area/pty

felis-pty crate, PTY backends

  

Area/render

felis-render-wgpu crate, GPU pipeline, atlas

  

Area/shaping

felis-shaping crate, swash shaper, font fallback

  

Area/skills

Agent skills (skills/felis, .agents/skills/)

  

Area/transport

felis-transport crate, framing, socket/pipe, SSH carrier

  

Area/vt

felis-vt crate, VT parser, dispatch

  

Compat/Breaking

Breaking change that won't be backward compatible

  

Kind/Bug

Something is not working

  

Kind/Documentation

Documentation changes

  

Kind/Enhancement

Improve existing functionality

  

Kind/Feature

New functionality

  

Kind/Performance

Throughput, latency, or memory cost

  

Kind/Security

This is security issue

  

Kind/Testing

Issue or pull request related to testing

  

perf-regression-accepted

Passes the instruction-count bench gate for an intended cost; state why in a PR comment

  

Reviewed

Confirmed

Issue has been confirmed

  

Reviewed

Duplicate

This issue or pull request already exists

  

Reviewed

Invalid

Invalid issue

  

Reviewed

Won't Fix

This issue won't be fixed

  

Status

Blocked

Something is blocking this issue or pull request

  

Status

Need More Info

Feedback is required to reproduce issue or to continue work

  

Status

Upstream

Waiting on a change in an upstream project

No labels

Area/ci

Area/cli

Area/client

Area/client-core

Area/daemon

Area/deps

Area/docs

Area/grid

Area/manual

Area/nix

Area/protocol

Area/pty

Area/render

Area/shaping

Area/skills

Area/transport

Area/vt

Compat/Breaking

Kind/Bug

Kind/Documentation

Kind/Enhancement

Kind/Feature

Kind/Performance

Kind/Security

Kind/Testing

perf-regression-accepted

Reviewed

Confirmed

Reviewed

Duplicate

Reviewed

Invalid

Reviewed

Won't Fix

Status

Blocked

Status

Need More Info

Status

Upstream

Milestone

Clear milestone

No items

No milestone

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

felis-terminal/felis!113

No description provided.