daemon, docs: send xterm's legacy bytes for Ctrl+Space, Ctrl+digit and Alt+Shift #163

Merged

natsukium merged 1 commit from daemon/legacy-ctrl-keys into main 2026-10-18 13:44:06 +09:00

Conversation 0 Commits 1 Files changed 3 +199 -17

natsukium commented 2026-10-18 13:14:36 +09:00

Owner

Copy link

The legacy encoder disagreed with xterm and kitty on Ctrl+Space (0x20 instead of 0x00), Ctrl+Backspace (0x7f instead of 0x08), Ctrl+2…8 / Ctrl+/ / Ctrl+? (text instead of C0 bytes) and Alt+Shift+letter (lowercased after ESC). This sends xterm's bytes for those keys.

• The digit, / and ? rows go in a separate legacy table, so modifyOtherKeys level 1 still escapes Ctrl+digit as before.
• Keys that the Kitty or modifyOtherKeys modes leave unescaped fall through to the legacy encoder and get the corrected bytes there too, as in kitty.
• key-encoding.md now lists the legacy Ctrl/Alt mapping. Its Kitty bit-1 and level-1 sentences now say which keys each mode escapes; the old wording did not match the code for Ctrl+C under bit 1.

Closes #157

The legacy encoder disagreed with xterm and kitty on Ctrl+Space (`0x20` instead of `0x00`), Ctrl+Backspace (`0x7f` instead of `0x08`), Ctrl+2…8 / Ctrl+/ / Ctrl+? (text instead of C0 bytes) and Alt+Shift+letter (lowercased after `ESC`). This sends xterm's bytes for those keys. - The digit, `/` and `?` rows go in a separate legacy table, so modifyOtherKeys level 1 still escapes Ctrl+digit as before. - Keys that the Kitty or modifyOtherKeys modes leave unescaped fall through to the legacy encoder and get the corrected bytes there too, as in kitty. - `key-encoding.md` now lists the legacy Ctrl/Alt mapping. Its Kitty bit-1 and level-1 sentences now say which keys each mode escapes; the old wording did not match the code for Ctrl+C under bit 1. Closes #157

natsukium added 1 commit 2026-10-18 13:14:36 +09:00

daemon, docs: send xterm's legacy bytes for Ctrl+Space, Ctrl+digit and Alt+Shift ... 7d674a9644

The legacy encoder is the GUI's default path, and it disagreed with xterm
and kitty on keys that editors and shells bind: Emacs C-SPC received a
plain space, readline could not tell M-B from M-b, and a shell's
Ctrl+Backspace word delete got DEL. Ctrl on Space and Backspace was lost
because the named-key branch returned the bare byte first, the Alt prefix
reused the Kitty keycode helper whose lowercasing the Kitty spec requires
but xterm does not, and the Ctrl table lacked Xlib's digit, `/` and `?`
rows.

The digit rows live in a separate legacy table rather than in ctrl_byte:
modifyOtherKeys level 1 reads ctrl_byte as its "leave alone" set, and its
escaped output for Ctrl+digit is meant to stay as it is. Keys that the
Kitty or modifyOtherKeys modes do not escape fall through to the legacy
encoder, so they take the corrected bytes too, as they do in kitty.

The key-encoding reference now lists the legacy Ctrl and Alt mapping, and
its Kitty bit-1 and level-1 sentences state which keys each mode escapes
instead of resting on "has a legacy byte", which the new table makes
untrue for Ctrl+digit and which never matched bit 1's escaping of Ctrl+C.

Assisted-by: Claude Code

natsukium force-pushed daemon/legacy-ctrl-keys from 7d674a9644 to f96dc9cff4 2026-10-18 13:18:28 +09:00 Compare

natsukium scheduled this pull request to auto merge when all checks succeed 2026-10-18 13:20:09 +09:00

natsukium merged commit dd9c18e304 into main 2026-10-18 13:44:06 +09:00

natsukium deleted branch daemon/legacy-ctrl-keys 2026-10-18 13:44:06 +09:00

natsukium referenced this pull request from a commit 2026-10-18 13:44:07 +09:00

Merge pull request 'daemon, docs: send xterm's legacy bytes for Ctrl+Space, Ctrl+digit and Alt+Shift' (#163) from daemon/legacy-ctrl-keys into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

Area/ci

CI workflows (.forgejo/workflows/)

  

Area/cli

felis-cli crate, the felis front-door binary

  

Area/client

felis-client crate, the winit GUI frontend

  

Area/client-core

felis-client-core crate, shadow screen, config, connect_or_spawn_daemon

  

Area/daemon

felis-daemon crate, session pool, IPC server

  

Area/deps

Dependency bumps

  

Area/docs

Documentation tree when no narrower area fits

  

Area/grid

felis-grid crate, cells, scrollback, image store

  

Area/manual

User-facing docs: tutorials, how-to, user-facing reference pages

  

Area/nix

Nix flake, home-manager module, package definitions

  

Area/protocol

felis-protocol crate, felis.proto, frame layout, version constants

  

Area/pty

felis-pty crate, PTY backends

  

Area/render

felis-render-wgpu crate, GPU pipeline, atlas

  

Area/shaping

felis-shaping crate, swash shaper, font fallback

  

Area/skills

Agent skills (skills/felis, .agents/skills/)

  

Area/transport

felis-transport crate, framing, socket/pipe, SSH carrier

  

Area/vt

felis-vt crate, VT parser, dispatch

  

Compat/Breaking

Breaking change that won't be backward compatible

  

Kind/Bug

Something is not working

  

Kind/Documentation

Documentation changes

  

Kind/Enhancement

Improve existing functionality

  

Kind/Feature

New functionality

  

Kind/Performance

Throughput, latency, or memory cost

  

Kind/Security

This is security issue

  

Kind/Testing

Issue or pull request related to testing

  

perf-regression-accepted

Passes the instruction-count bench gate for an intended cost; state why in a PR comment

  

Reviewed

Confirmed

Issue has been confirmed

  

Reviewed

Duplicate

This issue or pull request already exists

  

Reviewed

Invalid

Invalid issue

  

Reviewed

Won't Fix

This issue won't be fixed

  

Status

Blocked

Something is blocking this issue or pull request

  

Status

Need More Info

Feedback is required to reproduce issue or to continue work

  

Status

Upstream

Waiting on a change in an upstream project

No labels

Area/ci

Area/cli

Area/client

Area/client-core

Area/daemon

Area/deps

Area/docs

Area/grid

Area/manual

Area/nix

Area/protocol

Area/pty

Area/render

Area/shaping

Area/skills

Area/transport

Area/vt

Compat/Breaking

Kind/Bug

Kind/Documentation

Kind/Enhancement

Kind/Feature

Kind/Performance

Kind/Security

Kind/Testing

perf-regression-accepted

Reviewed

Confirmed

Reviewed

Duplicate

Reviewed

Invalid

Reviewed

Won't Fix

Status

Blocked

Status

Need More Info

Status

Upstream

Milestone

Clear milestone

No items

No milestone

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

felis-terminal/felis!163

No description provided.