felis-terminal/felis

Watch

daemon, nix, docs: let an embedder give its sessions the terminfo entry #181

Merged

natsukium merged 1 commit from daemon/embedder-terminfo into main

2026-10-19 01:58:17 +09:00

natsukium commented

2026-10-19 01:37:21 +09:00

Owner

Closes #179

A program serving felis-daemon in-process (adroit) stamps TERM=xterm-felis but could not resolve it: the shipped-terminfo lookup searches beside the embedder's executable, and the entry's source lived outside every crate.

The source moves to crates/felis-daemon/terminfo/felis.terminfo (inside the package, so include_str! survives cargo package) and is exported as felis_daemon::TERMINFO_SOURCE.
DaemonCaps::terminfo_dir: Option<PathBuf> names the directory listed first in each session's TERMINFO_DIRS (Unix only), defaulting to the shipped one; None adds nothing. It reaches the plain create and the bare-launch cwd retry. The daemon never runs tic.
Nix package, dev shell, compile-terminfo.sh, the felis doctor hint, Homebrew PACKAGING (+ self-test case), docs and CHANGELOG repointed.

Follow-up outside this repo

The Homebrew tap formula compiles share/terminfo/felis.terminfo by path and needs the new path at the next release; the bump PR opens as a draft since share/ changed.

Verification

just check (4273 tests), just release-homebrew-test, nix build .#default (ships share/terminfo/x/xterm-felis).
The new integration test fails when the caps field is not threaded and when the cwd retry drops it; the new Homebrew case fails without the PACKAGING entry.

Closes #179 A program serving `felis-daemon` in-process (adroit) stamps `TERM=xterm-felis` but could not resolve it: the shipped-terminfo lookup searches beside the embedder's executable, and the entry's source lived outside every crate. - The source moves to `crates/felis-daemon/terminfo/felis.terminfo` (inside the package, so `include_str!` survives `cargo package`) and is exported as `felis_daemon::TERMINFO_SOURCE`. - `DaemonCaps::terminfo_dir: Option<PathBuf>` names the directory listed first in each session's `TERMINFO_DIRS` (Unix only), defaulting to the shipped one; `None` adds nothing. It reaches the plain create and the bare-launch cwd retry. The daemon never runs `tic`. - Nix package, dev shell, `compile-terminfo.sh`, the `felis doctor` hint, Homebrew `PACKAGING` (+ self-test case), docs and CHANGELOG repointed. ## Follow-up outside this repo The Homebrew tap formula compiles `share/terminfo/felis.terminfo` by path and needs the new path at the next release; the bump PR opens as a draft since `share/` changed. ## Verification - `just check` (4273 tests), `just release-homebrew-test`, `nix build .#default` (ships `share/terminfo/x/xterm-felis`). - The new integration test fails when the caps field is not threaded and when the cwd retry drops it; the new Homebrew case fails without the `PACKAGING` entry.

natsukium added 1 commit

2026-10-19 01:37:21 +09:00

daemon, nix, docs: let an embedder give its sessions the terminfo entry

fuzz / cargo fuzz nightly long-run (pull_request) Has been skipped

Details

darwin / detect relevant changes (pull_request) Successful in 9s

Details

darwin / darwin docs-only no-op (pull_request) Has been skipped

Details

windows / detect relevant changes (pull_request) Successful in 14s

Details

windows / windows docs-only no-op (pull_request) Has been skipped

Details

bench / instruction-count regression gate (pull_request) Successful in 1m4s

Details

darwin / build felis (aarch64-darwin) (pull_request) Successful in 1m12s

Details

fuzz / cargo fuzz smoke (per target) (pull_request) Successful in 1m5s

Details

pr / nix flake check (pull_request) Successful in 36s

Details

windows / cargo nextest (Windows) (pull_request) Successful in 2m59s

Details

windows / frontend smoke (Windows) (pull_request) Successful in 1m4s

Details

pr / cargo build / clippy / test / deny (pull_request) Successful in 2m38s

Details

pr / wire schema is compatible with the base (pull_request) Successful in 2s

Details

pr / frontend smoke (x86_64-linux) (pull_request) Successful in 1m3s

Details

windows / cargo clippy (Windows cross) (pull_request) Successful in 30s

Details

4870c6d793

A program serving felis-daemon in-process stamps TERM=xterm-felis but
cannot resolve it: the shipped-terminfo lookup searches beside the
embedder's executable, and the entry's source sat outside every crate,
so the embedder kept a drifting copy and rewrote each spawn's
TERMINFO_DIRS itself.

The source now lives in the felis-daemon package, where include_str!
survives cargo package, and is exported as TERMINFO_SOURCE.
DaemonCaps::terminfo_dir names the directory to list, defaulting to
the shipped one, so the daemon applies the same TERMINFO_DIRS rules to
whatever the embedder compiled. Compiling stays the embedder's choice.

Closes #179

Assisted-by: Claude Code

natsukium merged commit 0c2e0cb038 into main

2026-10-19 01:58:17 +09:00

natsukium deleted branch daemon/embedder-terminfo

2026-10-19 01:58:17 +09:00

natsukium referenced this pull request from a commit

2026-10-19 01:58:18 +09:00

Merge pull request 'daemon, nix, docs: let an embedder give its sessions the terminfo entry' (#181) from daemon/embedder-terminfo into main