Report the directory a session was spawned in #182

Merged

natsukium merged 1 commit from daemon/spawn-cwd into main 2026-10-19 02:11:59 +09:00

Conversation 0 Commits 1 Files changed 32 +306 -26

natsukium commented 2026-10-19 01:38:32 +09:00

Owner

Copy link

SessionInfo.cwd is the directory a program last announced with OSC 7. A session whose program never sends one, such as a TUI coding agent or a command spawned without a shell, lists no directory even though the daemon chose the one its child started in. A session manager that groups sessions by directory then has to record the path itself. Once that manager restarts, only the daemon still knows the path, and 128-byte tags are too short for long worktree paths.

• SessionInfo.spawn_cwd reports where the child actually started, not SpawnArgs.cwd as sent:
  • An empty cwd reports the daemon's own directory.
  • A bare shell that falls back from an unusable cwd also reports the daemon's own directory.
  • A requested directory is reported as sent, not canonicalized.
• The field is absent when the daemon's cwd is not UTF-8, and for a session carried over from a daemon that never recorded it.
• The field joins the unreleased protocol minor 2 as skippable, so an older peer that skips it only lists no spawn directory. The ipc.md ledger row 2 is updated.
• The field is carried through the in-place upgrade dump. It decodes as None when the key is absent, so DUMP_VERSION stays at 2.
• sessions list / info --format json and the bridge emit spawn_cwd. sessions info prints it as a spawned: line, since info is the per-session view that shows every field.
• Docs: ipc.md, cli.md, the felis skill, and CHANGELOG.

Tests:

• Create acks for a named, empty, and fallback cwd.
• A restore from a dump with the key present and with it removed from the JSON.
• sessions list --format json and sessions info human and JSON output.
• The bridge golden masks spawn_cwd like cwd.

just check passes except for a_daemon_write_failure_fails_and_clears_the_link (a known bridge hang) and an_idle_notification_subscriber_does_not_block_the_upgrade, which timed out under load and passes on its own. golden_daemon_loss and seven felis-render-wgpu paint_frame goldens fail on this machine without this change.

Closes #178

`SessionInfo.cwd` is the directory a program last announced with OSC 7. A session whose program never sends one, such as a TUI coding agent or a command spawned without a shell, lists no directory even though the daemon chose the one its child started in. A session manager that groups sessions by directory then has to record the path itself. Once that manager restarts, only the daemon still knows the path, and 128-byte tags are too short for long worktree paths. - `SessionInfo.spawn_cwd` reports where the child actually started, not `SpawnArgs.cwd` as sent: - An empty `cwd` reports the daemon's own directory. - A bare shell that falls back from an unusable `cwd` also reports the daemon's own directory. - A requested directory is reported as sent, not canonicalized. - The field is absent when the daemon's cwd is not UTF-8, and for a session carried over from a daemon that never recorded it. - The field joins the unreleased protocol minor 2 as `skippable`, so an older peer that skips it only lists no spawn directory. The ipc.md ledger row 2 is updated. - The field is carried through the in-place upgrade dump. It decodes as `None` when the key is absent, so `DUMP_VERSION` stays at 2. - `sessions list` / `info --format json` and the bridge emit `spawn_cwd`. `sessions info` prints it as a `spawned:` line, since info is the per-session view that shows every field. - Docs: `ipc.md`, `cli.md`, the `felis` skill, and CHANGELOG. Tests: - Create acks for a named, empty, and fallback `cwd`. - A restore from a dump with the key present and with it removed from the JSON. - `sessions list --format json` and `sessions info` human and JSON output. - The bridge golden masks `spawn_cwd` like `cwd`. `just check` passes except for `a_daemon_write_failure_fails_and_clears_the_link` (a known bridge hang) and `an_idle_notification_subscriber_does_not_block_the_upgrade`, which timed out under load and passes on its own. `golden_daemon_loss` and seven `felis-render-wgpu` `paint_frame` goldens fail on this machine without this change. Closes #178

natsukium added 1 commit 2026-10-19 01:38:33 +09:00

protocol, daemon, cli, docs, skills: report the directory a session was spawned in ... 09d595ceec

SessionInfo.cwd is the directory a program last announced with OSC 7,
so a session whose program never sends one (a TUI coding agent, a
command spawned without a shell) lists no directory, though the daemon
chose the one its child started in. A session manager that groups its
sessions by directory then has to record the path itself, and once it
restarts the daemon is the only place left that knows it; storing it in
128-byte tags forces long worktree paths to be split across several and
duplicates state the daemon already owns.

SessionInfo.spawn_cwd carries the directory the spawn resolved to, not
SpawnArgs.cwd as sent: an empty cwd and a bare shell's fallback from an
unusable one both start the child in the daemon's own directory, which
is what gets reported. A requested directory is reported as sent rather
than canonicalized, so a caller sees its own spelling back. The value is
fixed at creation, rides the in-place upgrade dump (a default-valued
field, so the dump version stands), and is absent where the daemon does
not know it: a non-UTF-8 daemon cwd, or a session carried over from a
daemon that never recorded it.

The field joins the unreleased protocol minor 2 as skippable: an older
peer that skips it only lists no spawn directory. `sessions info` prints
it as a `spawned:` line as well as in --format json, since info is the
per-session view that shows every field the row carries.

Assisted-by: Claude Code

natsukium force-pushed daemon/spawn-cwd from 09d595ceec to c77ba7c89d 2026-10-19 02:00:47 +09:00 Compare

natsukium scheduled this pull request to auto merge when all checks succeed 2026-10-19 02:03:32 +09:00

natsukium merged commit 1fa8dcdba4 into main 2026-10-19 02:11:59 +09:00

natsukium deleted branch daemon/spawn-cwd 2026-10-19 02:12:00 +09:00

natsukium referenced this pull request from a commit 2026-10-19 02:12:00 +09:00

Merge pull request 'Report the directory a session was spawned in' (#182) from daemon/spawn-cwd into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

Area/ci

CI workflows (.forgejo/workflows/)

  

Area/cli

felis-cli crate, the felis front-door binary

  

Area/client

felis-client crate, the winit GUI frontend

  

Area/client-core

felis-client-core crate, shadow screen, config, connect_or_spawn_daemon

  

Area/daemon

felis-daemon crate, session pool, IPC server

  

Area/deps

Dependency bumps

  

Area/docs

Documentation tree when no narrower area fits

  

Area/grid

felis-grid crate, cells, scrollback, image store

  

Area/manual

User-facing docs: tutorials, how-to, user-facing reference pages

  

Area/nix

Nix flake, home-manager module, package definitions

  

Area/protocol

felis-protocol crate, felis.proto, frame layout, version constants

  

Area/pty

felis-pty crate, PTY backends

  

Area/render

felis-render-wgpu crate, GPU pipeline, atlas

  

Area/shaping

felis-shaping crate, swash shaper, font fallback

  

Area/skills

Agent skills (skills/felis, .agents/skills/)

  

Area/transport

felis-transport crate, framing, socket/pipe, SSH carrier

  

Area/vt

felis-vt crate, VT parser, dispatch

  

Compat/Breaking

Breaking change that won't be backward compatible

  

Kind/Bug

Something is not working

  

Kind/Documentation

Documentation changes

  

Kind/Enhancement

Improve existing functionality

  

Kind/Feature

New functionality

  

Kind/Performance

Throughput, latency, or memory cost

  

Kind/Security

This is security issue

  

Kind/Testing

Issue or pull request related to testing

  

perf-regression-accepted

Passes the instruction-count bench gate for an intended cost; state why in a PR comment

  

Reviewed

Confirmed

Issue has been confirmed

  

Reviewed

Duplicate

This issue or pull request already exists

  

Reviewed

Invalid

Invalid issue

  

Reviewed

Won't Fix

This issue won't be fixed

  

Status

Blocked

Something is blocking this issue or pull request

  

Status

Need More Info

Feedback is required to reproduce issue or to continue work

  

Status

Upstream

Waiting on a change in an upstream project

No labels

Area/ci

Area/cli

Area/client

Area/client-core

Area/daemon

Area/deps

Area/docs

Area/grid

Area/manual

Area/nix

Area/protocol

Area/pty

Area/render

Area/shaping

Area/skills

Area/transport

Area/vt

Compat/Breaking

Kind/Bug

Kind/Documentation

Kind/Enhancement

Kind/Feature

Kind/Performance

Kind/Security

Kind/Testing

perf-regression-accepted

Reviewed

Confirmed

Reviewed

Duplicate

Reviewed

Invalid

Reviewed

Won't Fix

Status

Blocked

Status

Need More Info

Status

Upstream

Milestone

Clear milestone

No items

No milestone

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

felis-terminal/felis!182

No description provided.