shaping, dev: test that the CJK fallback follows the query language #188

Merged

natsukium merged 1 commit from shaping/cjk-lang-fallback-test into main 2026-10-19 12:48:52 +09:00

Conversation 0 Commits 1 Files changed 2 +41 -2

natsukium commented 2026-10-19 12:37:49 +09:00

Owner

Copy link

Closes #96.

Adds a Simplified Chinese subset (--font-number=2, same ideograph) to the pinned test fonts and a fontconfig test: with the query language ja the face that draws 葛 is Noto Sans CJK JP, with zh-cn it is Noto Sans CJK SC. The test first checks that both faces load and cover 葛, so the result comes from ranking rather than a missing face.

The one-ideograph subsets get no lang from fontconfig, so target="scan" rules tag them as full faces would be. Without the rules the zh-cn half fails (zh-cn: Noto Sans CJK JP), which is the install-order regression the test is there to catch.

Not covered: the host path where FcDefaultSubstitute takes the language from the environment.

just check passes.

Closes #96. Adds a Simplified Chinese subset (`--font-number=2`, same ideograph) to the pinned test fonts and a fontconfig test: with the query language `ja` the face that draws 葛 is Noto Sans CJK JP, with `zh-cn` it is Noto Sans CJK SC. The test first checks that both faces load and cover 葛, so the result comes from ranking rather than a missing face. The one-ideograph subsets get no `lang` from fontconfig, so `target="scan"` rules tag them as full faces would be. Without the rules the `zh-cn` half fails (`zh-cn: Noto Sans CJK JP`), which is the install-order regression the test is there to catch. Not covered: the host path where `FcDefaultSubstitute` takes the language from the environment. `just check` passes.

natsukium added 1 commit 2026-10-19 12:37:49 +09:00

shaping, dev: test that the CJK fallback follows the query language ... 9a6be208bd

The Linux cascade relies on fontconfig ranking the Japanese face first
under a Japanese locale, but the pinned font set had only the JP face,
so nothing failed if the cascade stopped following that ranking.

The SC subset joins the JP one, and the test checks that `ja` and
`zh-cn` each put their own face first. One-ideograph subsets cover no
orthography, so fontconfig gives them no language; scan-time rules tag
them as full faces would be, or install order would decide both cases.
The host's environment-derived language is not exercised: changing the
environment from parallel tests is unsafe.

Assisted-by: Claude Code

natsukium scheduled this pull request to auto merge when all checks succeed 2026-10-19 12:41:08 +09:00

natsukium merged commit 4099f6985d into main 2026-10-19 12:48:52 +09:00

natsukium deleted branch shaping/cjk-lang-fallback-test 2026-10-19 12:48:52 +09:00

natsukium referenced this pull request from a commit 2026-10-19 12:48:52 +09:00

Merge pull request 'shaping, dev: test that the CJK fallback follows the query language' (#188) from shaping/cjk-lang-fallback-test into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

Area/ci

CI workflows (.forgejo/workflows/)

  

Area/cli

felis-cli crate, the felis front-door binary

  

Area/client

felis-client crate, the winit GUI frontend

  

Area/client-core

felis-client-core crate, shadow screen, config, connect_or_spawn_daemon

  

Area/daemon

felis-daemon crate, session pool, IPC server

  

Area/deps

Dependency bumps

  

Area/docs

Documentation tree when no narrower area fits

  

Area/grid

felis-grid crate, cells, scrollback, image store

  

Area/manual

User-facing docs: tutorials, how-to, user-facing reference pages

  

Area/nix

Nix flake, home-manager module, package definitions

  

Area/protocol

felis-protocol crate, felis.proto, frame layout, version constants

  

Area/pty

felis-pty crate, PTY backends

  

Area/render

felis-render-wgpu crate, GPU pipeline, atlas

  

Area/shaping

felis-shaping crate, swash shaper, font fallback

  

Area/skills

Agent skills (skills/felis, .agents/skills/)

  

Area/transport

felis-transport crate, framing, socket/pipe, SSH carrier

  

Area/vt

felis-vt crate, VT parser, dispatch

  

Compat/Breaking

Breaking change that won't be backward compatible

  

Kind/Bug

Something is not working

  

Kind/Documentation

Documentation changes

  

Kind/Enhancement

Improve existing functionality

  

Kind/Feature

New functionality

  

Kind/Performance

Throughput, latency, or memory cost

  

Kind/Security

This is security issue

  

Kind/Testing

Issue or pull request related to testing

  

perf-regression-accepted

Passes the instruction-count bench gate for an intended cost; state why in a PR comment

  

Reviewed

Confirmed

Issue has been confirmed

  

Reviewed

Duplicate

This issue or pull request already exists

  

Reviewed

Invalid

Invalid issue

  

Reviewed

Won't Fix

This issue won't be fixed

  

Status

Blocked

Something is blocking this issue or pull request

  

Status

Need More Info

Feedback is required to reproduce issue or to continue work

  

Status

Upstream

Waiting on a change in an upstream project

No labels

Area/ci

Area/cli

Area/client

Area/client-core

Area/daemon

Area/deps

Area/docs

Area/grid

Area/manual

Area/nix

Area/protocol

Area/pty

Area/render

Area/shaping

Area/skills

Area/transport

Area/vt

Compat/Breaking

Kind/Bug

Kind/Documentation

Kind/Enhancement

Kind/Feature

Kind/Performance

Kind/Security

Kind/Testing

perf-regression-accepted

Reviewed

Confirmed

Reviewed

Duplicate

Reviewed

Invalid

Reviewed

Won't Fix

Status

Blocked

Status

Need More Info

Status

Upstream

Milestone

Clear milestone

No items

No milestone

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

felis-terminal/felis!188

No description provided.