workspace, ci, docs: make every crate publishable and package them in CI #197

Merged

natsukium merged 1 commit from ci/publish-dry-run into main 2026-10-19 23:48:24 +09:00

Conversation 0 Commits 1 Files changed 24 +93 -92

natsukium commented 2026-10-19 20:20:58 +09:00

Owner

Copy link

Part of #160 (policy amendment). Builds on #196 (merged): verify.py checks the workspace version only on the binary crates.

• Every crate under crates/ is publishable. The workspace no longer sets publish = false, and only tests/ (felis-workspace-tests) keeps it.
• The nine library crates move to version = "0.1.0". felis-cli, felis-client and felis-daemon keep the app version (version.workspace = true). The internal [workspace.dependencies] entries carry version = "0.1.0" next to path.
• Dev-dependencies on felis crates name path only, so cargo package drops them. A versioned one would leave the felis-client-core ↔ felis-daemon cycle unpackageable. Cargo.lock and fuzz/Cargo.lock are regenerated.
• New just publish-dry-run (cargo publish --workspace --dry-run --allow-dirty), run by just check and pr.yml's build job. It packages all 12 crates and builds each against the others in publish order, in about 3 minutes here. If a version already exists on crates.io the dry-run only warns, so main stays green after a release.
• Docs: workspace.md "Versioning", implementation.md (the versioning rationale, plus a new section that records lockstep versions as the rejected alternative), testing.md CI table, CONTRIBUTING.md. Comments in deny.toml and nix/make-macos-app.sh are updated too.

What the gate does not prove: it builds dependents against the local copy of each library. Once a library is on crates.io, a change to it that keeps the published version would still pass. The rule that a library whose package contents changed takes a new version before any dependent is published belongs to the release-automation item, which must land before the first real publish.

Local: cargo build --locked, lint, deny, docs-links, publish-dry-run, nextest (4329 passed), selftest, test-msrv, prose-check. Reviews (pi, sol): design PASS after three rounds, implementation PASS after two.

Part of #160 (policy amendment). Builds on #196 (merged): `verify.py` checks the workspace version only on the binary crates. - Every crate under `crates/` is publishable. The workspace no longer sets `publish = false`, and only `tests/` (`felis-workspace-tests`) keeps it. - The nine library crates move to `version = "0.1.0"`. felis-cli, felis-client and felis-daemon keep the app version (`version.workspace = true`). The internal `[workspace.dependencies]` entries carry `version = "0.1.0"` next to `path`. - Dev-dependencies on felis crates name `path` only, so `cargo package` drops them. A versioned one would leave the felis-client-core ↔ felis-daemon cycle unpackageable. `Cargo.lock` and `fuzz/Cargo.lock` are regenerated. - New `just publish-dry-run` (`cargo publish --workspace --dry-run --allow-dirty`), run by `just check` and pr.yml's build job. It packages all 12 crates and builds each against the others in publish order, in about 3 minutes here. If a version already exists on crates.io the dry-run only warns, so `main` stays green after a release. - Docs: workspace.md "Versioning", implementation.md (the versioning rationale, plus a new section that records lockstep versions as the rejected alternative), testing.md CI table, CONTRIBUTING.md. Comments in deny.toml and nix/make-macos-app.sh are updated too. What the gate does not prove: it builds dependents against the local copy of each library. Once a library is on crates.io, a change to it that keeps the published version would still pass. The rule that a library whose package contents changed takes a new version before any dependent is published belongs to the release-automation item, which must land before the first real publish. Local: `cargo build --locked`, lint, deny, docs-links, publish-dry-run, nextest (4329 passed), selftest, test-msrv, prose-check. Reviews (pi, sol): design PASS after three rounds, implementation PASS after two.

natsukium added 2 commits 2026-10-19 20:20:58 +09:00

release: require the workspace version only on the binary crates ... b5c4776ec6

Under the #160 amendment the library crates take their own versions,
starting at 0.1.0, while felis-cli, felis-client and felis-daemon carry
the app version the release tag names. The tag check refused any crate
that did not inherit [workspace.package] version, so it would block the
first release with decoupled libraries. It now checks only the three
binary crates, and fails when one of them is missing rather than
passing a renamed crate silently.

Assisted-by: Claude Code

workspace, ci, docs: make every crate publishable and package them in CI ... 722c63fe08

The #160 amendment publishes every crate under crates/, with the
libraries on their own versions and the binary crates on the app
version. Until now each member inherited publish = false and the
workspace version, so nothing could be packaged and a packaging break
would surface only at the first real publish.

The libraries move to 0.1.0, and the internal workspace dependencies
carry that version next to their paths. Dev-dependencies on felis
crates name the path alone, so cargo package drops them; a versioned
one would leave the felis-client-core <-> felis-daemon cycle
unpackageable. The new publish-dry-run gate packages all twelve crates
and builds each against the others in publish order.

Assisted-by: Claude Code

natsukium force-pushed ci/publish-dry-run from 722c63fe08 to 1b2e030396 2026-10-19 23:08:35 +09:00 Compare

natsukium referenced this pull request 2026-10-19 23:19:05 +09:00

release, ci, docs, skills: bump, check and publish the crates with the app release #198

natsukium merged commit 724b1fedb7 into main 2026-10-19 23:48:24 +09:00

natsukium deleted branch ci/publish-dry-run 2026-10-19 23:48:24 +09:00

natsukium referenced this pull request from a commit 2026-10-19 23:48:26 +09:00

Merge pull request 'workspace, ci, docs: make every crate publishable and package them in CI' (#197) from ci/publish-dry-run into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

Area/ci

CI workflows (.forgejo/workflows/)

  

Area/cli

felis-cli crate, the felis front-door binary

  

Area/client

felis-client crate, the winit GUI frontend

  

Area/client-core

felis-client-core crate, shadow screen, config, connect_or_spawn_daemon

  

Area/daemon

felis-daemon crate, session pool, IPC server

  

Area/deps

Dependency bumps

  

Area/docs

Documentation tree when no narrower area fits

  

Area/grid

felis-grid crate, cells, scrollback, image store

  

Area/manual

User-facing docs: tutorials, how-to, user-facing reference pages

  

Area/nix

Nix flake, home-manager module, package definitions

  

Area/protocol

felis-protocol crate, felis.proto, frame layout, version constants

  

Area/pty

felis-pty crate, PTY backends

  

Area/render

felis-render-wgpu crate, GPU pipeline, atlas

  

Area/shaping

felis-shaping crate, swash shaper, font fallback

  

Area/skills

Agent skills (skills/felis, .agents/skills/)

  

Area/transport

felis-transport crate, framing, socket/pipe, SSH carrier

  

Area/vt

felis-vt crate, VT parser, dispatch

  

Compat/Breaking

Breaking change that won't be backward compatible

  

Kind/Bug

Something is not working

  

Kind/Documentation

Documentation changes

  

Kind/Enhancement

Improve existing functionality

  

Kind/Feature

New functionality

  

Kind/Performance

Throughput, latency, or memory cost

  

Kind/Security

This is security issue

  

Kind/Testing

Issue or pull request related to testing

  

perf-regression-accepted

Passes the instruction-count bench gate for an intended cost; state why in a PR comment

  

Reviewed

Confirmed

Issue has been confirmed

  

Reviewed

Duplicate

This issue or pull request already exists

  

Reviewed

Invalid

Invalid issue

  

Reviewed

Won't Fix

This issue won't be fixed

  

Status

Blocked

Something is blocking this issue or pull request

  

Status

Need More Info

Feedback is required to reproduce issue or to continue work

  

Status

Upstream

Waiting on a change in an upstream project

No labels

Area/ci

Area/cli

Area/client

Area/client-core

Area/daemon

Area/deps

Area/docs

Area/grid

Area/manual

Area/nix

Area/protocol

Area/pty

Area/render

Area/shaping

Area/skills

Area/transport

Area/vt

Compat/Breaking

Kind/Bug

Kind/Documentation

Kind/Enhancement

Kind/Feature

Kind/Performance

Kind/Security

Kind/Testing

perf-regression-accepted

Reviewed

Confirmed

Reviewed

Duplicate

Reviewed

Invalid

Reviewed

Won't Fix

Status

Blocked

Status

Need More Info

Status

Upstream

Milestone

Clear milestone

No items

No milestone

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

felis-terminal/felis!197

No description provided.