protocol, tests: check the minor ledger from the workspace tests member #199

Merged

natsukium merged 1 commit from workspace/out-of-crate-tests into main 2026-10-20 00:36:47 +09:00

Conversation 0 Commits 1 Files changed 9 +187 -169

natsukium commented 2026-10-20 00:07:38 +09:00

Owner

Copy link

Part of #160 (policy amendment: a test that reads a file outside its own crate moves to the tests/ member).

• A sweep of crates/ finds only two such tests, both in felis-protocol, and both read docs/reference/ipc.md through CARGO_MANIFEST_DIR/../..: the_minor_ledger_has_a_row_per_minor and the_ledger_covers_every_executable_addition. They move unchanged to tests/protocol_ledger.rs.
• The coverage test needs the generated ADDITIONS table. tools/proto/schema_meta.py now emits it as #[doc(hidden)] pub instead of #[cfg(test)] pub(crate), and felis_protocol::minor re-exports it.
• tests/README.md and tests/Cargo.toml list the new test.

Verified:

• Both moved tests fail when a ledger row is removed.
• felis-protocol's own tests pass from its extracted package.
• just lint, just publish-dry-run and fmt-check pass.
• Review (pi, luna): PASS.

Not addressed here (accepted by the amendment): six crates (felis-pty, felis-client-core, felis-render-core, felis-render-wgpu, felis-daemon, felis-cli) do not compile their tests from the extracted package, because cargo package drops the path-only felis dev-dependencies and the test features on them (test-util, testing).

Part of #160 (policy amendment: a test that reads a file outside its own crate moves to the `tests/` member). - A sweep of `crates/` finds only two such tests, both in felis-protocol, and both read `docs/reference/ipc.md` through `CARGO_MANIFEST_DIR/../..`: `the_minor_ledger_has_a_row_per_minor` and `the_ledger_covers_every_executable_addition`. They move unchanged to `tests/protocol_ledger.rs`. - The coverage test needs the generated `ADDITIONS` table. `tools/proto/schema_meta.py` now emits it as `#[doc(hidden)] pub` instead of `#[cfg(test)] pub(crate)`, and `felis_protocol::minor` re-exports it. - `tests/README.md` and `tests/Cargo.toml` list the new test. Verified: - Both moved tests fail when a ledger row is removed. - felis-protocol's own tests pass from its extracted package. - `just lint`, `just publish-dry-run` and `fmt-check` pass. - Review (pi, luna): PASS. Not addressed here (accepted by the amendment): six crates (felis-pty, felis-client-core, felis-render-core, felis-render-wgpu, felis-daemon, felis-cli) do not compile their tests from the extracted package, because `cargo package` drops the path-only felis dev-dependencies and the test features on them (`test-util`, `testing`).

natsukium added 1 commit 2026-10-20 00:07:38 +09:00

protocol, tests: check the minor ledger from the workspace tests member ... f1206c9a3a

felis-protocol's two ledger tests read docs/reference/ipc.md through
CARGO_MANIFEST_DIR/../.., which does not exist once the crate is
published, so `cargo test` on the crates.io package failed. They now
live in the tests/ member, which sits beside docs/ and is never
published; the crate's own suite passes from its extracted package.

The coverage check needs the schema's additions, so the generated
ADDITIONS table is compiled in and re-exported as a doc(hidden) item
of felis_protocol::minor instead of existing only under cfg(test).

Assisted-by: Claude Code

natsukium scheduled this pull request to auto merge when all checks succeed 2026-10-20 00:16:22 +09:00

natsukium force-pushed workspace/out-of-crate-tests from f1206c9a3a to c2b7cfeb4d 2026-10-20 00:25:50 +09:00 Compare

natsukium merged commit a06baa6855 into main 2026-10-20 00:36:47 +09:00

natsukium deleted branch workspace/out-of-crate-tests 2026-10-20 00:36:47 +09:00

natsukium referenced this pull request from a commit 2026-10-20 00:36:49 +09:00

Merge pull request 'protocol, tests: check the minor ledger from the workspace tests member' (#199) from workspace/out-of-crate-tests into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

Area/ci

CI workflows (.forgejo/workflows/)

  

Area/cli

felis-cli crate, the felis front-door binary

  

Area/client

felis-client crate, the winit GUI frontend

  

Area/client-core

felis-client-core crate, shadow screen, config, connect_or_spawn_daemon

  

Area/daemon

felis-daemon crate, session pool, IPC server

  

Area/deps

Dependency bumps

  

Area/docs

Documentation tree when no narrower area fits

  

Area/grid

felis-grid crate, cells, scrollback, image store

  

Area/manual

User-facing docs: tutorials, how-to, user-facing reference pages

  

Area/nix

Nix flake, home-manager module, package definitions

  

Area/protocol

felis-protocol crate, felis.proto, frame layout, version constants

  

Area/pty

felis-pty crate, PTY backends

  

Area/render

felis-render-wgpu crate, GPU pipeline, atlas

  

Area/shaping

felis-shaping crate, swash shaper, font fallback

  

Area/skills

Agent skills (skills/felis, .agents/skills/)

  

Area/transport

felis-transport crate, framing, socket/pipe, SSH carrier

  

Area/vt

felis-vt crate, VT parser, dispatch

  

Compat/Breaking

Breaking change that won't be backward compatible

  

Kind/Bug

Something is not working

  

Kind/Documentation

Documentation changes

  

Kind/Enhancement

Improve existing functionality

  

Kind/Feature

New functionality

  

Kind/Performance

Throughput, latency, or memory cost

  

Kind/Security

This is security issue

  

Kind/Testing

Issue or pull request related to testing

  

perf-regression-accepted

Passes the instruction-count bench gate for an intended cost; state why in a PR comment

  

Reviewed

Confirmed

Issue has been confirmed

  

Reviewed

Duplicate

This issue or pull request already exists

  

Reviewed

Invalid

Invalid issue

  

Reviewed

Won't Fix

This issue won't be fixed

  

Status

Blocked

Something is blocking this issue or pull request

  

Status

Need More Info

Feedback is required to reproduce issue or to continue work

  

Status

Upstream

Waiting on a change in an upstream project

No labels

Area/ci

Area/cli

Area/client

Area/client-core

Area/daemon

Area/deps

Area/docs

Area/grid

Area/manual

Area/nix

Area/protocol

Area/pty

Area/render

Area/shaping

Area/skills

Area/transport

Area/vt

Compat/Breaking

Kind/Bug

Kind/Documentation

Kind/Enhancement

Kind/Feature

Kind/Performance

Kind/Security

Kind/Testing

perf-regression-accepted

Reviewed

Confirmed

Reviewed

Duplicate

Reviewed

Invalid

Reviewed

Won't Fix

Status

Blocked

Status

Need More Info

Status

Upstream

Milestone

Clear milestone

No items

No milestone

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

felis-terminal/felis!199

No description provided.