workspace, release: build each crate's tests from its published package #201

Merged

natsukium merged 1 commit from workspace/packaged-tests into main

2026-10-20 09:19:59 +09:00

natsukium commented

2026-10-20 01:24:19 +09:00

Owner

Part of #160: every published crate's tests build from its crates.io package, and a release-time guard keeps it that way.

felis dev-dependencies inherit the versioned [workspace.dependencies] entries (felis-daemon gets one at the app version), so cargo package keeps them.
Exception: felis-client-core → felis-daemon stays path-only (felis-daemon dev-depends back; versions on both edges make cargo publish --workspace --dry-run fail). The client-core tests that serve a real daemon are behind a daemon-tests feature, turned on in the workspace by a path-only self dev-dependency that cargo package drops.
tools/release/crates.py check enforces the new rule; crates.py package-tests (just package-tests, in release.yml's build job, timeout 45 → 60 min) packages, extracts and cargo test --no-runs every crate against the other packages.

Verified locally: all 12 packaged suites compile and pass; un-gating one daemon test makes package-tests fail; package-tests takes ~3.5 min warm. luna review: PASS.

Part of #160: every published crate's tests build from its crates.io package, and a release-time guard keeps it that way. - felis dev-dependencies inherit the versioned `[workspace.dependencies]` entries (felis-daemon gets one at the app version), so `cargo package` keeps them. - Exception: felis-client-core → felis-daemon stays path-only (felis-daemon dev-depends back; versions on both edges make `cargo publish --workspace --dry-run` fail). The client-core tests that serve a real daemon are behind a `daemon-tests` feature, turned on in the workspace by a path-only self dev-dependency that `cargo package` drops. - `tools/release/crates.py check` enforces the new rule; `crates.py package-tests` (`just package-tests`, in `release.yml`'s build job, timeout 45 → 60 min) packages, extracts and `cargo test --no-run`s every crate against the other packages. Verified locally: all 12 packaged suites compile and pass; un-gating one daemon test makes `package-tests` fail; `package-tests` takes ~3.5 min warm. luna review: PASS.

natsukium added 1 commit

2026-10-20 01:24:19 +09:00

workspace, release: build each crate's tests from its published package

fuzz / cargo fuzz nightly long-run (pull_request) Has been skipped

Details

windows / detect relevant changes (pull_request) Successful in 9s

Details

darwin / detect relevant changes (pull_request) Successful in 8s

Details

windows / windows docs-only no-op (pull_request) Has been skipped

Details

darwin / darwin docs-only no-op (pull_request) Has been skipped

Details

bench / instruction-count regression gate (pull_request) Successful in 47s

Details

fuzz / cargo fuzz smoke (per target) (pull_request) Successful in 54s

Details

windows / cargo nextest (Windows) (pull_request) Successful in 2m42s

Details

darwin / build felis (aarch64-darwin) (pull_request) Successful in 2m44s

Details

pr / nix flake check (pull_request) Successful in 1m23s

Details

windows / frontend smoke (Windows) (pull_request) Successful in 54s

Details

pr / cargo build / clippy / test / deny (pull_request) Successful in 2m16s

Details

pr / wire schema is compatible with the base (pull_request) Successful in 3s

Details

pr / frontend smoke (x86_64-linux) (pull_request) Successful in 28s

Details

windows / cargo clippy (Windows cross) (pull_request) Successful in 16s

Details

d7707ef225

A crates.io consumer, or a distribution that runs a crate's tests from
its tarball, gets a package whose path-only felis dev-dependencies were
dropped, so six crates' tests did not compile there. Felis
dev-dependencies now inherit the versioned [workspace.dependencies]
entries and stay in the package.

The exception is felis-client-core's dev-dependency on felis-daemon:
felis-daemon dev-depends back, and with versions on both edges neither
package can be built before the other is on crates.io. That edge stays
path-only, and the client-core tests that serve a real daemon sit behind
a daemon-tests feature, which a path-only self dev-dependency turns on
in the workspace and cargo package drops with it.

crates.py check enforces the new rule, and `just package-tests` (in the
tag's build job) compiles every package's tests from the extracted
tarballs, so a regression fails the release rather than a consumer.

Assisted-by: Claude Code

natsukium merged commit 82e1d9f7a1 into main

2026-10-20 09:19:59 +09:00

natsukium deleted branch workspace/packaged-tests

2026-10-20 09:19:59 +09:00

natsukium referenced this pull request from a commit

2026-10-20 09:20:00 +09:00

Merge pull request 'workspace, release: build each crate's tests from its published package' (#201) from workspace/packaged-tests into main