client: run a keymap command in the background without a transient session #227

Merged

natsukium merged 1 commit from client/run-background into main 2026-10-23 17:09:24 +09:00

Conversation 0 Commits 1 Files changed 11 +281 -47

natsukium commented 2026-10-21 21:31:18 +09:00

Owner

Copy link

A run binding with background = true spawns its command without a transient session, so the window stays usable while the command runs. That covers the two requests behind this, without a dedicated window action (non-goals.md "Window-management chords"):

"super+n" = { kind = "run", background = true, command = ["/path/to/felis"] }

This opens another window in the session's directory; felis attach "$FELIS_ORIGIN_SESSION_ID" through sh -c opens a second window on the same session. Before this change, the binding had to be open -n <store path>/felis.app, which broke on every upgrade and opened in $HOME.

The command keeps a foreground run's context: FELIS_ORIGIN_SESSION_ID, FELIS_HOST, FELIS_CWD, and the session's local OSC 7 directory.

• Spawn: the client spawns it detached (its own process group, null stdio) and reaps it on a thread that logs failures.
• cwd fallback: with no local OSC 7 directory it starts in the home directory, not the client's /.
• Gating: it is refused in the same cases as a foreground run.
• Origin variables: it relies on #226, which removes stale origin variables, so a launched window never inherits a previous chord's FELIS_HOST.

Closes #224.

PATH resolution of bare names is out of scope; the example uses an absolute path. Resolving the sibling felis is #225.

BindingValue::Run / Action::RunCommand gain a field, so felis-client-core takes a library minor; the app version is unaffected.

Verification

• New tests in felis-client-core pipe:
  • the origin variables the origin lacks are removed, and the ones it has are exported;
  • cwd is the local OSC 7 directory, else home;
  • an empty argv yields no command;
  • on Unix, the spawn returns before the command finishes and the command sees the current session id.
• Workspace nextest under the dev shell: 4322 passed. The run excludes the cli_bridge write-failure hang and the felis-render-wgpu golden tests, both of which fail on clean main.
• Passing: just fmt-check lint check-portable skill-check docs-links deny publish-dry-run proto-compat test-tools check-windows.
• Manual run on macOS against an isolated daemon:
  • a probe shell reported an OSC 7 directory containing a space;
  • ctrl+shift+b bound to a background /bin/sh command that logs its context and sleeps 4 s, fired twice within those 4 s, ran both times;
  • each run saw the session's id, that directory, and an unset FELIS_HOST;
  • both runs finished and left no zombie behind.

A `run` binding with `background = true` spawns its command without a transient session, so the window stays usable while the command runs. That covers the two requests behind this, without a dedicated window action (`non-goals.md` "Window-management chords"): ```toml "super+n" = { kind = "run", background = true, command = ["/path/to/felis"] } ``` This opens another window in the session's directory; `felis attach "$FELIS_ORIGIN_SESSION_ID"` through `sh -c` opens a second window on the same session. Before this change, the binding had to be `open -n <store path>/felis.app`, which broke on every upgrade and opened in `$HOME`. The command keeps a foreground `run`'s context: `FELIS_ORIGIN_SESSION_ID`, `FELIS_HOST`, `FELIS_CWD`, and the session's local `OSC 7` directory. - **Spawn:** the client spawns it detached (its own process group, null stdio) and reaps it on a thread that logs failures. - **cwd fallback:** with no local `OSC 7` directory it starts in the home directory, not the client's `/`. - **Gating:** it is refused in the same cases as a foreground `run`. - **Origin variables:** it relies on #226, which removes stale origin variables, so a launched window never inherits a previous chord's `FELIS_HOST`. Closes #224. PATH resolution of bare names is out of scope; the example uses an absolute path. Resolving the sibling `felis` is #225. `BindingValue::Run` / `Action::RunCommand` gain a field, so felis-client-core takes a library minor; the app version is unaffected. ## Verification - New tests in `felis-client-core` `pipe`: - the origin variables the origin lacks are removed, and the ones it has are exported; - cwd is the local `OSC 7` directory, else home; - an empty argv yields no command; - on Unix, the spawn returns before the command finishes and the command sees the current session id. - Workspace nextest under the dev shell: 4322 passed. The run excludes the `cli_bridge` write-failure hang and the `felis-render-wgpu` golden tests, both of which fail on clean `main`. - Passing: `just fmt-check lint check-portable skill-check docs-links deny publish-dry-run proto-compat test-tools check-windows`. - Manual run on macOS against an isolated daemon: - a probe shell reported an `OSC 7` directory containing a space; - `ctrl+shift+b` bound to a background `/bin/sh` command that logs its context and sleeps 4 s, fired twice within those 4 s, ran both times; - each run saw the session's id, that directory, and an unset `FELIS_HOST`; - both runs finished and left no zombie behind.

natsukium added 2 commits 2026-10-21 21:31:18 +09:00

daemon: scrub stale keymap-command origin variables from every base ... fce752591d

The client exports FELIS_ORIGIN_SESSION_ID, FELIS_HOST, FELIS_CWD and
the viewport anchors to a keymap command, adding only the values the
current origin has. Nothing removed an inherited copy, so a felis
window launched from such a command kept that chord's values in its
own environment and handed them to its later chords and new sessions:
a local window opened from a --host window went on reporting the
remote host, and a script branching on FELIS_HOST dialed the wrong
daemon.

The daemon now removes them in apply_env_policy next to the denylist,
which every create passes through whatever its base (the client's
snapshot, the relay carrier's environment, or the daemon's own birth
environment, including a systemd-run hand-off and the fallback when a
snapshot is over its caps). Unlike the denylist they are not reserved:
the chord that spawns a command sets the current values through
SpawnArgs.env, which applies after the scrub. Scrubbing only in the
client's capture and in the daemon auto-spawn was rejected because the
relay base and a manager-started daemon bypass both.

felis-client-core exposes the full set as ORIGIN_ENV_KEYS, and a
daemon test keeps the two lists equal, since the daemon reaches
client-core only as a dev-dependency.

Assisted-by: Claude Code

client: run a keymap command in the background without a transient session ... 29106ebd7c

`run` always spawned its argv as a transient session over the live
grid and returned to the window only when the command exited. That is
what a session picker needs, but a command that wants only the
session's context, such as opening another felis window in the
session's directory or a second window on the same session, then
covered the origin window for as long as the new window lived. The
workaround was a launcher that returns at once (`open -n` with the
app's store path), which also dropped the session's directory.

`background = true` keeps the context (FELIS_ORIGIN_SESSION_ID,
FELIS_HOST, FELIS_CWD and the OSC 7 directory) and drops the transient:
the client spawns the argv itself, detached in its own process group
with null stdio, and reaps it on a thread that logs a failure. The
"a daemon spawns, not the client" rule rests on the client not being a
PTY host, which a PTY-less spawn does not need. With no local OSC 7
directory it starts in the home directory rather than the client's own
cwd, which is / for a window macOS launched. It is gated exactly like a
foreground run, so it cannot fire while a landing could still leave
the origin describing the departing session.

A dedicated new-window action was rejected as a window-management
chord (non-goals.md). Resolving bare command names against a
configured PATH was left out because it would re-implement the OS
executable lookup on every platform.

The new field on BindingValue::Run and Action::RunCommand is a
breaking change to felis-client-core's library API.

Assisted-by: Claude Code

natsukium added 1 commit 2026-10-21 23:26:41 +09:00

tmp: clear stale packaged crates before the publish dry-run ... d29f1642b8

Assisted-by: Claude Code

natsukium force-pushed client/run-background from d29f1642b8 to 29106ebd7c 2026-10-21 23:32:54 +09:00 Compare

natsukium added 1 commit 2026-10-21 23:39:33 +09:00

tmp: clear stale packaged crates before the publish dry-run 2d8e422c3e

natsukium force-pushed client/run-background from 2d8e422c3e to e8829d6fdc 2026-10-21 23:45:52 +09:00 Compare

natsukium force-pushed client/run-background from e8829d6fdc to 830a709575 2026-10-21 23:54:31 +09:00 Compare

natsukium force-pushed client/run-background from 830a709575 to 5c8ba95be6 2026-10-22 00:29:13 +09:00 Compare

natsukium force-pushed client/run-background from 5c8ba95be6 to 29106ebd7c 2026-10-22 00:34:48 +09:00 Compare

natsukium force-pushed client/run-background from 29106ebd7c to d4871f690f 2026-10-22 01:39:07 +09:00 Compare

natsukium force-pushed client/run-background from d4871f690f to 064750b33e 2026-10-22 01:54:48 +09:00 Compare

natsukium force-pushed client/run-background from 064750b33e to f9b86e9dae 2026-10-23 16:55:47 +09:00 Compare

natsukium merged commit 67ed98a1e4 into main 2026-10-23 17:09:24 +09:00

natsukium deleted branch client/run-background 2026-10-23 17:09:24 +09:00

natsukium referenced this pull request from a commit 2026-10-23 17:09:26 +09:00

Merge pull request 'client: run a keymap command in the background without a transient session' (#227) from client/run-background into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

Area/ci

CI workflows (.forgejo/workflows/)

  

Area/cli

felis-cli crate, the felis front-door binary

  

Area/client

felis-client crate, the winit GUI frontend

  

Area/client-core

felis-client-core crate, shadow screen, config, connect_or_spawn_daemon

  

Area/daemon

felis-daemon crate, session pool, IPC server

  

Area/deps

Dependency bumps

  

Area/docs

Documentation tree when no narrower area fits

  

Area/grid

felis-grid crate, cells, scrollback, image store

  

Area/manual

User-facing docs: tutorials, how-to, user-facing reference pages

  

Area/nix

Nix flake, home-manager module, package definitions

  

Area/protocol

felis-protocol crate, felis.proto, frame layout, version constants

  

Area/pty

felis-pty crate, PTY backends

  

Area/render

felis-render-wgpu crate, GPU pipeline, atlas

  

Area/shaping

felis-shaping crate, swash shaper, font fallback

  

Area/skills

Agent skills (skills/felis, .agents/skills/)

  

Area/transport

felis-transport crate, framing, socket/pipe, SSH carrier

  

Area/vt

felis-vt crate, VT parser, dispatch

  

Compat/Breaking

Breaking change that won't be backward compatible

  

Kind/Bug

Something is not working

  

Kind/Documentation

Documentation changes

  

Kind/Enhancement

Improve existing functionality

  

Kind/Feature

New functionality

  

Kind/Performance

Throughput, latency, or memory cost

  

Kind/Security

This is security issue

  

Kind/Testing

Issue or pull request related to testing

  

perf-regression-accepted

Passes the instruction-count bench gate for an intended cost; state why in a PR comment

  

Reviewed

Confirmed

Issue has been confirmed

  

Reviewed

Duplicate

This issue or pull request already exists

  

Reviewed

Invalid

Invalid issue

  

Reviewed

Won't Fix

This issue won't be fixed

  

Status

Blocked

Something is blocking this issue or pull request

  

Status

Need More Info

Feedback is required to reproduce issue or to continue work

  

Status

Upstream

Waiting on a change in an upstream project

No labels

Area/ci

Area/cli

Area/client

Area/client-core

Area/daemon

Area/deps

Area/docs

Area/grid

Area/manual

Area/nix

Area/protocol

Area/pty

Area/render

Area/shaping

Area/skills

Area/transport

Area/vt

Compat/Breaking

Kind/Bug

Kind/Documentation

Kind/Enhancement

Kind/Feature

Kind/Performance

Kind/Security

Kind/Testing

perf-regression-accepted

Reviewed

Confirmed

Reviewed

Duplicate

Reviewed

Invalid

Reviewed

Won't Fix

Status

Blocked

Status

Need More Info

Status

Upstream

Milestone

Clear milestone

No items

No milestone

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

felis-terminal/felis!227

No description provided.