client: confirm an unbracketed paste that carries any control byte #229

Merged

natsukium merged 1 commit from client/paste-control-confirm into main 2026-10-23 11:07:18 +09:00

Conversation 0 Commits 1 Files changed 8 +89 -26

natsukium commented 2026-10-22 08:07:18 +09:00

Owner

Copy link

With bracketed paste off, the confirmation bar (REQ-804) asked only when a paste carried a line break. Other C0 controls act as typed keys at the receiving program just as a newline does, so the bar now asks for any C0 control other than HT. DEL, C1 and non-ASCII text do not raise it.

• felis-client-core: paste_needs_confirmation widened; a single-line paste reads "Paste text containing control characters? …" instead of "Paste 1 lines?". Unit tests and proptests.
• The daemon's paste framing is unchanged, so felis sessions send still delivers exactly what a script wrote.
• Docs: REQ-804, input explanation, keybindings confirmation-bar table, key-encoding paste note; CHANGELOG.

Closes #217

With bracketed paste off, the confirmation bar (REQ-804) asked only when a paste carried a line break. Other C0 controls act as typed keys at the receiving program just as a newline does, so the bar now asks for any C0 control other than HT. DEL, C1 and non-ASCII text do not raise it. - `felis-client-core`: `paste_needs_confirmation` widened; a single-line paste reads "Paste text containing control characters? …" instead of "Paste 1 lines?". Unit tests and proptests. - The daemon's paste framing is unchanged, so `felis sessions send` still delivers exactly what a script wrote. - Docs: REQ-804, input explanation, keybindings confirmation-bar table, key-encoding paste note; CHANGELOG. Closes #217

natsukium added 1 commit 2026-10-22 08:07:18 +09:00

client: confirm an unbracketed paste that carries any control byte ... ba924005b1

With bracketed paste off, every pasted byte reaches the program as a
typed key, and the confirmation bar fired only on a line break. Other
C0 controls are just as live at a line editor: ^O runs the line in bash
and zsh, ^C and ^D cancel or exit, ESC starts a key sequence. The gate
now fires on any C0 control except HT, which pasted code is full of.

The check stays on the client and the confirmed bytes still ship
verbatim; stripping them on the daemon would change what
`felis sessions send` delivers.

Assisted-by: Claude Code

natsukium referenced this pull request 2026-10-22 08:48:17 +09:00

release: dry-run the publish from a fresh unpack of the packages #232

natsukium force-pushed client/paste-control-confirm from ba924005b1 to f2a08840c7 2026-10-23 11:00:54 +09:00 Compare

natsukium merged commit fc882bb489 into main 2026-10-23 11:07:18 +09:00

natsukium deleted branch client/paste-control-confirm 2026-10-23 11:07:18 +09:00

natsukium referenced this pull request from a commit 2026-10-23 11:07:19 +09:00

Merge pull request 'client: confirm an unbracketed paste that carries any control byte' (#229) from client/paste-control-confirm into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

Area/ci

CI workflows (.forgejo/workflows/)

  

Area/cli

felis-cli crate, the felis front-door binary

  

Area/client

felis-client crate, the winit GUI frontend

  

Area/client-core

felis-client-core crate, shadow screen, config, connect_or_spawn_daemon

  

Area/daemon

felis-daemon crate, session pool, IPC server

  

Area/deps

Dependency bumps

  

Area/docs

Documentation tree when no narrower area fits

  

Area/grid

felis-grid crate, cells, scrollback, image store

  

Area/manual

User-facing docs: tutorials, how-to, user-facing reference pages

  

Area/nix

Nix flake, home-manager module, package definitions

  

Area/protocol

felis-protocol crate, felis.proto, frame layout, version constants

  

Area/pty

felis-pty crate, PTY backends

  

Area/render

felis-render-wgpu crate, GPU pipeline, atlas

  

Area/shaping

felis-shaping crate, swash shaper, font fallback

  

Area/skills

Agent skills (skills/felis, .agents/skills/)

  

Area/transport

felis-transport crate, framing, socket/pipe, SSH carrier

  

Area/vt

felis-vt crate, VT parser, dispatch

  

Compat/Breaking

Breaking change that won't be backward compatible

  

Kind/Bug

Something is not working

  

Kind/Documentation

Documentation changes

  

Kind/Enhancement

Improve existing functionality

  

Kind/Feature

New functionality

  

Kind/Performance

Throughput, latency, or memory cost

  

Kind/Security

This is security issue

  

Kind/Testing

Issue or pull request related to testing

  

perf-regression-accepted

Passes the instruction-count bench gate for an intended cost; state why in a PR comment

  

Reviewed

Confirmed

Issue has been confirmed

  

Reviewed

Duplicate

This issue or pull request already exists

  

Reviewed

Invalid

Invalid issue

  

Reviewed

Won't Fix

This issue won't be fixed

  

Status

Blocked

Something is blocking this issue or pull request

  

Status

Need More Info

Feedback is required to reproduce issue or to continue work

  

Status

Upstream

Waiting on a change in an upstream project

No labels

Area/ci

Area/cli

Area/client

Area/client-core

Area/daemon

Area/deps

Area/docs

Area/grid

Area/manual

Area/nix

Area/protocol

Area/pty

Area/render

Area/shaping

Area/skills

Area/transport

Area/vt

Compat/Breaking

Kind/Bug

Kind/Documentation

Kind/Enhancement

Kind/Feature

Kind/Performance

Kind/Security

Kind/Testing

perf-regression-accepted

Reviewed

Confirmed

Reviewed

Duplicate

Reviewed

Invalid

Reviewed

Won't Fix

Status

Blocked

Status

Need More Info

Status

Upstream

Milestone

Clear milestone

No items

No milestone

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

felis-terminal/felis!229

No description provided.