replay: apply felis's shared renderer effect instead of a copied mapping #7

Merged

natsukium merged 1 commit from shared-renderer-effect into main

2026-09-26 01:45:50 +09:00

natsukium commented

2026-09-26 01:27:27 +09:00

Owner

Why

felis-reel copied felis-client's GridMsg → renderer mapping, which could drift silently. felis now shares it as felis_client_core::renderer_effect (natsukium/felis#468).

What

Bump felis crates to d84ba1b4.
replay.rs: renderer_effect + an exhaustive apply_renderer_effect replace the copy.
Design and backlog: the copy, its "Revisit if" trigger and the blocked item are gone.

Verification

fmt, clippy, tests (golden frames unchanged), cargo deny green locally.

## Why felis-reel copied felis-client's GridMsg → renderer mapping, which could drift silently. felis now shares it as `felis_client_core::renderer_effect` (natsukium/felis#468). ## What - Bump felis crates to d84ba1b4. - `replay.rs`: `renderer_effect` + an exhaustive `apply_renderer_effect` replace the copy. - Design and backlog: the copy, its "Revisit if" trigger and the blocked item are gone. ## Verification fmt, clippy, tests (golden frames unchanged), `cargo deny` green locally.

natsukium added 1 commit

2026-09-26 01:27:27 +09:00

replay: apply felis's shared renderer effect instead of a copied mapping

ci / cargo fmt / clippy / test / deny (pull_request) Successful in 1m1s

Details

c6137e7f8d

felis-reel carried a copy of felis-client's GridMsg to renderer-state
mapping, which could fall out of step silently when felis added a
renderer-affecting message. felis-client-core now owns that mapping as
`renderer_effect`, and felis-client uses it too; felis-reel applies the
returned effect with an exhaustive match, so a new effect fails to
build here. Bumps every felis crate to that revision.

Assisted-by: Claude Code

natsukium merged commit e2d1673b17 into main

2026-09-26 01:45:50 +09:00

natsukium deleted branch shared-renderer-effect

2026-09-26 01:45:50 +09:00

natsukium referenced this pull request from a commit

2026-09-26 01:45:50 +09:00

replay: apply felis's shared renderer effect instead of a copied mapping (#7)