ci: keep Windows and Darwin checks satisfiable on docs-only changes #190

Merged

natsukium merged 3 commits from ci/docs-only-noop into main 2026-09-07 19:16:54 +09:00

Conversation 0 Commits 3 Files changed 2 +72 -15

natsukium commented 2026-09-07 16:37:46 +09:00

Owner

Copy link

Fixes the docs-only merge block (405) reported for #181–#183.

Branch protection requires windows /** and darwin /**, but those workflows were skipped entirely via paths-ignore on docs-only diffs, so the required statuses never appeared.

• Remove workflow-level paths-ignore from windows.yml/darwin.yml
• Gate heavy jobs behind a changes job (nix, fetch-depth: 0) that diffs the PR base / push before against HEAD (merge-base aware). Docs-only (docs/**, **/*.md) → relevant=false.
• Heavy jobs run only when relevant == 'true'; a *-noop job runs on relevant == 'false' and succeeds, so the workflow always reports at least one successful status matching /**.
• windows-package keeps its push-only gate plus relevant.

Refs #181 #182 #183

Fixes the docs-only merge block (405) reported for #181–#183. Branch protection requires `windows /**` and `darwin /**`, but those workflows were skipped entirely via `paths-ignore` on docs-only diffs, so the required statuses never appeared. - Remove workflow-level `paths-ignore` from `windows.yml`/`darwin.yml` - Gate heavy jobs behind a `changes` job (nix, `fetch-depth: 0`) that diffs the PR base / push `before` against `HEAD` (merge-base aware). Docs-only (`docs/**`, `**/*.md`) → `relevant=false`. - Heavy jobs run only when `relevant == 'true'`; a `*-noop` job runs on `relevant == 'false'` and succeeds, so the workflow always reports at least one successful status matching `/**`. - `windows-package` keeps its `push`-only gate plus `relevant`. Refs #181 #182 #183

natsukium added 1 commit 2026-09-07 16:37:46 +09:00

ci: keep Windows and Darwin checks satisfiable on docs-only changes ... 2c3437aa58

Branch protection requires windows /** and darwin /**, but those
workflows were skipped entirely via paths-ignore on docs-only diffs, so
the required statuses never appeared and the merge API returned 405.

Remove workflow-level paths-ignore and gate the heavy jobs behind a
nix-hosted changes gate that diffs the PR base (or push before) against
HEAD. When no relevant file remains the workflow still reports a
successful no-op job, satisfying the /** requirement while avoiding
Windows/macOS minutes. Code changes continue to run the full matrix.

Refs #181 #182 #183

Assisted-by: Pi Coding Agent:Muse Spark 1.2

natsukium added 1 commit 2026-09-07 16:45:11 +09:00

ci: extract docs-only detection to composite action ... 01b80624cb

Share the git-diff based relevant check between windows and darwin
via .forgejo/actions/detect-changes. The inline script was duplicated
verbatim; a composite action keeps the workflow files to one line and
makes the ignore set (docs/**, **/*.md) a single definition, matching
the existing cargo-env pattern.

Alternative considered: dorny/paths-filter@v3 does run on Forgejo
(fetch-depth: 0 fallback to git, no token needed) but adds an external
download and an extra filter language for a 10-line predicate. The
self-contained checkout+bash keeps the CI hermetic and auditable.

No behavior change; the changes gate and docs-only no-op remain.

Assisted-by: Pi Coding Agent:Muse Spark 1.2

natsukium added 1 commit 2026-09-07 16:51:30 +09:00

ci: use dorny/paths-filter@v4 for docs-only gate ... b66856a584

Prefer the well-known dorny/paths-filter@v4 over the bespoke
checkout+bash composite. Both workflows now run a single changes job
via dorny with predicate-quantifier some-with-excludes:

  relevant:
    - '**'
    - '!docs/**'
    - '!**/*.md'
    - '!*.md'

This mirrors the previous docs/**, **/*.md + *.md ignore set and keeps
the /** branch protection satisfiable via the docs-only no-op jobs.
Requires pull-requests: read for PR API mode (push falls back to git).

Remove .forgejo/actions/detect-changes in favor of the external action.

Assisted-by: Pi Coding Agent:Muse Spark 1.2

natsukium merged commit b66856a584 into main 2026-09-07 19:16:54 +09:00

natsukium deleted branch ci/docs-only-noop 2026-09-07 19:16:54 +09:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

priority/P0

Must be resolved before the v0.1.0 tag

  

priority/P1

Must be settled before the first public contract freezes

  

priority/P2

Explicitly deferred until after v0.1.0

  

release/v0.1.0

Work tracked for the first tagged release

  

status/blocked

Cannot start now: waits on an upstream release, another issue, or a recorded revisit trigger

  

status/planned

Triaged with a source-grounded plan and a passed pi review; ready to implement

  

type/bug

Shipped behavior that contradicts the docs or the code's own intent; needs a product code change

  

type/design

An open scope or trade-off question; needs a recorded decision in the owning explanation doc before code

  

type/test-gap

Documented or reviewed behavior that no test pins; usually split from a review finding, needs no product code change

  

type/tracker

Parent issue that tracks child work

No labels

priority/P0

priority/P1

priority/P2

release/v0.1.0

status/blocked

status/planned

type/bug

type/design

type/test-gap

type/tracker

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

natsukium/felis!190

No description provided.