cli: enumerate the bridge's finite request params #204

Merged

natsukium merged 1 commit from fix/bridge-schema-enums-178 into main 2026-09-07 22:27:01 +09:00

Conversation 0 Commits 1 Files changed 8 +122 -12

natsukium commented 2026-09-07 22:01:29 +09:00

Owner

Copy link

Fixes #178.

source and attachment were bare strings in the published bridge request grammar, so a consumer could validate a line
locally and still be answered malformed_request by a live bridge — the schema bundle promised more than the runtime
honors.

• source now carries the value set the runtime parses, read off the --source ValueEnum so the schema and the
  parser cannot drift.
• attachment now carries the decimal pattern the roster prints.
• The bridge charges a bad attachment to the request's spelling rather than to the request, matching the rule the schema
  now states.
• New invalid-request fixtures (req-source-is-not-a-region.json, req-attachment-is-not-decimal.json) pin both
  rejections.

Doc cascade: docs/reference/cli.md records the two newly-bounded request params; CHANGELOG.md notes the
user-affecting tightening of the published schema.

Verified: just check green (fmt, clippy, nextest, deny, proto-compat); reviewed by pi sol + pi luna; docs proofread by
Gemini gemini-3.8-flash-high

Deferred

• AttachmentId's ^[0-9]+$ pattern still admits digit strings above u64, which parse_attachment_id rejects as
  out-of-range. A single overflow class; the published AttachmentObject.id output pattern already uses the same
  expression, so tightening only the request side would split them, and JSON Schema has no clean numeric bound for a
  decimal held in a string. Not worth an issue.
• The source-enum-equals-runtime-set test does not independently verify the reverse direction. Both source_values()
  and parse_region_source() are derived from the same clap ValueEnum impl, so the residual drift risk is verified
  low; strengthening test independence is optional hardening beyond issue #178's acceptance criteria.

Fixes #178. `source` and `attachment` were bare strings in the published bridge request grammar, so a consumer could validate a line locally and still be answered `malformed_request` by a live bridge — the schema bundle promised more than the runtime honors. - `source` now carries the value set the runtime parses, read off the `--source` `ValueEnum` so the schema and the parser cannot drift. - `attachment` now carries the decimal pattern the roster prints. - The bridge charges a bad attachment to the request's spelling rather than to the request, matching the rule the schema now states. - New invalid-request fixtures (`req-source-is-not-a-region.json`, `req-attachment-is-not-decimal.json`) pin both rejections. Doc cascade: `docs/reference/cli.md` records the two newly-bounded request params; `CHANGELOG.md` notes the user-affecting tightening of the published schema. Verified: just check green (fmt, clippy, nextest, deny, proto-compat); reviewed by pi sol + pi luna; docs proofread by Gemini gemini-3.8-flash-high ## Deferred - `AttachmentId`'s `^[0-9]+$` pattern still admits digit strings above u64, which `parse_attachment_id` rejects as out-of-range. A single overflow class; the published `AttachmentObject.id` output pattern already uses the same expression, so tightening only the request side would split them, and JSON Schema has no clean numeric bound for a decimal held in a string. Not worth an issue. - The source-enum-equals-runtime-set test does not independently verify the reverse direction. Both `source_values()` and `parse_region_source()` are derived from the same clap `ValueEnum` impl, so the residual drift risk is verified low; strengthening test independence is optional hardening beyond issue #178's acceptance criteria.

natsukium added 1 commit 2026-09-07 22:01:29 +09:00

cli: enumerate the bridge's finite request params ... efc53cc5e2

`source` and `attachment` were bare strings in the published request
grammar, so a consumer could validate a line locally and still be
answered `malformed_request` by a live bridge: the bundle promised more
than the runtime honors. Both now carry the value set the runtime
parses — `source` read off the `--source` ValueEnum so the two cannot
drift, `attachment` the decimal pattern the roster prints — and the
bridge charges a bad attachment to the request's spelling rather than
to the request, matching the rule the schema now states.

Refs #178

natsukium merged commit 1d410669d4 into main 2026-09-07 22:27:01 +09:00

natsukium deleted branch fix/bridge-schema-enums-178 2026-09-07 22:27:01 +09:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

priority/P0

Must be resolved before the v0.1.0 tag

  

priority/P1

Must be settled before the first public contract freezes

  

priority/P2

Explicitly deferred until after v0.1.0

  

release/v0.1.0

Work tracked for the first tagged release

  

status/blocked

Cannot start now: waits on an upstream release, another issue, or a recorded revisit trigger

  

status/planned

Triaged with a source-grounded plan and a passed pi review; ready to implement

  

type/bug

Shipped behavior that contradicts the docs or the code's own intent; needs a product code change

  

type/design

An open scope or trade-off question; needs a recorded decision in the owning explanation doc before code

  

type/test-gap

Documented or reviewed behavior that no test pins; usually split from a review finding, needs no product code change

  

type/tracker

Parent issue that tracks child work

No labels

priority/P0

priority/P1

priority/P2

release/v0.1.0

status/blocked

status/planned

type/bug

type/design

type/test-gap

type/tracker

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

natsukium/felis!204

No description provided.