grid: splice the row object into the JSON frame view #208

Merged

natsukium merged 1 commit from fix/row-json-splice-193 into main 2026-09-07 23:56:03 +09:00

Conversation 0 Commits 1 Files changed 3 +141 -14

natsukium commented 2026-09-07 23:35:05 +09:00

Owner

Copy link

Fixes #193.

RowPayload is #[serde(transparent)] over its bytes, so a GridMsg::RowDelta whose payloads carry
encode_row_json output was serialized as an array of the byte values of the row's JSON text — roughly
3.5x the size for a 48-column row, and unreadable without a second decode, in every consumer
felis-grid::transcode exists to serve.

body_to_json now splices the decoded row object into the frame view, and the inverse direction accepts
only that spliced object: a byte-array row is refused rather than admitted as a second valid row shape.
The splice lives in felis-grid rather than in felis-protocol, whose serde impl stays transparent — a
serializer-dependent impl there would resurrect the human-readable branch that was dropped for reaching
no live path.

Doc cascade: CHANGELOG.md (Fixed) records the user-visible shape change for out-of-repo readers of the
JSON frame view; no reference or explanation page states the row's JSON encoding, so nothing else moved.

Verified: just check green (fmt, clippy, nextest, deny, proto-compat); reviewed by pi sol + pi luna;
docs proofread by Gemini gemini-3.8-flash-high

Deferred

• No test for a non-RowDelta Grid message (e.g. RehydrateBegin) through the new splice branches —
  both branches are gated on the RowDelta shape, and the existing dispatch test plus the felis-cli
  bridge suite exercise the untouched path; an added case would be redundant coverage.
• The byte-array rejection test doesn't distinguish a shape-check failure from a content-decode failure —
  the finding itself verifies the test already pins the correct (structural, any-array) rejection path; a
  more faithful fixture would strengthen the story but changes no pass/fail outcome.
• a_byte_array_row_payload_is_rejected exercises the pure shape check rather than a decode-based
  rejection — the same test and the same cosmetic gap as the note above; merged into that class.

Fixes #193. `RowPayload` is `#[serde(transparent)]` over its bytes, so a `GridMsg::RowDelta` whose payloads carry `encode_row_json` output was serialized as an array of the byte values of the row's JSON text — roughly 3.5x the size for a 48-column row, and unreadable without a second decode, in every consumer `felis-grid::transcode` exists to serve. `body_to_json` now splices the decoded row object into the frame view, and the inverse direction accepts only that spliced object: a byte-array row is refused rather than admitted as a second valid row shape. The splice lives in `felis-grid` rather than in `felis-protocol`, whose serde impl stays transparent — a serializer-dependent impl there would resurrect the human-readable branch that was dropped for reaching no live path. Doc cascade: `CHANGELOG.md` (Fixed) records the user-visible shape change for out-of-repo readers of the JSON frame view; no reference or explanation page states the row's JSON encoding, so nothing else moved. Verified: just check green (fmt, clippy, nextest, deny, proto-compat); reviewed by pi sol + pi luna; docs proofread by Gemini gemini-3.8-flash-high ## Deferred - No test for a non-`RowDelta` `Grid` message (e.g. `RehydrateBegin`) through the new splice branches — both branches are gated on the `RowDelta` shape, and the existing dispatch test plus the felis-cli bridge suite exercise the untouched path; an added case would be redundant coverage. - The byte-array rejection test doesn't distinguish a shape-check failure from a content-decode failure — the finding itself verifies the test already pins the correct (structural, any-array) rejection path; a more faithful fixture would strengthen the story but changes no pass/fail outcome. - `a_byte_array_row_payload_is_rejected` exercises the pure shape check rather than a decode-based rejection — the same test and the same cosmetic gap as the note above; merged into that class.

natsukium added 1 commit 2026-09-07 23:35:05 +09:00

grid: splice the row object into the JSON frame view ... 81fb8973bd

`RowPayload` is `#[serde(transparent)]` over its bytes, so serializing a
`GridMsg::RowDelta` whose payloads hold `encode_row_json` output re-encoded
the row's JSON text as an array of byte values: 3.5x the size for a 48-column
row, and unreadable without a second decode, in every consumer the module
exists to serve.

The splice lives here rather than in `felis-protocol`, whose serde impl
stays transparent: a serializer-dependent impl there would resurrect the
human-readable branch that was dropped for reaching no live path. The inverse
refuses a byte-array row instead of accepting it, so the JSON view has one row
shape rather than two.

Refs #193

natsukium merged commit 242b773620 into main 2026-09-07 23:56:03 +09:00

natsukium deleted branch fix/row-json-splice-193 2026-09-07 23:56:03 +09:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

priority/P0

Must be resolved before the v0.1.0 tag

  

priority/P1

Must be settled before the first public contract freezes

  

priority/P2

Explicitly deferred until after v0.1.0

  

release/v0.1.0

Work tracked for the first tagged release

  

status/blocked

Cannot start now: waits on an upstream release, another issue, or a recorded revisit trigger

  

status/planned

Triaged with a source-grounded plan and a passed pi review; ready to implement

  

type/bug

Shipped behavior that contradicts the docs or the code's own intent; needs a product code change

  

type/design

An open scope or trade-off question; needs a recorded decision in the owning explanation doc before code

  

type/test-gap

Documented or reviewed behavior that no test pins; usually split from a review finding, needs no product code change

  

type/tracker

Parent issue that tracks child work

No labels

priority/P0

priority/P1

priority/P2

release/v0.1.0

status/blocked

status/planned

type/bug

type/design

type/test-gap

type/tracker

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

natsukium/felis!208

No description provided.