grid: implement DECCARA and DECRARA #210

Merged

natsukium merged 2 commits from feat/deccara-decrara-188 into main 2026-09-08 00:54:43 +09:00

Conversation 0 Commits 2 Files changed 9 +515 -17

natsukium commented 2026-09-08 00:39:38 +09:00

Owner

Copy link

Fixes #188.

Implements the rectangular attribute-change operations DECCARA (CSI ... $r) and DECRARA
(CSI ... $t) in felis-grid: DECCARA sets the listed SGR attributes over the rectangle,
DECRARA toggles (reverses) them. Both honor DECSACE — the rectangle vs. stream selection
mode — and resolve their coordinates through the active margins and origin mode, matching
the existing rectangular ops (DECFRA/DECERA/DECCRA).

Coverage: insta snapshots per operation, the DECSACE stream/rectangle distinction, and the
margin/origin-mode cases, plus proptests alongside the existing rectangular-op properties.

Doc cascade: docs/reference/protocols/support-matrix.md and
docs/reference/protocols/vt-compliance.md flip DECCARA/DECRARA to supported, and
CHANGELOG.md records the user-visible addition.

Verified: just check green (fmt, clippy, nextest, deny, proto-compat); reviewed by pi luna

• pi sol; docs proofread by Gemini gemini-3.8-flash-high

Follow-ups

• #209 test: DECCARA/DECRARA attribute vocabulary mostly unpinned

Deferred

• esctest baseline ratchet — esctest2 ships no DECCARA/DECRARA cases, so there is nothing
  to ratchet; the floor stays at 491.
• DECSACE reset on DECSTR / RIS — pre-existing behavior untouched by this issue's
  criteria; the field was already persisted across resets for the DECRQSS round-trip.
• test: DECRARA proptest only exercises the on-to-off toggle direction — the XOR-vs-clear
  property this proptest fails to distinguish is already pinned by the paired snapshot
  test (deccara/decrara_reverses_listed_attributes_in_rectangle, which does exercise
  both toggle directions); strengthening the proptest itself is incremental hardening the
  acceptance criteria do not require.

Fixes #188. Implements the rectangular attribute-change operations DECCARA (CSI ... $r) and DECRARA (CSI ... $t) in `felis-grid`: DECCARA sets the listed SGR attributes over the rectangle, DECRARA toggles (reverses) them. Both honor DECSACE — the rectangle vs. stream selection mode — and resolve their coordinates through the active margins and origin mode, matching the existing rectangular ops (DECFRA/DECERA/DECCRA). Coverage: insta snapshots per operation, the DECSACE stream/rectangle distinction, and the margin/origin-mode cases, plus proptests alongside the existing rectangular-op properties. Doc cascade: `docs/reference/protocols/support-matrix.md` and `docs/reference/protocols/vt-compliance.md` flip DECCARA/DECRARA to supported, and `CHANGELOG.md` records the user-visible addition. Verified: just check green (fmt, clippy, nextest, deny, proto-compat); reviewed by pi luna + pi sol; docs proofread by Gemini gemini-3.8-flash-high ## Follow-ups - #209 test: DECCARA/DECRARA attribute vocabulary mostly unpinned ## Deferred - esctest baseline ratchet — esctest2 ships no DECCARA/DECRARA cases, so there is nothing to ratchet; the floor stays at 491. - DECSACE reset on DECSTR / RIS — pre-existing behavior untouched by this issue's criteria; the field was already persisted across resets for the DECRQSS round-trip. - test: DECRARA proptest only exercises the on-to-off toggle direction — the XOR-vs-clear property this proptest fails to distinguish is already pinned by the paired snapshot test (`deccara/decrara_reverses_listed_attributes_in_rectangle`, which does exercise both toggle directions); strengthening the proptest itself is incremental hardening the acceptance criteria do not require.

natsukium added 2 commits 2026-09-08 00:39:38 +09:00

grid: implement DECCARA and DECRARA ... 00779fc2df

The rectangular-editing family was complete except for the attribute
pair, which left a program no way to restyle an area it had already
drawn: the alternative is redrawing the text under a new pen, which
loses whatever the cells carried.

Both operations merge into the cells rather than replacing the pen, so
colors, hyperlinks and the DECSCA / SPA protection bits survive; the
reachable set is xterm's ALL_ATTRS. DECSACE stops being inert with
them: it was already parsed and stored for the DECRQSS round-trip, and
it is the extent selector these two — and only these two — branch on.

Refs #188

docs: record DECCARA / DECRARA support ... da9290985e

The support matrix carried the pair as the family's one unimplemented
row, and the compliance page still told readers DECSACE was inert.

Refs #188

natsukium merged commit da9290985e into main 2026-09-08 00:54:43 +09:00

natsukium deleted branch feat/deccara-decrara-188 2026-09-08 00:54:43 +09:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

priority/P0

Must be resolved before the v0.1.0 tag

  

priority/P1

Must be settled before the first public contract freezes

  

priority/P2

Explicitly deferred until after v0.1.0

  

release/v0.1.0

Work tracked for the first tagged release

  

status/blocked

Cannot start now: waits on an upstream release, another issue, or a recorded revisit trigger

  

status/planned

Triaged with a source-grounded plan and a passed pi review; ready to implement

  

type/bug

Shipped behavior that contradicts the docs or the code's own intent; needs a product code change

  

type/design

An open scope or trade-off question; needs a recorded decision in the owning explanation doc before code

  

type/test-gap

Documented or reviewed behavior that no test pins; usually split from a review finding, needs no product code change

  

type/tracker

Parent issue that tracks child work

No labels

priority/P0

priority/P1

priority/P2

release/v0.1.0

status/blocked

status/planned

type/bug

type/design

type/test-gap

type/tracker

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

natsukium/felis!210

No description provided.