natsukium/felis
Watch
1
Code Issues 27 Pull requests 1 Projects Releases Packages Wiki Activity Actions

grid: pin the refused color spec at the OSC dispatch layer #216

Merged
natsukium merged 1 commit from issue-201-refused-color-spec into main 2026-09-08 02:32:52 +09:00
Conversation 0 Commits 1 Files changed 1 +61
natsukium commented 2026-09-08 01:52:23 +09:00
Owner
Copy link

Closes #201.

Adds two tests in felis-grid's osc_dispatch/tests.rs that pin the documented dispatch-level behavior: a colorimetric (CIELab, TekHVC, CIEXYZ, CIELuv) or rgbi: spec through OSC 4, OSC 5 and OSC 10-12 leaves the previously set slot or override in place and emits no reply. The palette test reads the slot back through the ? query path so the preserved value is observed on the wire, not just in the override map.

The OSC 13-19 half of the issue was already pinned by tolerated_osc_families_leave_no_state_and_no_reply (landed in 23e50f22), so no new test for it.

cargo test -p felis-grid --lib refused_spec and cargo clippy -p felis-grid --all-targets -D warnings pass.

Closes #201. Adds two tests in `felis-grid`'s `osc_dispatch/tests.rs` that pin the documented dispatch-level behavior: a colorimetric (`CIELab`, `TekHVC`, `CIEXYZ`, `CIELuv`) or `rgbi:` spec through OSC 4, OSC 5 and OSC 10-12 leaves the previously set slot or override in place and emits no reply. The palette test reads the slot back through the `?` query path so the preserved value is observed on the wire, not just in the override map. The OSC 13-19 half of the issue was already pinned by `tolerated_osc_families_leave_no_state_and_no_reply` (landed in 23e50f22), so no new test for it. `cargo test -p felis-grid --lib refused_spec` and `cargo clippy -p felis-grid --all-targets -D warnings` pass.
natsukium force-pushed issue-201-refused-color-spec from 09e41a6052
Some checks failed
fuzz / cargo fuzz nightly long-run (push) Has been skipped
Details
darwin / detect relevant changes (push) Successful in 3s
Details
darwin / darwin docs-only no-op (push) Has been skipped
Details
darwin / build felis (aarch64-darwin) (push) Successful in 50s
Details
fuzz / cargo fuzz smoke (per target) (push) Successful in 1m20s
Details
pr / nix flake check (push) Successful in 23s
Details
pr / cargo build / clippy / test / deny (push) Successful in 2m20s
Details
pr / wire schema is compatible with the base (push) Successful in 14s
Details
pr / frontend smoke (x86_64-linux) (push) Successful in 1m4s
Details
windows / detect relevant changes (push) Successful in 3s
Details
windows / windows docs-only no-op (push) Has been skipped
Details
pr / publish felis (x86_64-linux) (push) Successful in 16s
Details
windows / cargo clippy (Windows cross) (push) Successful in 32s
Details
windows / cargo nextest (Windows) (push) Successful in 5m33s
Details
windows / frontend smoke (Windows) (push) Successful in 2m30s
Details
windows / package felis (x86_64-pc-windows-msvc) (push) Successful in 2m23s
Details
darwin / detect relevant changes (pull_request) Has been cancelled
Details
darwin / build felis (aarch64-darwin) (pull_request) Has been cancelled
Details
darwin / darwin docs-only no-op (pull_request) Has been cancelled
Details
pr / nix flake check (pull_request) Has been cancelled
Details
pr / cargo build / clippy / test / deny (pull_request) Has been cancelled
Details
pr / wire schema is compatible with the base (pull_request) Has been cancelled
Details
pr / frontend smoke (x86_64-linux) (pull_request) Has been cancelled
Details
pr / publish felis (x86_64-linux) (pull_request) Has been cancelled
Details
windows / detect relevant changes (pull_request) Has been cancelled
Details
windows / cargo clippy (Windows cross) (pull_request) Has been cancelled
Details
windows / cargo nextest (Windows) (pull_request) Has been cancelled
Details
windows / frontend smoke (Windows) (pull_request) Has been cancelled
Details
windows / package felis (x86_64-pc-windows-msvc) (pull_request) Has been cancelled
Details
windows / windows docs-only no-op (pull_request) Has been cancelled
Details
to 7d00372246
Some checks failed
bench / Criterion full-suite snapshot (pull_request) Has been skipped
Details
bench / Criterion regression gate (pull_request) Has been cancelled
Details
darwin / detect relevant changes (pull_request) Has been cancelled
Details
darwin / build felis (aarch64-darwin) (pull_request) Has been cancelled
Details
darwin / darwin docs-only no-op (pull_request) Has been cancelled
Details
fuzz / cargo fuzz smoke (per target) (pull_request) Has been cancelled
Details
pr / nix flake check (pull_request) Has been cancelled
Details
pr / cargo build / clippy / test / deny (pull_request) Has been cancelled
Details
pr / wire schema is compatible with the base (pull_request) Has been cancelled
Details
pr / frontend smoke (x86_64-linux) (pull_request) Has been cancelled
Details
pr / publish felis (x86_64-linux) (pull_request) Has been cancelled
Details
fuzz / cargo fuzz nightly long-run (pull_request) Has been skipped
Details
windows / detect relevant changes (pull_request) Has been cancelled
Details
windows / cargo clippy (Windows cross) (pull_request) Has been cancelled
Details
windows / cargo nextest (Windows) (pull_request) Has been cancelled
Details
windows / frontend smoke (Windows) (pull_request) Has been cancelled
Details
windows / package felis (x86_64-pc-windows-msvc) (pull_request) Has been cancelled
Details
windows / windows docs-only no-op (pull_request) Has been cancelled
Details
2026-09-08 01:52:37 +09:00 Compare
natsukium force-pushed issue-201-refused-color-spec from 7d00372246
Some checks failed
bench / Criterion full-suite snapshot (pull_request) Has been skipped
Details
bench / Criterion regression gate (pull_request) Has been cancelled
Details
darwin / detect relevant changes (pull_request) Has been cancelled
Details
darwin / build felis (aarch64-darwin) (pull_request) Has been cancelled
Details
darwin / darwin docs-only no-op (pull_request) Has been cancelled
Details
fuzz / cargo fuzz smoke (per target) (pull_request) Has been cancelled
Details
pr / nix flake check (pull_request) Has been cancelled
Details
pr / cargo build / clippy / test / deny (pull_request) Has been cancelled
Details
pr / wire schema is compatible with the base (pull_request) Has been cancelled
Details
pr / frontend smoke (x86_64-linux) (pull_request) Has been cancelled
Details
pr / publish felis (x86_64-linux) (pull_request) Has been cancelled
Details
fuzz / cargo fuzz nightly long-run (pull_request) Has been skipped
Details
windows / detect relevant changes (pull_request) Has been cancelled
Details
windows / cargo clippy (Windows cross) (pull_request) Has been cancelled
Details
windows / cargo nextest (Windows) (pull_request) Has been cancelled
Details
windows / frontend smoke (Windows) (pull_request) Has been cancelled
Details
windows / package felis (x86_64-pc-windows-msvc) (pull_request) Has been cancelled
Details
windows / windows docs-only no-op (pull_request) Has been cancelled
Details
to e6ac50a0cd
Some checks failed
bench / Criterion full-suite snapshot (pull_request) Has been skipped
Details
fuzz / cargo fuzz nightly long-run (pull_request) Has been skipped
Details
bench / Criterion regression gate (pull_request) Failing after 2m30s
Details
darwin / detect relevant changes (pull_request) Successful in 3s
Details
darwin / darwin docs-only no-op (pull_request) Has been skipped
Details
darwin / build felis (aarch64-darwin) (pull_request) Successful in 50s
Details
fuzz / cargo fuzz smoke (per target) (pull_request) Successful in 1m46s
Details
pr / nix flake check (pull_request) Successful in 40s
Details
pr / cargo build / clippy / test / deny (pull_request) Successful in 2m54s
Details
pr / frontend smoke (x86_64-linux) (pull_request) Successful in 1m7s
Details
pr / publish felis (x86_64-linux) (pull_request) Has been skipped
Details
windows / windows docs-only no-op (pull_request) Has been skipped
Details
pr / wire schema is compatible with the base (pull_request) Successful in 15s
Details
windows / detect relevant changes (pull_request) Successful in 3s
Details
windows / cargo nextest (Windows) (pull_request) Successful in 6m15s
Details
windows / frontend smoke (Windows) (pull_request) Successful in 2m45s
Details
windows / package felis (x86_64-pc-windows-msvc) (pull_request) Has been skipped
Details
windows / cargo clippy (Windows cross) (pull_request) Successful in 22s
Details
2026-09-08 01:52:58 +09:00 Compare
natsukium deleted branch issue-201-refused-color-spec 2026-09-08 02:32:52 +09:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
priority/P0
Must be resolved before the v0.1.0 tag

  
priority/P1
Must be settled before the first public contract freezes

  
priority/P2
Explicitly deferred until after v0.1.0

  
release/v0.1.0
Work tracked for the first tagged release

  
status/blocked
Cannot start now: waits on an upstream release, another issue, or a recorded revisit trigger

  
status/planned
Triaged with a source-grounded plan and a passed pi review; ready to implement

  
type/bug
Shipped behavior that contradicts the docs or the code's own intent; needs a product code change

  
type/design
An open scope or trade-off question; needs a recorded decision in the owning explanation doc before code

  
type/test-gap
Documented or reviewed behavior that no test pins; usually split from a review finding, needs no product code change

  
type/tracker
Parent issue that tracks child work

No labels
priority/P0
priority/P1
priority/P2
release/v0.1.0
status/blocked
status/planned
type/bug
type/design
type/test-gap
type/tracker
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
natsukium/felis!216
No description provided.