grid: pin every DECCARA / DECRARA selector #217

Merged

natsukium merged 1 commit from issue-209-rect-attr-vocabulary into main 2026-09-08 02:33:00 +09:00

Conversation 0 Commits 1 Files changed 1 +107

natsukium commented 2026-09-08 01:54:16 +09:00

Owner

Copy link

Closes #209.

Adds four table-driven tests to crates/felis-grid/tests/snapshot_csi.rs that walk every selector AttrEdit::from_params and reverse_attr_masks map (1-9, 21, 22-29) for both DECCARA and DECRARA, plus DECCARA's own 4:n colon form (4:3 lands UnderlineStyle::Curly, 4:0 clears underline and consumes the shape argument).

Mutation check: with 2 => FAINT swapped to STRIKETHROUGH in editing.rs, the old suite stayed green and deccara_each_on_selector_sets_exactly_its_attribute now fails on selector 2.

cargo test -p felis-grid --test snapshot_csi and cargo clippy -p felis-grid --all-targets -D warnings pass.

Closes #209. Adds four table-driven tests to `crates/felis-grid/tests/snapshot_csi.rs` that walk every selector `AttrEdit::from_params` and `reverse_attr_masks` map (1-9, 21, 22-29) for both DECCARA and DECRARA, plus DECCARA's own `4:n` colon form (`4:3` lands `UnderlineStyle::Curly`, `4:0` clears underline and consumes the shape argument). Mutation check: with `2 => FAINT` swapped to `STRIKETHROUGH` in `editing.rs`, the old suite stayed green and `deccara_each_on_selector_sets_exactly_its_attribute` now fails on selector 2. `cargo test -p felis-grid --test snapshot_csi` and `cargo clippy -p felis-grid --all-targets -D warnings` pass.

natsukium added 1 commit 2026-09-08 01:54:16 +09:00

grid: pin every DECCARA / DECRARA selector ... a169056079

The rectangle attribute suites exercised only bold, underline, reverse
and the 22/24 clear pair, so a swapped or dropped arm for faint,
italic, blink, conceal, strikethrough or the remaining clear aliases
passed the full suite (checked by swapping FAINT for STRIKETHROUGH:
no test failed). Four table-driven tests now walk the whole selector
vocabulary for both operations, including DECCARA's own `4:n` colon
form, which was only pinned through DECRARA.

Closes #209.

Assisted-by: Claude Code:Fable 5.1

natsukium merged commit 8962b5957d into main 2026-09-08 02:33:00 +09:00

natsukium deleted branch issue-209-rect-attr-vocabulary 2026-09-08 02:33:00 +09:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

priority/P0

Must be resolved before the v0.1.0 tag

  

priority/P1

Must be settled before the first public contract freezes

  

priority/P2

Explicitly deferred until after v0.1.0

  

release/v0.1.0

Work tracked for the first tagged release

  

status/blocked

Cannot start now: waits on an upstream release, another issue, or a recorded revisit trigger

  

status/planned

Triaged with a source-grounded plan and a passed pi review; ready to implement

  

type/bug

Shipped behavior that contradicts the docs or the code's own intent; needs a product code change

  

type/design

An open scope or trade-off question; needs a recorded decision in the owning explanation doc before code

  

type/test-gap

Documented or reviewed behavior that no test pins; usually split from a review finding, needs no product code change

  

type/tracker

Parent issue that tracks child work

No labels

priority/P0

priority/P1

priority/P2

release/v0.1.0

status/blocked

status/planned

type/bug

type/design

type/test-gap

type/tracker

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

natsukium/felis!217

No description provided.