test: cover every shell in the finite-option-values assertion #227

Merged

natsukium merged 1 commit from issue-220 into main 2026-09-08 20:56:12 +09:00

Conversation 0 Commits 1 Files changed 1 +37 -9

natsukium commented 2026-09-08 20:21:47 +09:00

Owner

Copy link

docs/reference/cli.md states that --format and sessions capture --source complete to their listed values in every generated script, but the only test behind that sentence asserted three zsh literals against script(Shell::Zsh). The claim is true today in all three shells; the gap is that nothing outside zsh is exercised, so a later hide_possible_values or a bash/fish overlay that rewrites those specs would leave the doc false with the suite still green.

every_shell_script_offers_the_finite_option_values now loops the assertion over bash, zsh and fish, deriving each shell's own candidate spelling from the same value lists: bash's -W "human json", zsh's :FORMAT:(human json), and fish's newline-separated -a "human\t''...". The doc sentence and the test now cover the same three shells.

Test-only change: no behavior, docs, or wire surface moves, so no CHANGELOG entry.

Fixes #220

`docs/reference/cli.md` states that `--format` and `sessions capture --source` complete to their listed values in *every* generated script, but the only test behind that sentence asserted three zsh literals against `script(Shell::Zsh)`. The claim is true today in all three shells; the gap is that nothing outside zsh is exercised, so a later `hide_possible_values` or a bash/fish overlay that rewrites those specs would leave the doc false with the suite still green. `every_shell_script_offers_the_finite_option_values` now loops the assertion over bash, zsh and fish, deriving each shell's own candidate spelling from the same value lists: bash's `-W "human json"`, zsh's `:FORMAT:(human json)`, and fish's newline-separated `-a "human\t''..."`. The doc sentence and the test now cover the same three shells. Test-only change: no behavior, docs, or wire surface moves, so no CHANGELOG entry. Fixes #220

natsukium added 1 commit 2026-09-08 20:21:47 +09:00

test: cover every shell in the finite-option-values assertion ... 9b1cdb44e8

`docs/reference/cli.md` promises that `--format` and `sessions capture
--source` complete to their listed values in every generated script, but
only zsh was exercised. A later `hide_possible_values`, or a bash/fish
overlay that rewrites those specs, would falsify the sentence with the
suite still green. Loop the assertion over bash, zsh and fish with each
shell's own candidate spelling so the doc claim and the test cover the
same ground.

Assisted-by: Claude Code

natsukium merged commit 9b1cdb44e8 into main 2026-09-08 20:56:12 +09:00

natsukium deleted branch issue-220 2026-09-08 20:56:12 +09:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

priority/P0

Must be resolved before the v0.1.0 tag

  

priority/P1

Must be settled before the first public contract freezes

  

priority/P2

Explicitly deferred until after v0.1.0

  

release/v0.1.0

Work tracked for the first tagged release

  

status/blocked

Cannot start now: waits on an upstream release, another issue, or a recorded revisit trigger

  

status/planned

Triaged with a source-grounded plan and a passed pi review; ready to implement

  

type/bug

Shipped behavior that contradicts the docs or the code's own intent; needs a product code change

  

type/design

An open scope or trade-off question; needs a recorded decision in the owning explanation doc before code

  

type/test-gap

Documented or reviewed behavior that no test pins; usually split from a review finding, needs no product code change

  

type/tracker

Parent issue that tracks child work

No labels

priority/P0

priority/P1

priority/P2

release/v0.1.0

status/blocked

status/planned

type/bug

type/design

type/test-gap

type/tracker

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

natsukium/felis!227

No description provided.