cli: build the bridge's source refusal from SourceArg #228

Merged

natsukium merged 1 commit from issue-221 into main 2026-09-08 21:57:51 +09:00

Conversation 0 Commits 1 Files changed 2 +63 -20

natsukium commented 2026-09-08 20:22:38 +09:00

Owner

Copy link

SourceArg is the single source vocabulary for --source, the completions, the man page and the published bridge schema, but parse_region_source (the wrapper the felis bridge path keeps) hand-spelled its refusal as expected visible, scrollback, command-output, or last-command. Renaming or adding a variant would update every other consumer automatically while the bridge's refusal kept naming the old four, telling a machine client to send a spelling the parser now rejects, with the whole suite still green. The refusal now builds its list from SourceArg::value_variants() through a new source_names() helper, which cli_schema reads too, so the published enum, the parser and the refusal share one source. The message text is byte-identical for today's vocabulary.

Tests: every_source_spelling_round_trips_through_parse_region_source pins that every advertised spelling parses into its own RegionSource (and that no variant is hidden from the advertised list); the_source_refusal_names_exactly_the_current_vocabulary pins the refusal's exact text plus the presence of every current variant name, so a rename that the message could not follow trips a test.

just check passes in full (3429 tests, clippy, fmt, deny, proto-compat, release self-test).

Fixes #221

`SourceArg` is the single `source` vocabulary for `--source`, the completions, the man page and the published bridge schema, but `parse_region_source` (the wrapper the `felis bridge` path keeps) hand-spelled its refusal as `expected visible, scrollback, command-output, or last-command`. Renaming or adding a variant would update every other consumer automatically while the bridge's refusal kept naming the old four, telling a machine client to send a spelling the parser now rejects, with the whole suite still green. The refusal now builds its list from `SourceArg::value_variants()` through a new `source_names()` helper, which `cli_schema` reads too, so the published enum, the parser and the refusal share one source. The message text is byte-identical for today's vocabulary. Tests: `every_source_spelling_round_trips_through_parse_region_source` pins that every advertised spelling parses into its own `RegionSource` (and that no variant is hidden from the advertised list); `the_source_refusal_names_exactly_the_current_vocabulary` pins the refusal's exact text plus the presence of every current variant name, so a rename that the message could not follow trips a test. `just check` passes in full (3429 tests, clippy, fmt, deny, proto-compat, release self-test). Fixes #221

natsukium added 1 commit 2026-09-08 20:22:38 +09:00

cli: build the bridge's source refusal from SourceArg ... dd06d0c079

`SourceArg` is the one `source` vocabulary, but the bridge path's
`parse_region_source` hand-spelled its refusal. Renaming or adding a
variant updated `--help`, the completions, the man page and the
published bridge schema while the refusal kept naming the old four,
telling a machine client to send a spelling the parser now rejects,
and no test at HEAD covered the wrapper, so the suite stayed green.

The names now come off `value_variants()` through `source_names()`,
which the bridge schema also reads, so the three consumers cannot
disagree. The message text is unchanged for today's vocabulary.

Assisted-by: Claude Code

natsukium force-pushed issue-221 from dd06d0c079 to 7a017a6df8 2026-09-08 20:55:20 +09:00 Compare

natsukium merged commit 2ba539d29e into main 2026-09-08 21:57:51 +09:00

natsukium deleted branch issue-221 2026-09-08 21:57:51 +09:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

priority/P0

Must be resolved before the v0.1.0 tag

  

priority/P1

Must be settled before the first public contract freezes

  

priority/P2

Explicitly deferred until after v0.1.0

  

release/v0.1.0

Work tracked for the first tagged release

  

status/blocked

Cannot start now: waits on an upstream release, another issue, or a recorded revisit trigger

  

status/planned

Triaged with a source-grounded plan and a passed pi review; ready to implement

  

type/bug

Shipped behavior that contradicts the docs or the code's own intent; needs a product code change

  

type/design

An open scope or trade-off question; needs a recorded decision in the owning explanation doc before code

  

type/test-gap

Documented or reviewed behavior that no test pins; usually split from a review finding, needs no product code change

  

type/tracker

Parent issue that tracks child work

No labels

priority/P0

priority/P1

priority/P2

release/v0.1.0

status/blocked

status/planned

type/bug

type/design

type/test-gap

type/tracker

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

natsukium/felis!228

No description provided.