test: pin DECSET 2048 through the real run-loop wiring #229

Merged

natsukium merged 1 commit from issue-213 into main 2026-09-08 21:32:52 +09:00

Conversation 0 Commits 1 Files changed 1 +37 -4

natsukium commented 2026-09-08 20:29:49 +09:00

Owner

Copy link

The mode-2048 daemon tests all reached the mode through a helper that built a throwaway felis_vt::Parser, advanced it on the locked grid, and then called sync_resize_notify_to_pty() by hand. That skips SessionTask::drain_effects, the only place that raises resize_notify_dirty when real PTY input is parsed, so the acceptance criterion "a set is answered with one immediate report" was never pinned against the path a real program actually takes.

This adds one test that runs the true production trigger: the capture child prints \033[?2048h as its own PTY output, and the test drives the real run_session loop, so the parse sink, drain_effects, and the end-of-loop reconcile are all in the chain. Deleting the resize_notify_dirty = true line in drain_effects fails this test and no other, which is the coverage the existing tests lacked.

capture_session gained an emit prologue parameter so the child can write a sequence after stty raw -echo has landed; the existing caller passes "".

just check passes.

Fixes #213

The mode-2048 daemon tests all reached the mode through a helper that built a throwaway `felis_vt::Parser`, advanced it on the locked grid, and then called `sync_resize_notify_to_pty()` by hand. That skips `SessionTask::drain_effects`, the only place that raises `resize_notify_dirty` when real PTY input is parsed, so the acceptance criterion "a set is answered with one immediate report" was never pinned against the path a real program actually takes. This adds one test that runs the true production trigger: the capture child prints `\033[?2048h` as its own PTY output, and the test drives the real `run_session` loop, so the parse sink, `drain_effects`, and the end-of-loop reconcile are all in the chain. Deleting the `resize_notify_dirty = true` line in `drain_effects` fails this test and no other, which is the coverage the existing tests lacked. `capture_session` gained an `emit` prologue parameter so the child can write a sequence after `stty raw -echo` has landed; the existing caller passes `""`. `just check` passes. Fixes #213

natsukium added 1 commit 2026-09-08 20:29:49 +09:00

test: drive DECSET 2048 through the run loop's own wiring ... ed780cec27

Every mode-2048 test built a throwaway parser, advanced it on the locked
grid, and called sync_resize_notify_to_pty by hand. That bypasses
SessionTask::drain_effects, which is the only thing that raises
resize_notify_dirty when real PTY input is parsed, so the promise "a set
is answered with one immediate report" was pinned nowhere against the
path a real program takes.

The capture child now emits the sequence itself and the test runs the
actual run_session loop, so the parse sink, drain_effects and the
end-of-loop reconcile are all in the chain. Dropping the
resize_notify_dirty assignment in drain_effects fails this test and no
other.

Assisted-by: Claude Code

natsukium merged commit 1996717572 into main 2026-09-08 21:32:52 +09:00

natsukium deleted branch issue-213 2026-09-08 21:32:52 +09:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

priority/P0

Must be resolved before the v0.1.0 tag

  

priority/P1

Must be settled before the first public contract freezes

  

priority/P2

Explicitly deferred until after v0.1.0

  

release/v0.1.0

Work tracked for the first tagged release

  

status/blocked

Cannot start now: waits on an upstream release, another issue, or a recorded revisit trigger

  

status/planned

Triaged with a source-grounded plan and a passed pi review; ready to implement

  

type/bug

Shipped behavior that contradicts the docs or the code's own intent; needs a product code change

  

type/design

An open scope or trade-off question; needs a recorded decision in the owning explanation doc before code

  

type/test-gap

Documented or reviewed behavior that no test pins; usually split from a review finding, needs no product code change

  

type/tracker

Parent issue that tracks child work

No labels

priority/P0

priority/P1

priority/P2

release/v0.1.0

status/blocked

status/planned

type/bug

type/design

type/test-gap

type/tracker

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

natsukium/felis!229

No description provided.