ci: give the macOS archive's launcher a resolved root #365

Merged

natsukium merged 1 commit from release/issue-360-launcher-path into main 2026-09-23 08:20:59 +09:00

Conversation 0 Commits 1 Files changed 2 +9 -2

natsukium commented 2026-09-23 07:59:35 +09:00

Owner

Copy link

The v0.1.0-rc.4 tag run (actions run 4221) got the macOS archive through the manifest, codesign --verify --strict --deep, the direct felis-client --version, the bin/felis launcher and the daemon spawn. The last check failed only on spelling: the launcher exec'd bin/../felis.app/Contents/MacOS/felis, so the daemon's command line was .../bin/../felis.app/Contents/MacOS/felis-daemon serve … and the smoke's prefix match against <tree>/felis.app/... did not recognize it.

The launcher now resolves the archive root with pwd -P before it execs (verified locally through a symlinked tree: the CLI sees a clean absolute path), and the smoke resolves the tree it was given the same way.

Refs #360. Only a tag run (v0.1.0-rc.5) exercises the darwin smoke itself.

The `v0.1.0-rc.4` tag run (actions run 4221) got the macOS archive through the manifest, `codesign --verify --strict --deep`, the direct `felis-client --version`, the `bin/felis` launcher and the daemon spawn. The last check failed only on spelling: the launcher exec'd `bin/../felis.app/Contents/MacOS/felis`, so the daemon's command line was `.../bin/../felis.app/Contents/MacOS/felis-daemon serve …` and the smoke's prefix match against `<tree>/felis.app/...` did not recognize it. The launcher now resolves the archive root with `pwd -P` before it execs (verified locally through a symlinked tree: the CLI sees a clean absolute path), and the smoke resolves the tree it was given the same way. Refs #360. Only a tag run (`v0.1.0-rc.5`) exercises the darwin smoke itself.

natsukium added 1 commit 2026-09-23 07:59:48 +09:00

ci: give the macOS archive's launcher a resolved root ... 88c86da503

The bin/felis launcher exec'd the CLI through `bin/../felis.app`, so
the CLI, and the client and daemon it spawns by the directory of its
own executable, all ran under a path carrying `..`. The tag run's smoke
compares the daemon's command line against the unpacked tree and did
not recognize that spelling, though every other step of the macOS
archive gate had passed. The launcher now resolves the archive root
with `pwd -P` before it execs, which also keeps the process list free
of `..` for a user who put the archive behind a symlink, and the smoke
resolves the tree it was given the same way.

Assisted-by: Claude Code

natsukium merged commit b861eb155d into main 2026-09-23 08:20:59 +09:00

natsukium deleted branch release/issue-360-launcher-path 2026-09-23 08:20:59 +09:00

natsukium referenced this pull request from a commit 2026-09-23 08:20:59 +09:00

ci: give the macOS archive's launcher a resolved root (#365)

natsukium referenced this pull request 2026-09-23 08:52:10 +09:00

release: ship runnable Linux and macOS binaries instead of identity text files #360

Commenting is not possible because the repository is archived.

Reviewers

No reviewers

Labels

Clear labels   

priority/P0

Must be resolved before the v0.1.0 tag

  

priority/P1

Must be settled before the first public contract freezes

  

priority/P2

Explicitly deferred until after v0.1.0

  

release/v0.1.0

Work tracked for the first tagged release

  

status/blocked

Cannot start now: waits on an upstream release, another issue, or a recorded revisit trigger

  

status/planned

Triaged with a source-grounded plan and a passed pi review; ready to implement

  

type/bug

Shipped behavior that contradicts the docs or the code's own intent; needs a product code change

  

type/design

An open scope or trade-off question; needs a recorded decision in the owning explanation doc before code

  

type/test-gap

Documented or reviewed behavior that no test pins; usually split from a review finding, needs no product code change

  

type/tracker

Parent issue that tracks child work

No labels

priority/P0

priority/P1

priority/P2

release/v0.1.0

status/blocked

status/planned

type/bug

type/design

type/test-gap

type/tracker

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

natsukium/felis!365

No description provided.