natsukium/felis
Archived
Watch
1
Code Issues 23 Pull requests Projects Releases 6 Packages Wiki Activity Actions

grid: let TableGc force a sweep, and sweep the row-cache test through it #432

Merged
natsukium merged 1 commit from render/sweep-through-tablegc into main 2026-09-25 11:08:53 +09:00
Conversation 0 Commits 1 Files changed 3 +37 -2
natsukium commented 2026-09-25 11:04:36 +09:00
Owner
Copy link

main's tests stopped compiling (E0624, gc_styles is private): #423 made ScreenBuffer::gc_styles crate-private so every sweep goes through the sealed TableGc/Sweepable path, while #424's row-cache property test still called it directly. Each PR was green against the main it was tested on; they were merged back to back.

  • TableGc::sweep sweeps both registries now, through the same sealed Sweepable owners and with the same threshold bookkeeping as maybe_sweep (the style threshold still floors at STYLE_INIT).
  • The row-cache test's GcStyles op sweeps through it.
  • New grid test: a forced sweep compacts below the threshold and the pen survives it.

Checks: cargo nextest run -p felis-grid table_gc (15/15), -p felis-render-wgpu row_cache (3/3), workspace clippy --all-targets --all-features -D warnings clean.

Review: pi (luna) on origin/main...HEAD: PASS, no findings.

main's tests stopped compiling (E0624, `gc_styles` is private): #423 made `ScreenBuffer::gc_styles` crate-private so every sweep goes through the sealed `TableGc`/`Sweepable` path, while #424's row-cache property test still called it directly. Each PR was green against the main it was tested on; they were merged back to back. - `TableGc::sweep` sweeps both registries now, through the same sealed `Sweepable` owners and with the same threshold bookkeeping as `maybe_sweep` (the style threshold still floors at `STYLE_INIT`). - The row-cache test's `GcStyles` op sweeps through it. - New grid test: a forced sweep compacts below the threshold and the pen survives it. Checks: `cargo nextest run -p felis-grid table_gc` (15/15), `-p felis-render-wgpu row_cache` (3/3), workspace clippy `--all-targets --all-features -D warnings` clean. Review: pi (luna) on `origin/main...HEAD`: PASS, no findings.
grid: let TableGc force a sweep, and sweep the row-cache test through it
Some checks failed
darwin / build felis (aarch64-darwin) (pull_request) Successful in 53s
Details
darwin / publish felis (aarch64-darwin) (pull_request) Has been skipped
Details
windows / detect relevant changes (pull_request) Successful in 13s
Details
bench / Criterion full-suite snapshot (pull_request) Has been skipped
Details
fuzz / cargo fuzz nightly long-run (pull_request) Has been skipped
Details
darwin / detect relevant changes (pull_request) Successful in 13s
Details
darwin / darwin docs-only no-op (pull_request) Has been skipped
Details
windows / windows docs-only no-op (pull_request) Has been skipped
Details
pr / nix flake check (pull_request) Has been cancelled
Details
bench / Criterion regression gate (pull_request) Has been cancelled
Details
pr / cargo build / clippy / test / deny (pull_request) Has been cancelled
Details
pr / wire schema is compatible with the base (pull_request) Has been cancelled
Details
pr / frontend smoke (x86_64-linux) (pull_request) Has been cancelled
Details
pr / publish felis (x86_64-linux) (pull_request) Has been cancelled
Details
fuzz / cargo fuzz smoke (per target) (pull_request) Has been cancelled
Details
windows / cargo clippy (Windows cross) (pull_request) Has been cancelled
Details
windows / cargo nextest (Windows) (pull_request) Has been cancelled
Details
windows / frontend smoke (Windows) (pull_request) Has been cancelled
Details
windows / package felis (x86_64-pc-windows-msvc) (pull_request) Has been cancelled
Details
042dda6fe3
 
main stopped compiling its tests: #423 made `ScreenBuffer::gc_styles`
crate-private so every sweep goes through `TableGc`, which re-establishes
the handles an owner holds outside its cells, while #424's row-cache
property test still called it directly to exercise a style compaction.
Each PR was green against the main it was tested on.

`TableGc::maybe_sweep` only sweeps past its threshold, which a test
cannot reach cheaply, so `TableGc::sweep` sweeps now and keeps the
threshold bookkeeping. It takes the same sealed `Sweepable` owners, so
the invariant #423 introduced still holds.

Assisted-by: Claude Code
natsukium deleted branch render/sweep-through-tablegc 2026-09-25 11:08:53 +09:00
Commenting is not possible because the repository is archived.
Reviewers
No reviewers
Labels
Clear labels   
priority/P0
Must be resolved before the v0.1.0 tag

  
priority/P1
Must be settled before the first public contract freezes

  
priority/P2
Explicitly deferred until after v0.1.0

  
release/v0.1.0
Work tracked for the first tagged release

  
status/blocked
Cannot start now: waits on an upstream release, another issue, or a recorded revisit trigger

  
status/planned
Triaged with a source-grounded plan and a passed pi review; ready to implement

  
type/bug
Shipped behavior that contradicts the docs or the code's own intent; needs a product code change

  
type/design
An open scope or trade-off question; needs a recorded decision in the owning explanation doc before code

  
type/test-gap
Documented or reviewed behavior that no test pins; usually split from a review finding, needs no product code change

  
type/tracker
Parent issue that tracks child work

No labels
priority/P0
priority/P1
priority/P2
release/v0.1.0
status/blocked
status/planned
type/bug
type/design
type/test-gap
type/tracker
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
natsukium/felis!432
No description provided.