natsukium/felis
Archived
Watch
1
Code Issues 23 Pull requests Projects Releases 6 Packages Wiki Activity Actions

docs: keep one requirement ID per requirement #435

Merged
natsukium merged 1 commit from docs/collapse-duplicate-reqs into main 2026-09-25 12:29:50 +09:00
Conversation 0 Commits 1 Files changed 3 +10 -12
natsukium commented 2026-09-25 11:49:56 +09:00
Owner
Copy link

docs/reference/spec.md stated two requirements twice. This keeps one ID per requirement and deletes the duplicate rows outright, with no pointer rows:

  • REQ-1003 (section K) duplicated REQ-1200 (section M, test acceptance criteria). REQ-1200 survives: it sits with the acceptance criteria that testing.md "Acceptance criteria" sources.
  • REQ-1204 (section M) restated REQ-407 (section E, text sizing). REQ-407 survives: it carries the discard-whole clause too.

The one code comment (felis-grid/src/editing.rs) and the one explanation citation (kitty-text-sizing.md) that named a deleted ID now name the survivor. No other in-repo reference exists (docs, skills, tests, fuzz, tools).

Closes #389

`docs/reference/spec.md` stated two requirements twice. This keeps one ID per requirement and deletes the duplicate rows outright, with no pointer rows: - REQ-1003 (section K) duplicated REQ-1200 (section M, test acceptance criteria). REQ-1200 survives: it sits with the acceptance criteria that testing.md "Acceptance criteria" sources. - REQ-1204 (section M) restated REQ-407 (section E, text sizing). REQ-407 survives: it carries the discard-whole clause too. The one code comment (`felis-grid/src/editing.rs`) and the one explanation citation (`kitty-text-sizing.md`) that named a deleted ID now name the survivor. No other in-repo reference exists (docs, skills, tests, fuzz, tools). Closes #389
docs: keep one requirement ID per requirement
Some checks failed
darwin / build felis (aarch64-darwin) (pull_request) Successful in 54s
Details
darwin / publish felis (aarch64-darwin) (pull_request) Has been skipped
Details
windows / detect relevant changes (pull_request) Successful in 14s
Details
windows / windows docs-only no-op (pull_request) Has been skipped
Details
windows / frontend smoke (Windows) (pull_request) Has been skipped
Details
windows / package felis (x86_64-pc-windows-msvc) (pull_request) Has been skipped
Details
bench / Criterion regression gate (pull_request) Failing after 2m23s
Details
fuzz / cargo fuzz smoke (per target) (pull_request) Successful in 1m54s
Details
pr / nix flake check (pull_request) Successful in 36s
Details
pr / cargo build / clippy / test / deny (pull_request) Successful in 1m54s
Details
pr / wire schema is compatible with the base (pull_request) Successful in 16s
Details
pr / frontend smoke (x86_64-linux) (pull_request) Successful in 1m31s
Details
pr / publish felis (x86_64-linux) (pull_request) Has been skipped
Details
windows / cargo nextest (Windows) (pull_request) Failing after 23m40s
Details
windows / cargo clippy (Windows cross) (pull_request) Successful in 13s
Details
bench / Criterion full-suite snapshot (pull_request) Has been skipped
Details
fuzz / cargo fuzz nightly long-run (pull_request) Has been skipped
Details
darwin / detect relevant changes (pull_request) Successful in 13s
Details
darwin / darwin docs-only no-op (pull_request) Has been skipped
Details
e90d47275f
 
The spec carried the 24-hour fuzz bar twice (REQ-1003 and REQ-1200, same
sources) and the sized-run round-trip twice (REQ-407 and REQ-1204). Two
IDs for one requirement drift independently: every fix has to find both
rows, and the audit that scoped the round-trip to "while every sized run
still fits" had to edit each of them.

The duplicates are deleted outright rather than kept as pointer rows, so
an ID never resolves to a row that states nothing. REQ-1200 survives for
the fuzz bar because it sits with the acceptance criteria that
testing.md "Acceptance criteria" sources; REQ-407 survives for the
round-trip because it sits with the text-sizing requirements and carries
the discard-whole clause REQ-1204 lacked. The one code comment and the
one explanation citation that named a deleted ID now name the survivor.

Assisted-by: Claude Code
natsukium deleted branch docs/collapse-duplicate-reqs 2026-09-25 12:29:51 +09:00
Commenting is not possible because the repository is archived.
Reviewers
No reviewers
Labels
Clear labels   
priority/P0
Must be resolved before the v0.1.0 tag

  
priority/P1
Must be settled before the first public contract freezes

  
priority/P2
Explicitly deferred until after v0.1.0

  
release/v0.1.0
Work tracked for the first tagged release

  
status/blocked
Cannot start now: waits on an upstream release, another issue, or a recorded revisit trigger

  
status/planned
Triaged with a source-grounded plan and a passed pi review; ready to implement

  
type/bug
Shipped behavior that contradicts the docs or the code's own intent; needs a product code change

  
type/design
An open scope or trade-off question; needs a recorded decision in the owning explanation doc before code

  
type/test-gap
Documented or reviewed behavior that no test pins; usually split from a review finding, needs no product code change

  
type/tracker
Parent issue that tracks child work

No labels
priority/P0
priority/P1
priority/P2
release/v0.1.0
status/blocked
status/planned
type/bug
type/design
type/test-gap
type/tracker
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
natsukium/felis!435
No description provided.