client-core: read an uppercase ASCII letter in a chord as the letter plus Shift #443

Merged

natsukium merged 4 commits from client-core/uppercase-letter-chords into main 2026-09-25 12:33:12 +09:00

Conversation 0 Commits 4 Files changed 4 +88 -8

natsukium commented 2026-09-25 12:12:32 +09:00

Owner

Copy link

A keymap chord written with an uppercase ASCII letter (shift+A) parsed without a warning but could never match: the client lifts every uppercase keypress to the lowercase letter plus Shift, while the parser kept A as written. Per the decision on the issue (option 1), the parser now folds the same way.

• Chord::from_str reads a single uppercase ASCII letter as its lowercase letter plus SHIFT: A, shift+A and shift+a are one chord. Unit tests and a proptest pin the fold.
• felis sessions send --key parses with the same grammar, so its key event now sends Shift plus a letter as the uppercase keystroke with that letter composed, as a keyboard (and the GUI) does. --key A keeps typing A, and --key shift+a now types A instead of a.
• docs/reference/keybindings.md chord grammar states the fold; CHANGELOG "Fixed" entries for the keymap and the CLI.

Closes #386

A keymap chord written with an uppercase ASCII letter (`shift+A`) parsed without a warning but could never match: the client lifts every uppercase keypress to the lowercase letter plus Shift, while the parser kept `A` as written. Per the decision on the issue (option 1), the parser now folds the same way. - `Chord::from_str` reads a single uppercase ASCII letter as its lowercase letter plus SHIFT: `A`, `shift+A` and `shift+a` are one chord. Unit tests and a proptest pin the fold. - `felis sessions send --key` parses with the same grammar, so its key event now sends Shift plus a letter as the uppercase keystroke with that letter composed, as a keyboard (and the GUI) does. `--key A` keeps typing `A`, and `--key shift+a` now types `A` instead of `a`. - `docs/reference/keybindings.md` chord grammar states the fold; CHANGELOG "Fixed" entries for the keymap and the CLI. Closes #386

natsukium added 3 commits 2026-09-25 12:12:32 +09:00

client-core: read an uppercase ASCII letter in a chord as the letter plus Shift ... ffc02f0a8b

The client lifts every uppercase ASCII keypress to its lowercase letter
plus SHIFT before the keymap lookup, but the chord parser stored `A` as
written, so a binding such as `shift+A` loaded without a warning and
could never match. Folding in the parser puts the written and the
pressed chord under one rule, and configs that already parse start
firing. Rejecting the spelling with a diagnostic was the alternative;
it would break configs that load today for a spelling whose meaning is
unambiguous.

`A`, `shift+A` and `shift+a` are now three spellings of one chord, so
the existing rule for two spellings in one section (the later-sorting
string wins) covers them.

Assisted-by: Claude Code

cli: send a shifted-letter --key chord as the uppercase keystroke ... e42506edf2

`felis sessions send --key` parses its chord with the keymap grammar,
which now reads `A` as `shift+a`. Building the key event from the
folded chord sent `a` as the key and the composed text, so `--key A`
typed a lowercase letter where it used to type `A`, and `shift+a` never
typed `A` at all. A keyboard reports Shift plus a letter as the
uppercase letter with that letter composed, which is what the GUI
forwards, so the CLI now does the same and the daemon encodes both
identically.

Assisted-by: Claude Code

cli: record the shifted-letter --key fix in the changelog ... 0c3dbace1b

The CLI now sends Shift plus a letter as the uppercase keystroke, which changes what `sessions send --key shift+a` types; that is user-visible CLI behavior, so it gets a Fixed entry.

Assisted-by: Claude Code

natsukium added 1 commit 2026-09-25 12:31:09 +09:00

Merge remote-tracking branch 'origin/main' into client-core/uppercase-letter-chords ... 6902bc0cf4

# Conflicts:
#	CHANGELOG.md

natsukium merged commit 08df935541 into main 2026-09-25 12:33:12 +09:00

natsukium deleted branch client-core/uppercase-letter-chords 2026-09-25 12:33:12 +09:00

natsukium referenced this pull request from a commit 2026-09-25 12:33:13 +09:00

client-core: read an uppercase ASCII letter in a chord as the letter plus Shift (#443)

Commenting is not possible because the repository is archived.

Reviewers

No reviewers

Labels

Clear labels   

priority/P0

Must be resolved before the v0.1.0 tag

  

priority/P1

Must be settled before the first public contract freezes

  

priority/P2

Explicitly deferred until after v0.1.0

  

release/v0.1.0

Work tracked for the first tagged release

  

status/blocked

Cannot start now: waits on an upstream release, another issue, or a recorded revisit trigger

  

status/planned

Triaged with a source-grounded plan and a passed pi review; ready to implement

  

type/bug

Shipped behavior that contradicts the docs or the code's own intent; needs a product code change

  

type/design

An open scope or trade-off question; needs a recorded decision in the owning explanation doc before code

  

type/test-gap

Documented or reviewed behavior that no test pins; usually split from a review finding, needs no product code change

  

type/tracker

Parent issue that tracks child work

No labels

priority/P0

priority/P1

priority/P2

release/v0.1.0

status/blocked

status/planned

type/bug

type/design

type/test-gap

type/tracker

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

natsukium/felis!443

No description provided.