ci: compare a tag's wire schema with the newest release's tag, not a committed copy #488

Merged

natsukium merged 1 commit from ci/drop-baseline-job into main 2026-09-26 15:41:29 +09:00

Conversation 0 Commits 1 Files changed 13 +133 -708

natsukium commented 2026-09-26 15:24:43 +09:00

Owner

Copy link

The tag path of the wire gate compared against a copy of the released felis.proto committed under proto-baseline/, and checked that copy byte for byte against the release asset. The released tag already holds those bytes. Maintaining the copy took a release job that pushed a branch and opened a PR with RELEASE_TOKEN, and because main is protected, every tag after a final release failed the gate until someone merged that PR.

• tools/proto/compat.py: on a tag (and on a null-sha push), ask the forge only which tag is the newest published final release, then run buf breaking against that tag's commit from the full-history checkout. If no final release is published, the gate passes. If the release tag is missing from the clone, the gate fails.
• The first-release acknowledgment is gone: it stood in for a missing committed baseline, and "no final release published" now carries that meaning.
• release.yml: the baseline job is removed; publish.py baseline and its tests are removed.
• Docs (testing, ipc reference and explanation, workspace) and the felis.proto comment updated; the explanation records the committed copy as the rejected alternative.

Verified: both self-tests pass (compat.py 57 cases, publish.py 12 cases), and a live tag-path run against this forge reports that no final release is published and exits 0.

This should land before v0.1.0-rc.9, so the rc exercises it together with the GitHub release mirror (#487).

The tag path of the wire gate compared against a copy of the released `felis.proto` committed under `proto-baseline/`, and checked that copy byte for byte against the release asset. The released tag already holds those bytes. Maintaining the copy took a release job that pushed a branch and opened a PR with `RELEASE_TOKEN`, and because `main` is protected, every tag after a final release failed the gate until someone merged that PR. - `tools/proto/compat.py`: on a tag (and on a null-sha push), ask the forge only which tag is the newest published final release, then run `buf breaking` against that tag's commit from the full-history checkout. If no final release is published, the gate passes. If the release tag is missing from the clone, the gate fails. - The `first-release` acknowledgment is gone: it stood in for a missing committed baseline, and "no final release published" now carries that meaning. - `release.yml`: the `baseline` job is removed; `publish.py baseline` and its tests are removed. - Docs (testing, ipc reference and explanation, workspace) and the `felis.proto` comment updated; the explanation records the committed copy as the rejected alternative. Verified: both self-tests pass (`compat.py` 57 cases, `publish.py` 12 cases), and a live tag-path run against this forge reports that no final release is published and exits 0. This should land before `v0.1.0-rc.9`, so the rc exercises it together with the GitHub release mirror (#487).

natsukium added 1 commit 2026-09-26 15:24:43 +09:00

ci: compare a tag's wire schema with the newest release's tag, not a committed copy ... cb512a8656

The tag path of the wire gate already asked the forge for the newest
published final release and then required a committed copy under
proto-baseline/ to match its felis.proto asset byte for byte. The tag
itself holds those bytes, so the copy was a second record to keep equal
to the first. Keeping it cost a release job that pushed a branch and
opened a pull request with RELEASE_TOKEN, and because main is protected
every tag after a final release stayed red until a human merged that
pull request.

The gate now asks the forge only which tag is the newest final release
and runs buf breaking against that tag's commit, which the full-history
checkout already carries. With no final release published there is
nothing to answer to, so the first-release acknowledgment that stood in
for a missing baseline goes too, along with the baseline job and the
publish.py subcommand behind it.

Assisted-by: Claude Code

natsukium force-pushed ci/drop-baseline-job from cb512a8656 to be58ecb8ee 2026-09-26 15:33:33 +09:00 Compare

natsukium merged commit 033f769455 into main 2026-09-26 15:41:29 +09:00

natsukium deleted branch ci/drop-baseline-job 2026-09-26 15:41:29 +09:00

natsukium referenced this pull request from a commit 2026-09-26 15:41:30 +09:00

ci: compare a tag's wire schema with the newest release's tag, not a committed copy (#488)

Commenting is not possible because the repository is archived.

Reviewers

No reviewers

Labels

Clear labels   

priority/P0

Must be resolved before the v0.1.0 tag

  

priority/P1

Must be settled before the first public contract freezes

  

priority/P2

Explicitly deferred until after v0.1.0

  

release/v0.1.0

Work tracked for the first tagged release

  

status/blocked

Cannot start now: waits on an upstream release, another issue, or a recorded revisit trigger

  

status/planned

Triaged with a source-grounded plan and a passed pi review; ready to implement

  

type/bug

Shipped behavior that contradicts the docs or the code's own intent; needs a product code change

  

type/design

An open scope or trade-off question; needs a recorded decision in the owning explanation doc before code

  

type/test-gap

Documented or reviewed behavior that no test pins; usually split from a review finding, needs no product code change

  

type/tracker

Parent issue that tracks child work

No labels

priority/P0

priority/P1

priority/P2

release/v0.1.0

status/blocked

status/planned

type/bug

type/design

type/test-gap

type/tracker

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

natsukium/felis!488

No description provided.