fix(protocol): acknowledge the ResourceReport repack against the merged tip #77

Merged

natsukium merged 1 commit from fix/wire-ack-rebased-tip into main 2026-09-04 18:07:27 +09:00

Conversation 0 Commits 1 Files changed 1 +9

natsukium commented 2026-09-04 18:02:44 +09:00

Owner

Copy link

The push-event wire gate on main (task 1633, commit 1690c960) failed: #26's acknowledgment in BREAKING.md names 40ff5dcf, but the branch merged onto 90a3cab4, past #48's Correlation break, and the gate does not inherit an acknowledgment across another break. Adds a second base: line against 90a3cab4 with the reason. Verified locally: the push simulation (GITHUB_EVENT_NAME=push PROTO_COMPAT_PUSH_BEFORE=90a3cab4) now passes, the PR-event simulation passes, and the self-test passes.

The push-event wire gate on main (task 1633, commit 1690c960) failed: #26's acknowledgment in BREAKING.md names 40ff5dcf, but the branch merged onto 90a3cab4, past #48's Correlation break, and the gate does not inherit an acknowledgment across another break. Adds a second `base:` line against 90a3cab4 with the reason. Verified locally: the push simulation (`GITHUB_EVENT_NAME=push PROTO_COMPAT_PUSH_BEFORE=90a3cab4`) now passes, the PR-event simulation passes, and the self-test passes.

natsukium added 1 commit 2026-09-04 18:02:44 +09:00

fix(protocol): acknowledge the ResourceReport repack against the merged tip ... 03d56ca774

The push-event wire gate on main failed after #26 landed: its
acknowledgment names the tip the branch was written against, but the
branch was rebase-merged past #48's Correlation break, and the gate
refuses to carry an acknowledgment across another break. The PR-event
check passed because it compares against the merge-base, which the
final rebase had moved to the new tip. Adding a second line against the
tip the merge actually happened on is the only way the push check can
pass without weakening the inheritance rule that keeps stale lines
inert.

natsukium merged commit 03d56ca774 into main 2026-09-04 18:07:27 +09:00

natsukium deleted branch fix/wire-ack-rebased-tip 2026-09-04 18:07:27 +09:00

natsukium referenced this pull request 2026-09-07 16:09:12 +09:00

[v0.1/Proto Review] Freeze protobuf and IPC contracts (7 issues) #52

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

priority/P0

Must be resolved before the v0.1.0 tag

  

priority/P1

Must be settled before the first public contract freezes

  

priority/P2

Explicitly deferred until after v0.1.0

  

release/v0.1.0

Work tracked for the first tagged release

  

status/blocked

Cannot start now: waits on an upstream release, another issue, or a recorded revisit trigger

  

status/planned

Triaged with a source-grounded plan and a passed pi review; ready to implement

  

type/bug

Shipped behavior that contradicts the docs or the code's own intent; needs a product code change

  

type/design

An open scope or trade-off question; needs a recorded decision in the owning explanation doc before code

  

type/test-gap

Documented or reviewed behavior that no test pins; usually split from a review finding, needs no product code change

  

type/tracker

Parent issue that tracks child work

No labels

priority/P0

priority/P1

priority/P2

release/v0.1.0

status/blocked

status/planned

type/bug

type/design

type/test-gap

type/tracker

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

natsukium/felis!77

No description provided.