test(daemon): let the exit waits race the create's publish #80

Merged

natsukium merged 1 commit from fix/held-row-publish-race-20 into main 2026-09-04 19:08:36 +09:00

Conversation 0 Commits 1 Files changed 1 +8 -4

natsukium commented 2026-09-04 18:58:13 +09:00

Owner

Copy link

Follow-up to #79, which turned main's cargo build / clippy / test / deny
job red on a load-sensitive test.

A create publishes its pool row after writing the ack, so a test that
reads its own ack and then looks the session up by name can arrive in the
instant before the publish. Both post-exit waits in
crates/felis-daemon/src/serve/tests.rs treated an absent handle as a
failed premise and panicked with "the graced session must stay in the
pool"; they now retry until their own deadline, which is the order
docs/explanation/architecture/session-lifecycle.md documents. Daemon
behavior is unchanged — this is a test-side fix.

Verified: the two affected tests pass repeatedly under --test-threads 16
(the shape that reproduced the failure locally), plus
cargo clippy -p felis-daemon --all-targets -D warnings and
cargo fmt --check.

Follow-up to #79, which turned main's `cargo build / clippy / test / deny` job red on a load-sensitive test. A create publishes its pool row after writing the ack, so a test that reads its own ack and then looks the session up by name can arrive in the instant before the publish. Both post-exit waits in `crates/felis-daemon/src/serve/tests.rs` treated an absent handle as a failed premise and panicked with "the graced session must stay in the pool"; they now retry until their own deadline, which is the order `docs/explanation/architecture/session-lifecycle.md` documents. Daemon behavior is unchanged — this is a test-side fix. Verified: the two affected tests pass repeatedly under `--test-threads 16` (the shape that reproduced the failure locally), plus `cargo clippy -p felis-daemon --all-targets -D warnings` and `cargo fmt --check`.

natsukium added 1 commit 2026-09-04 18:58:13 +09:00

test(daemon): let the exit waits race the create's publish ... 3ddbacaae9

A create publishes its pool row after it writes the ack, so a test that
reads its own ack and then looks the session up by name can arrive in
the instant before the publish. Both post-exit waits treated an absent
handle as a failed premise and panicked with "the graced session must
stay in the pool", which is how
`a_live_only_attach_is_refused_on_a_corpse_but_a_deliberate_one_lands`
failed on a loaded runner while passing everywhere else. The waits now
retry an absent handle until their own deadline, which is what the
publication order documents (`architecture/session-lifecycle.md`).

natsukium merged commit 3ddbacaae9 into main 2026-09-04 19:08:36 +09:00

natsukium deleted branch fix/held-row-publish-race-20 2026-09-04 19:08:36 +09:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

priority/P0

Must be resolved before the v0.1.0 tag

  

priority/P1

Must be settled before the first public contract freezes

  

priority/P2

Explicitly deferred until after v0.1.0

  

release/v0.1.0

Work tracked for the first tagged release

  

status/blocked

Cannot start now: waits on an upstream release, another issue, or a recorded revisit trigger

  

status/planned

Triaged with a source-grounded plan and a passed pi review; ready to implement

  

type/bug

Shipped behavior that contradicts the docs or the code's own intent; needs a product code change

  

type/design

An open scope or trade-off question; needs a recorded decision in the owning explanation doc before code

  

type/test-gap

Documented or reviewed behavior that no test pins; usually split from a review finding, needs no product code change

  

type/tracker

Parent issue that tracks child work

No labels

priority/P0

priority/P1

priority/P2

release/v0.1.0

status/blocked

status/planned

type/bug

type/design

type/test-gap

type/tracker

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

natsukium/felis!80

No description provided.