felis-terminal/felis

Watch

render: pin the cell instance bytes and paint cost #170

Merged

natsukium merged 1 commit from render/pin-paint-output into main

2026-10-18 18:50:25 +09:00

natsukium commented

2026-10-18 18:29:00 +09:00

Owner

First of four PRs that extract the wgpu-free half of felis-render-wgpu (palette, box drawing, glyph index, cell painter) into a new felis-render-core crate, so a CPU-rendered client can reuse it instead of reimplementing it. This one changes no behavior; it pins what the later moves must preserve.

RowCache::paint_frame + CellFrame: the former Renderer::build_cell_instances body, moved verbatim, so the renderer and the tests share one path from a screen to the uploaded instances.
Golden test (row_cache/golden_tests.rs): seven small scenarios (SGR colors, screen reverse, wide/cluster cells with every cursor style, decorations incl. SGR 58, preedit + search, link preview, confirm over search) compared byte-for-byte against tests/fixtures/paint_frame/*.bin, over a real GlyphIndex at the production atlas sides. Regenerate with UPDATE_GOLDEN=1 / just golden.
Criterion bench paint_frame: full 200x60 repaint (~512 µs), one dirty row (~8.5 µs), cursor move (~16.7 µs), the baseline the painter move is measured against.
row_cache becomes pub mod with RowCache, RowCache::new, paint_frame, CellFrame public, as far as the bench needs.

Next: phase 2 creates felis-render-core with pure moves (palette, box_drawing, atlas) and a deny.toml wrappers ban keeping wgpu/winit out of it.

Verified: just check green locally; sol review PASS.

First of four PRs that extract the wgpu-free half of `felis-render-wgpu` (palette, box drawing, glyph index, cell painter) into a new `felis-render-core` crate, so a CPU-rendered client can reuse it instead of reimplementing it. This one changes no behavior; it pins what the later moves must preserve. - `RowCache::paint_frame` + `CellFrame`: the former `Renderer::build_cell_instances` body, moved verbatim, so the renderer and the tests share one path from a screen to the uploaded instances. - Golden test (`row_cache/golden_tests.rs`): seven small scenarios (SGR colors, screen reverse, wide/cluster cells with every cursor style, decorations incl. SGR 58, preedit + search, link preview, confirm over search) compared byte-for-byte against `tests/fixtures/paint_frame/*.bin`, over a real `GlyphIndex` at the production atlas sides. Regenerate with `UPDATE_GOLDEN=1` / `just golden`. - Criterion bench `paint_frame`: full 200x60 repaint (~512 µs), one dirty row (~8.5 µs), cursor move (~16.7 µs), the baseline the painter move is measured against. - `row_cache` becomes `pub mod` with `RowCache`, `RowCache::new`, `paint_frame`, `CellFrame` public, as far as the bench needs. Next: phase 2 creates `felis-render-core` with pure moves (palette, box_drawing, atlas) and a `deny.toml` `wrappers` ban keeping `wgpu`/`winit` out of it. Verified: `just check` green locally; sol review PASS.

natsukium added 1 commit

2026-10-18 18:29:00 +09:00

render, docs, skills: pin the cell instance bytes and paint cost

fuzz / cargo fuzz nightly long-run (pull_request) Has been skipped

Details

darwin / detect relevant changes (pull_request) Successful in 9s

Details

darwin / darwin docs-only no-op (pull_request) Has been skipped

Details

windows / detect relevant changes (pull_request) Successful in 14s

Details

windows / windows docs-only no-op (pull_request) Has been skipped

Details

bench / instruction-count regression gate (pull_request) Successful in 47s

Details

fuzz / cargo fuzz smoke (per target) (pull_request) Successful in 50s

Details

darwin / build felis (aarch64-darwin) (pull_request) Successful in 2m40s

Details

pr / nix flake check (pull_request) Successful in 1m19s

Details

windows / cargo nextest (Windows) (pull_request) Successful in 3m55s

Details

pr / cargo build / clippy / test / deny (pull_request) Successful in 1m41s

Details

pr / wire schema is compatible with the base (pull_request) Successful in 3s

Details

windows / frontend smoke (Windows) (pull_request) Successful in 38s

Details

pr / frontend smoke (x86_64-linux) (pull_request) Successful in 29s

Details

windows / cargo clippy (Windows cross) (pull_request) Successful in 15s

Details

a06fc10600

The renderer-neutral half of felis-render-wgpu (painter, glyph index,
palette) is about to move into its own crate, and glyph sources will
switch from normalized uv to atlas pixels. Neither change may alter
what reaches the GPU, and the painter's unit tests assert fields
against a mock atlas, so they cannot show that.

RowCache::paint_frame is now the one path from a screen and its frame
state to the uploaded instances; the renderer and a byte-level golden
test both go through it, the test over a real GlyphIndex at the
production atlas sides. The paint_frame bench records the full,
one-row and cursor-move costs the move is measured against.

Assisted-by: Claude Code

natsukium referenced this pull request

2026-10-18 18:44:18 +09:00

render: start felis-render-core with the renderer-neutral types #171

natsukium merged commit ea600baf4d into main

2026-10-18 18:50:25 +09:00

natsukium deleted branch render/pin-paint-output

2026-10-18 18:50:25 +09:00

natsukium referenced this pull request from a commit

2026-10-18 18:50:26 +09:00

Merge pull request 'render: pin the cell instance bytes and paint cost' (#170) from render/pin-paint-output into main

natsukium referenced this pull request

2026-10-18 19:00:56 +09:00