natsukium/felis-fcast
Watch
1
Code Issues 10 Pull requests Projects Releases 1 Packages Wiki Activity Actions

fix(cast): stop record --help overstating that sessions survive #16

Merged
natsukium merged 2 commits from fix/record-help into main 2026-10-14 23:20:55 +09:00
Conversation 0 Commits 2 Files changed 3 +34 -3
natsukium commented 2026-10-14 23:10:50 +09:00
Owner
Copy link

Help-text fixes from the pi review of the finished CLI: qualify the Ctrl-C claim with the --headless exception, and list what --session excludes.

Help-text fixes from the pi review of the finished CLI: qualify the Ctrl-C claim with the --headless exception, and list what --session excludes.
fix(cast): stop record --help overstating that sessions survive
Some checks failed
ci / cargo fmt / clippy / test / deny (pull_request) Failing after 2m9s
Details
ci / cargo fuzz smoke (pull_request) Successful in 2m5s
Details
8fb6ee2a60
 
The record help said Ctrl-C 'never stops the session', but a session
--headless created is killed when the recording stops before it exits
(docs/reference/cli.md), so a reader trusting the help would lose a
headless session they expected to reattach to. The --session help now
also names the options it excludes, so the conflict is visible before
clap rejects the combination.
fix(cast): let play bind its socket under any umask
All checks were successful
ci / cargo fuzz smoke (pull_request) Successful in 2m7s
Details
ci / cargo fuzz smoke (push) Successful in 2m8s
Details
ci / cargo fmt / clippy / test / deny (pull_request) Successful in 57s
Details
ci / cargo fmt / clippy / test / deny (push) Successful in 54s
Details
862c8c3c0b
 
play created its private directory with DirBuilder::mode(0o700), but
the mode is masked by the umask, so a umask that clears the owner's
search bit (0177, which felis-daemon itself sets around its bind) left a
directory play could not bind a socket in: 'Permission denied' and exit
2. CI's sandboxed build hit it when a test daemon in the same process
had set that umask before play spawned. set_permissions after the create
is not masked.
natsukium deleted branch fix/record-help 2026-10-14 23:20:55 +09:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
natsukium/felis-fcast!16
No description provided.