natsukium/felis-fcast
Watch
1
Code Issues 10 Pull requests Projects Releases 1 Packages Wiki Activity Actions

fix(cast): follow-ups from the CLI review #17

Merged
natsukium merged 3 commits from feat/cli-review-fixes into main 2026-10-14 23:53:04 +09:00
Conversation 0 Commits 3 Files changed 5 +92 -21
natsukium commented 2026-10-14 23:48:24 +09:00
Owner
Copy link

serve no longer unlinks a live socket; record --help says which session it records and where --session ids come from; backlog gains command listing and exit-status propagation.

serve no longer unlinks a live socket; record --help says which session it records and where --session ids come from; backlog gains command listing and exit-status propagation.
Both came out of the CLI review. Command listing is feasible from what
a recording already holds (prompt_mark frames plus rows) but has no user
yet; propagating the program's exit status for CI cannot be done until
felis puts the status on the wire. Recording them keeps the reasoning,
including the last_exit_code dead end, from being redone.
serve unlinked any socket at its bind path so a leftover from a killed
run would not block the bind. But it did so without asking whether
anything still listened there, so 'serve --socket $FELIS_SOCKET' (an
easy slip, since record defaults to that socket) would unlink the real
daemon's socket and leave it unreachable. It now dials the socket first
and refuses one that answers. A path that is not a socket was already
left alone but failed with a bare EADDRINUSE; it now says why. Both
refusals exit 1, like record's existing-file refusal.
fix(cast): say in record --help which session it records
All checks were successful
ci / cargo fmt / clippy / test / deny (pull_request) Successful in 2m8s
Details
ci / cargo fuzz smoke (pull_request) Successful in 2m0s
Details
ci / cargo fmt / clippy / test / deny (push) Successful in 49s
Details
ci / cargo fuzz smoke (push) Successful in 1m59s
Details
c496f786e2
 
A reviewer walking through 'record what I do' expected the shell the
command was typed in to be recorded; the help said the command creates a
session but not that the invoking shell is left out. The first sentence
now says so. --session needs an id but nothing pointed at where ids come
from; its help and the reference now name 'felis sessions list'. The
reference also lists serve's taken socket among the exit-1 refusals.
natsukium deleted branch feat/cli-review-fixes 2026-10-14 23:53:04 +09:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
natsukium/felis-fcast!17
No description provided.