natsukium/felis
Archived
Watch
1
Code Issues 23 Pull requests Projects Releases 6 Packages Wiki Activity Actions

docs: record why the workspace has no test-helper crates #437

Merged
natsukium merged 1 commit from docs/no-test-helper-crates into main 2026-09-25 12:30:05 +09:00
Conversation 0 Commits 1 Files changed 3 +11 -5
natsukium commented 2026-09-25 11:55:50 +09:00
Owner
Copy link

The implement-feature and test-strategy skills told agents that crates/ is fixed at eleven crates and that no felis-test-* helper crate may be added, but no doc recorded either rule.

Per the decision on the issue:

  • The "no test-helper crates" decision is recorded in docs/explanation/architecture/overview.md "Rejected workspace shapes" (the crate-boundary record): every crate is an extraction seam, a shared helper crate is an edge each extracted crate would carry or un-pick, and a test reaching above its crate root belongs in tests/. It carries a Revisit if trigger.
  • The crate count stays a fact in docs/reference/workspace.md. The skills drop "fixed at eleven" / "no new crates" and cite the record; AGENTS.md's "eleven felis-* crates" is a fact statement and is left alone.

Closes #392

The implement-feature and test-strategy skills told agents that `crates/` is fixed at eleven crates and that no `felis-test-*` helper crate may be added, but no doc recorded either rule. Per the decision on the issue: - The "no test-helper crates" decision is recorded in `docs/explanation/architecture/overview.md` "Rejected workspace shapes" (the crate-boundary record): every crate is an extraction seam, a shared helper crate is an edge each extracted crate would carry or un-pick, and a test reaching above its crate root belongs in `tests/`. It carries a _Revisit if_ trigger. - The crate count stays a fact in `docs/reference/workspace.md`. The skills drop "fixed at eleven" / "no new crates" and cite the record; AGENTS.md's "eleven `felis-*` crates" is a fact statement and is left alone. Closes #392
docs: record why the workspace has no test-helper crates
Some checks failed
darwin / detect relevant changes (pull_request) Successful in 13s
Details
darwin / build felis (aarch64-darwin) (pull_request) Has been skipped
Details
darwin / publish felis (aarch64-darwin) (pull_request) Has been skipped
Details
darwin / darwin docs-only no-op (pull_request) Successful in 0s
Details
windows / detect relevant changes (pull_request) Successful in 24s
Details
windows / cargo nextest (Windows) (pull_request) Has been skipped
Details
windows / frontend smoke (Windows) (pull_request) Has been skipped
Details
windows / package felis (x86_64-pc-windows-msvc) (pull_request) Has been skipped
Details
windows / windows docs-only no-op (pull_request) Successful in 1s
Details
pr / nix flake check (pull_request) Successful in 28s
Details
pr / cargo build / clippy / test / deny (pull_request) Successful in 2m12s
Details
pr / wire schema is compatible with the base (pull_request) Successful in 27s
Details
windows / cargo clippy (Windows cross) (pull_request) Has been cancelled
Details
pr / publish felis (x86_64-linux) (pull_request) Has been cancelled
Details
pr / frontend smoke (x86_64-linux) (pull_request) Has been cancelled
Details
ed9d6922a5
 
The implement-feature and test-strategy skills told agents that
`crates/` is fixed at eleven crates and that no `felis-test-*` helper
crate may be added, citing AGENTS.md, but no doc recorded either rule.

Only the helper-crate ban is a decision: a shared test-helper crate is
the shape a contributor reaches for first, and nothing in the crate map
shows why it fails, so it passes the record gate and now sits among
the rejected workspace shapes with its revisit trigger. The crate count
is a fact reference/workspace.md already states; a new crate is argued
against the crate-boundary record like any other seam, so the skills
drop the fixed count and cite the record instead.

Assisted-by: Claude Code
natsukium deleted branch docs/no-test-helper-crates 2026-09-25 12:30:05 +09:00
Commenting is not possible because the repository is archived.
Reviewers
No reviewers
Labels
Clear labels   
priority/P0
Must be resolved before the v0.1.0 tag

  
priority/P1
Must be settled before the first public contract freezes

  
priority/P2
Explicitly deferred until after v0.1.0

  
release/v0.1.0
Work tracked for the first tagged release

  
status/blocked
Cannot start now: waits on an upstream release, another issue, or a recorded revisit trigger

  
status/planned
Triaged with a source-grounded plan and a passed pi review; ready to implement

  
type/bug
Shipped behavior that contradicts the docs or the code's own intent; needs a product code change

  
type/design
An open scope or trade-off question; needs a recorded decision in the owning explanation doc before code

  
type/test-gap
Documented or reviewed behavior that no test pins; usually split from a review finding, needs no product code change

  
type/tracker
Parent issue that tracks child work

No labels
priority/P0
priority/P1
priority/P2
release/v0.1.0
status/blocked
status/planned
type/bug
type/design
type/test-gap
type/tracker
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
natsukium/felis!437
No description provided.